3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use -[NSNumber numberWithDouble:] for doubles

Browse Source 
Found by -fsanitize=undefined:
[ RUN      ] Launchd.CFPropertyToLaunchData_FloatingPoint
../../../util/mac/launchd_test.mm:82:33: runtime error: value
1.79769e+308 is outside the range of representable values of type
'float'
[       OK ] Launchd.CFPropertyToLaunchData_FloatingPoint (2 ms)

TEST=crashpad_util_test Launchd.CFPropertyToLaunchData_FloatingPoint
BUG=
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1302843004 .
This commit is contained in:
Mark Mentovai 2015-08-20 09:29:23 -04:00
parent 899821d4c7
commit 5064aeb784
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
util/mac/launchd_test.mm
View File

@ -78,12 +78,12 @@ TEST(Launchd, CFPropertyToLaunchData_FloatingPoint) {
@-1.0,
[NSNumber numberWithFloat:std::numeric_limits<float>::min()],
[NSNumber numberWithFloat:std::numeric_limits<float>::max()],
[NSNumber numberWithFloat:std::numeric_limits<double>::min()],
[NSNumber numberWithFloat:std::numeric_limits<double>::max()],
[NSNumber numberWithDouble:std::numeric_limits<double>::min()],
[NSNumber numberWithDouble:std::numeric_limits<double>::max()],
@3.1415926535897932,
[NSNumber numberWithFloat:std::numeric_limits<double>::infinity()],
[NSNumber numberWithFloat:std::numeric_limits<double>::quiet_NaN()],
[NSNumber numberWithFloat:std::numeric_limits<double>::signaling_NaN()],
[NSNumber numberWithDouble:std::numeric_limits<double>::infinity()],
[NSNumber numberWithDouble:std::numeric_limits<double>::quiet_NaN()],
[NSNumber numberWithDouble:std::numeric_limits<double>::signaling_NaN()],
};
for (size_t index = 0; index < arraysize(double_nses); ++index) {