From 5064aeb78477889bebf29b5ef630201b60a84b3e Mon Sep 17 00:00:00 2001
From: Mark Mentovai <mark@chromium.org>
Date: Thu, 20 Aug 2015 09:29:23 -0400
Subject: [PATCH] Use -[NSNumber numberWithDouble:] for doubles

Found by -fsanitize=undefined:
[ RUN      ] Launchd.CFPropertyToLaunchData_FloatingPoint
../../../util/mac/launchd_test.mm:82:33: runtime error: value
1.79769e+308 is outside the range of representable values of type
'float'
[       OK ] Launchd.CFPropertyToLaunchData_FloatingPoint (2 ms)

TEST=crashpad_util_test Launchd.CFPropertyToLaunchData_FloatingPoint
BUG=
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1302843004 .
---
 util/mac/launchd_test.mm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/util/mac/launchd_test.mm b/util/mac/launchd_test.mm
index 65722a42..8f60fc91 100644
--- a/util/mac/launchd_test.mm
+++ b/util/mac/launchd_test.mm
@@ -78,12 +78,12 @@ TEST(Launchd, CFPropertyToLaunchData_FloatingPoint) {
       @-1.0,
       [NSNumber numberWithFloat:std::numeric_limits<float>::min()],
       [NSNumber numberWithFloat:std::numeric_limits<float>::max()],
-      [NSNumber numberWithFloat:std::numeric_limits<double>::min()],
-      [NSNumber numberWithFloat:std::numeric_limits<double>::max()],
+      [NSNumber numberWithDouble:std::numeric_limits<double>::min()],
+      [NSNumber numberWithDouble:std::numeric_limits<double>::max()],
       @3.1415926535897932,
-      [NSNumber numberWithFloat:std::numeric_limits<double>::infinity()],
-      [NSNumber numberWithFloat:std::numeric_limits<double>::quiet_NaN()],
-      [NSNumber numberWithFloat:std::numeric_limits<double>::signaling_NaN()],
+      [NSNumber numberWithDouble:std::numeric_limits<double>::infinity()],
+      [NSNumber numberWithDouble:std::numeric_limits<double>::quiet_NaN()],
+      [NSNumber numberWithDouble:std::numeric_limits<double>::signaling_NaN()],
     };
 
     for (size_t index = 0; index < arraysize(double_nses); ++index) {