3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:16:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix -Winconsistent-missing-override in CrashReportUploadThread

Browse Source 
Chromium builds with a newer clang than the Crashpad buildbot, and it
reports:

../../../handler/crash_report_upload_thread.cc:148:16: error: 'ThreadMain' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void ThreadMain() {
               ^
../../../util/thread/thread.h:46:16: note: overridden virtual function is here
  virtual void ThreadMain() = 0;
               ^
1 error generated.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1302833002 .
This commit is contained in:
Mark Mentovai 2015-08-19 22:41:46 -04:00
parent 3b6e5613cb
commit 899821d4c7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
handler/crash_report_upload_thread.cc
View File

@ -145,7 +145,7 @@ class CrashReportUploadHelperThread final : public Thread {
: self_(self) {}
~CrashReportUploadHelperThread() override {}
virtual void ThreadMain() {
void ThreadMain() override {
self_->ThreadMain();
}