3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-28 07:48:14 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/util/BUILD.gn

765 lines
22 KiB
Plaintext
Raw Normal View History

Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
# Copyright 2015 The Crashpad Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
import("../build/crashpad_buildconfig.gni")
fuchsia: Don’t require test certificate setup for disabled TLS tests This is a follow-up to e6f26587e435. Bug: DX-382 Change-Id: I3116ea5dd2eca33961465d62c9200aa8dd1baf5d Reviewed-on: https://chromium-review.googlesource.com/1173339 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-08-13 19:24:49 -04:00
import("net/tls.gni")
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
win: disable string_number_conversion_test for asan/dll Upstreams: https://chromium-review.googlesource.com/c/chromium/src/+/1113664 Change-Id: I8c3000eebf2be54e8d693bf08a6e92b68c1d5d72 Reviewed-on: https://chromium-review.googlesource.com/1195567 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-08-29 09:33:25 -07:00
if (crashpad_is_in_chromium) {
import("//build/config/sanitizers/sanitizers.gni")
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_mac) {
fuchsia: Let util build in Mac-host builds Some of the minidump functionality is going to be used in Fuchsia in host side tools (in zxdb, the debugger). This fixes the Mac-host build of util. Change-Id: Ifeb3bd9c7fa29c99a272c97c2813b9c201ddfe88 Reviewed-on: https://chromium-review.googlesource.com/c/1277774 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-10-11 14:51:52 -07:00
if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
gn: Refactor build files to avoid build/secondary In doing standalone bringup of Crashpad targeting Fuchsia, it seemed tidy to keep the same literal paths to the dependencies that Chromium needed and add stubs/forwarding to build/secondary in the Crashpad tree as required to make those work. However, when trying to build Crashpad in the Fuchsia tree itself, that would require adding forwarding files to the Fuchsia tree to match the Chromium directory structure, which would be awkward. Instead, have explicit dependencies in the Crashpad tree that select the locations for various dependencies. Bug: crashpad:79, crashpad:196 Change-Id: Ib506839f9c97d8ef823663cdc733cbdcfa126139 Reviewed-on: https://chromium-review.googlesource.com/826025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-18 14:35:55 -08:00
import("//build/config/sysroot.gni")
} else {
import("//third_party/mini_chromium/mini_chromium/build/sysroot.gni")
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
action_foreach("mig") {
script = "mach/mig.py"
sources = [
"$sysroot/usr/include/mach/exc.defs",
"$sysroot/usr/include/mach/mach_exc.defs",
"$sysroot/usr/include/mach/notify.defs",
"mach/child_port.defs",
]
outputs = [
"$target_gen_dir/mach/{{source_name_part}}User.c",
"$target_gen_dir/mach/{{source_name_part}}Server.c",
"$target_gen_dir/mach/{{source_name_part}}.h",
"$target_gen_dir/mach/{{source_name_part}}Server.h",
]
args = [ "{{source}}" ]
args += rebase_path(outputs, root_build_dir)
gn: Refactor build files to avoid build/secondary In doing standalone bringup of Crashpad targeting Fuchsia, it seemed tidy to keep the same literal paths to the dependencies that Chromium needed and add stubs/forwarding to build/secondary in the Crashpad tree as required to make those work. However, when trying to build Crashpad in the Fuchsia tree itself, that would require adding forwarding files to the Fuchsia tree to match the Chromium directory structure, which would be awkward. Instead, have explicit dependencies in the Crashpad tree that select the locations for various dependencies. Bug: crashpad:79, crashpad:196 Change-Id: Ib506839f9c97d8ef823663cdc733cbdcfa126139 Reviewed-on: https://chromium-review.googlesource.com/826025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-18 14:35:55 -08:00
if (crashpad_is_in_chromium) {
if (!use_system_xcode) {
Use explicit paths when using hermetic toolchain. Previously, both the invocation to mig and mig's internal code would use xcrun to locate binaries. When we're using the hermetic toolchain, we want to explicitly specify the binaries to use and we want to avoid calls to xcrun. Bug: chromium:971452 Change-Id: I8527368e0846bc72789e6454fcd626b028d297ff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1650147 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-06-07 11:37:56 -07:00
import("//build/config/clang/clang.gni")
import("//build/config/mac/mac_sdk.gni")
[Log minidump] OutputStream interface and zlib implementation This is the 1st patch for logging minidump in Android. it adds OutputStream interface and zlib implementation for output pipline. Bug: crashpad:308 Change-Id: I4738b8f223886049e6e259b9b25c00e5120156e5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1745355 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-09-05 17:53:01 -07:00
clang_path =
rebase_path("$clang_base_path/bin/", root_build_dir) + "clang"
Use explicit paths when using hermetic toolchain. Previously, both the invocation to mig and mig's internal code would use xcrun to locate binaries. When we're using the hermetic toolchain, we want to explicitly specify the binaries to use and we want to avoid calls to xcrun. Bug: chromium:971452 Change-Id: I8527368e0846bc72789e6454fcd626b028d297ff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1650147 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-06-07 11:37:56 -07:00
mig_path = "$mac_bin_path" + "mig"
migcom_path = "$mac_bin_path" + "../libexec/migcom"
gn: Refactor build files to avoid build/secondary In doing standalone bringup of Crashpad targeting Fuchsia, it seemed tidy to keep the same literal paths to the dependencies that Chromium needed and add stubs/forwarding to build/secondary in the Crashpad tree as required to make those work. However, when trying to build Crashpad in the Fuchsia tree itself, that would require adding forwarding files to the Fuchsia tree to match the Chromium directory structure, which would be awkward. Instead, have explicit dependencies in the Crashpad tree that select the locations for various dependencies. Bug: crashpad:79, crashpad:196 Change-Id: Ib506839f9c97d8ef823663cdc733cbdcfa126139 Reviewed-on: https://chromium-review.googlesource.com/826025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-18 14:35:55 -08:00
args += [
Use explicit paths when using hermetic toolchain. Previously, both the invocation to mig and mig's internal code would use xcrun to locate binaries. When we're using the hermetic toolchain, we want to explicitly specify the binaries to use and we want to avoid calls to xcrun. Bug: chromium:971452 Change-Id: I8527368e0846bc72789e6454fcd626b028d297ff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1650147 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-06-07 11:37:56 -07:00
"--clang-path",
clang_path,
"--mig-path",
mig_path,
"--migcom-path",
migcom_path,
gn: Refactor build files to avoid build/secondary In doing standalone bringup of Crashpad targeting Fuchsia, it seemed tidy to keep the same literal paths to the dependencies that Chromium needed and add stubs/forwarding to build/secondary in the Crashpad tree as required to make those work. However, when trying to build Crashpad in the Fuchsia tree itself, that would require adding forwarding files to the Fuchsia tree to match the Chromium directory structure, which would be awkward. Instead, have explicit dependencies in the Crashpad tree that select the locations for various dependencies. Bug: crashpad:79, crashpad:196 Change-Id: Ib506839f9c97d8ef823663cdc733cbdcfa126139 Reviewed-on: https://chromium-review.googlesource.com/826025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-18 14:35:55 -08:00
]
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
gn, mac: Work without a sysroot This is needed to make the “sysroot = "/"” configuration, which translates to “sysroot = ""”, work properly Bug: crashpad:79 Change-Id: I25ab49b7d57abfcf0ce9a62925013bb58dadf5dd Reviewed-on: https://chromium-review.googlesource.com/831007 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-15 18:49:34 -05:00
if (sysroot != "") {
args += [
"--sdk",
sysroot,
]
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
args += [
"--include",
rebase_path("../compat/mac", root_build_dir),
]
}
Prepare crashpad mig stuff for -Wunreachable-code in chromium_code. Bug: chromium:346399 Change-Id: I5d93a2f6781dd4dd3483009d9c470050d490be3c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2116252 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
2020-03-23 14:59:21 -04:00
source_set("mig_output") {
deps = [ ":mig" ]
sources = get_target_outputs(":mig")
if (crashpad_is_in_chromium) {
# mig output contains unreachable code, which irks -Wunreachable-code.
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
}
public_configs = [ "..:crashpad_config" ]
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
static_library("util") {
sources = [
"file/delimited_file_reader.cc",
"file/delimited_file_reader.h",
"file/directory_reader.h",
"file/file_io.cc",
"file/file_io.h",
"file/file_reader.cc",
"file/file_reader.h",
"file/file_seeker.cc",
"file/file_seeker.h",
"file/file_writer.cc",
"file/file_writer.h",
"file/filesystem.h",
[log minidump] add option to log minidump in handler_main - Add option to log minidump in handler_main, also add option to disable to dump minidump and generate report. - Implement log minidump in CrashReportExceptionHandler. Bug: crashpad:308 Change-Id: I8d2f7e118912011a8416f1ec36c9ee9d561d06e6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1995825 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2020-01-28 12:02:55 -08:00
"file/output_stream_file_writer.cc",
"file/output_stream_file_writer.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"file/scoped_remove_file.cc",
"file/scoped_remove_file.h",
"file/string_file.cc",
"file/string_file.h",
"misc/address_sanitizer.h",
"misc/address_types.h",
Remove base's arraysize from Crashpad. BUG=837308 R=mark@chromium.org Change-Id: Ibecbfc7bc2d61ee54bc1114e4b20978adbc77db2 Reviewed-on: https://chromium-review.googlesource.com/c/1393921 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org>
2019-01-03 13:36:02 -05:00
"misc/arraysize.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/as_underlying_type.h",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/clock.h",
Get CrashpadInfo address via a .note, rather than dynamic symtab Embeds the address of g_crashpad_info into a .note section (which is readable by the generic code to read notes in ElfImageReader). Unfortunately because the note section is in libclient.a, it would normally be dropped at link time. To avoid that, GetCrashpadInfo() has a reference *back* to that section, which in turn forces the linker to include it, allowing the note reader to find it at runtime. Previously, it was necessary to have the embedder of "client" figure out how to cause `g_crashpad_info` to appear in the final module's dynamic symbol table. With this new approach, there's no manual configuration necessary, as it's not necessary for the symbol to be exported. This is currently only implemented in the Linux module reader (and I believe the current set of enabled tests aren't exercising it?) but it will also be done this way for the Fuchsia implementation of ModuleSnapshot. Bug: crashpad:196 Change-Id: I599db5903bc98303130d11ad850ba9ceed3b801a Reviewed-on: https://chromium-review.googlesource.com/912284 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-02-15 10:38:36 -08:00
"misc/elf_note_types.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/from_pointer_cast.h",
"misc/implicit_cast.h",
"misc/initialization_state.h",
"misc/initialization_state_dcheck.cc",
"misc/initialization_state_dcheck.h",
"misc/lexing.cc",
"misc/lexing.h",
Fix MSan failures Bug: 932205 Change-Id: Ic31986d270634e42bf8c2620f37c434a4cb79b33 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1474271 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
2019-06-28 15:20:01 -07:00
"misc/memory_sanitizer.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/metrics.cc",
"misc/metrics.h",
"misc/paths.h",
"misc/pdb_structures.cc",
"misc/pdb_structures.h",
"misc/random_string.cc",
"misc/random_string.h",
Add ProcessSnapshotSanitized A ProcessSnapshotSanitized enables filtering possibly sensitive information from a snapshot. WebView has different privacy constraints than Chrome and needs to avoid collecting data in annotations or from stack memory that may contain PII. This CL enables: 1. Filtering annotations by name using a whitelist. 2. Filtering for crashes which reference a particular module. 3. Redacting non-essential information from stack memory. This CL does not provide a client interface to enable sanitization. Bug: crashpad:30 Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254 Reviewed-on: https://chromium-review.googlesource.com/1070472 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-11 09:38:24 -07:00
"misc/range_set.cc",
"misc/range_set.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/reinterpret_bytes.cc",
"misc/reinterpret_bytes.h",
"misc/scoped_forbid_return.cc",
"misc/scoped_forbid_return.h",
"misc/symbolic_constants_common.h",
"misc/time.cc",
"misc/time.h",
"misc/tri_state.h",
"misc/uuid.cc",
"misc/uuid.h",
"misc/zlib.cc",
"misc/zlib.h",
"net/http_body.cc",
"net/http_body.h",
"net/http_body_gzip.cc",
"net/http_body_gzip.h",
"net/http_headers.h",
"net/http_multipart_builder.cc",
"net/http_multipart_builder.h",
"net/http_transport.cc",
"net/http_transport.h",
"net/url.cc",
"net/url.h",
"numeric/checked_address_range.cc",
"numeric/checked_address_range.h",
"numeric/checked_range.h",
"numeric/checked_vm_address_range.h",
"numeric/in_range_cast.h",
"numeric/int128.h",
"numeric/safe_assignment.h",
Remove pid_t in platform-independent code. Change-Id: Ia58e07bf85a09cd7e63784220800431ad1366584 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1565273 Commit-Queue: Eric Astor <epastor@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-24 11:22:35 -04:00
"process/process_id.h",
Make TaskMemory a child class of ProcessMemory Currently TaskMemory re-implements a number of Read* routines that are implemented in a platform-independent way in ProcessMemory with access to a single platform-specific ReadUpTo method. Implement the ReadUpTo method for TaskMemory and subclass it from ProcessMemory to inherit the remaining methods. The ProcessMemoryTests didn't work on macOS because MultiprocessExec can not access the child process' task port without root privileges or the task_for_pid entitlement. Create an adaptor class for those tests to use MachMultiprocess so that the child process sends its task port to the parent. Bug: crashpad:263 Change-Id: Id8e1788a74fe957f05703a5eb569ca3bf9870369 Reviewed-on: https://chromium-review.googlesource.com/c/1387265 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-20 11:12:51 -08:00
"process/process_memory.cc",
"process/process_memory.h",
"process/process_memory_native.h",
"process/process_memory_range.cc",
"process/process_memory_range.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"stdlib/aligned_allocator.cc",
"stdlib/aligned_allocator.h",
"stdlib/map_insert.h",
"stdlib/objc.h",
"stdlib/string_number_conversion.cc",
"stdlib/string_number_conversion.h",
"stdlib/strlcpy.cc",
"stdlib/strlcpy.h",
"stdlib/strnlen.cc",
"stdlib/strnlen.h",
"stdlib/thread_safe_vector.h",
[log minidump] Base94OutputStream implementation Add Base94 encoding/decoding implementation and tests. Bug: crashpad:308 Change-Id: If3f25efcb277eacd5d8cbe1d66f22919872c7d64 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1796682 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-06 10:54:44 -08:00
"stream/base94_output_stream.cc",
"stream/base94_output_stream.h",
[log minidump] add tool to encode/decode minidump log. - This tool could compress/encode or decode/decompress the minidump log file, will be used by script to symbolize the crash. - Added FileOutputStream and FileEncoder. Bug: crashpad:308 Change-Id: I15c3e4908882a09983ec81a90e38249967c29fc4 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1968059 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-18 11:33:39 -08:00
"stream/file_encoder.cc",
"stream/file_encoder.h",
"stream/file_output_stream.cc",
"stream/file_output_stream.h",
[log minidump] LogOutputStream implementation Emit the received data to Android logcat in Android, and noop for other platforms. Bug: crashpad:308 Change-Id: I6e46e2fa8bd61f93f614ad0bfb6441a79139b04b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1958711 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-12 13:15:05 -08:00
"stream/log_output_stream.cc",
"stream/log_output_stream.h",
[Log minidump] OutputStream interface and zlib implementation This is the 1st patch for logging minidump in Android. it adds OutputStream interface and zlib implementation for output pipline. Bug: crashpad:308 Change-Id: I4738b8f223886049e6e259b9b25c00e5120156e5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1745355 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-09-05 17:53:01 -07:00
"stream/output_stream_interface.h",
"stream/zlib_output_stream.cc",
"stream/zlib_output_stream.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"string/split_string.cc",
"string/split_string.h",
"synchronization/semaphore.h",
Don't spawn an upload thread if url is empty Also automatically stop upload and prune threads on destruction. Bug: crashpad:30 Change-Id: I45a30944eb3052182da296e00a6d6041691ab772 Reviewed-on: https://chromium-review.googlesource.com/924456 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-20 10:55:17 -08:00
"thread/stoppable.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"thread/thread.cc",
"thread/thread.h",
"thread/thread_log_messages.cc",
"thread/thread_log_messages.h",
"thread/worker_thread.cc",
"thread/worker_thread.h",
]
[Log minidump] OutputStream interface and zlib implementation This is the 1st patch for logging minidump in Android. it adds OutputStream interface and zlib implementation for output pipline. Bug: crashpad:308 Change-Id: I4738b8f223886049e6e259b9b25c00e5120156e5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1745355 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-09-05 17:53:01 -07:00
defines = [ "ZLIB_CONST" ]
Prepare for removal of is_posix from the Fuchsia build This also rolls crashpad/third_party/mini_chromium/mini_chromium/ d42eb4101..6e0fdb2e4 (2 commits) https://chromium.googlesource.com/chromium/mini_chromium/+log/d42eb4101236..6e0fdb2e4966 $ git log d42eb4101..6e0fdb2e4 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 scottmg@chromium.org Repair Linux-with-sysroot build after clang update 2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Bug: chromium:812974 Change-Id: I3d8efc3124c97981eda63f104a7adfb670babab7 Reviewed-on: https://chromium-review.googlesource.com/988231 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-04-04 15:12:50 -07:00
if (crashpad_is_posix || crashpad_is_fuchsia) {
fuchsia: Misc fixes to get more pieces compiling - Some missed set_sources_assignment_filters if'ing - Exclude posix/symbolic_constants_posix.(h|cc) as they don't compile and won't be necessary - Exclude a handful of other posix files that don't make sense on Fuchsia. Bug: crashpad:196 Change-Id: I9ec985f00488267dc104164445c6cc5bca36a1fc Reviewed-on: https://chromium-review.googlesource.com/798220 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-11-30 09:59:59 -08:00
sources += [
"file/directory_reader_posix.cc",
"file/file_io_posix.cc",
"file/filesystem_posix.cc",
"misc/clock_posix.cc",
"posix/close_stdio.cc",
"posix/close_stdio.h",
"posix/scoped_dir.cc",
"posix/scoped_dir.h",
"posix/scoped_mmap.cc",
"posix/scoped_mmap.h",
"posix/signals.cc",
"posix/signals.h",
"synchronization/semaphore_posix.cc",
"thread/thread_posix.cc",
]
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (!crashpad_is_fuchsia) {
fuchsia: Misc fixes to get more pieces compiling - Some missed set_sources_assignment_filters if'ing - Exclude posix/symbolic_constants_posix.(h|cc) as they don't compile and won't be necessary - Exclude a handful of other posix files that don't make sense on Fuchsia. Bug: crashpad:196 Change-Id: I9ec985f00488267dc104164445c6cc5bca36a1fc Reviewed-on: https://chromium-review.googlesource.com/798220 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-11-30 09:59:59 -08:00
sources += [
"posix/close_multiple.cc",
"posix/close_multiple.h",
"posix/double_fork_and_exec.cc",
"posix/double_fork_and_exec.h",
"posix/drop_privileges.cc",
"posix/drop_privileges.h",
fuchsia: Get crashpad_util_test building Links, but various tests fail. Also adds support to run_tests.py to run a single binary, likely only useful on Fuchsia. Bug: crashpad:196 Change-Id: Ie82ef26ec214ff4262194e877469953aa8fb367e Reviewed-on: https://chromium-review.googlesource.com/809467 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-05 15:16:08 -08:00
"posix/process_info.h",
fuchsia: Misc fixes to get more pieces compiling - Some missed set_sources_assignment_filters if'ing - Exclude posix/symbolic_constants_posix.(h|cc) as they don't compile and won't be necessary - Exclude a handful of other posix files that don't make sense on Fuchsia. Bug: crashpad:196 Change-Id: I9ec985f00488267dc104164445c6cc5bca36a1fc Reviewed-on: https://chromium-review.googlesource.com/798220 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-11-30 09:59:59 -08:00
# These map signals to and from strings. While Fuchsia defines some of
# the common SIGx defines, signals are never raised on Fuchsia, so
# there's need to include this mapping code.
"posix/symbolic_constants_posix.cc",
"posix/symbolic_constants_posix.h",
]
}
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_mac) {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
sources += [
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"mac/checked_mach_address_range.h",
"mac/launchd.h",
"mac/launchd.mm",
"mac/mac_util.cc",
"mac/mac_util.h",
"mac/service_management.cc",
"mac/service_management.h",
"mac/xattr.cc",
"mac/xattr.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"mach/child_port_handshake.cc",
"mach/child_port_handshake.h",
"mach/child_port_server.cc",
"mach/child_port_server.h",
"mach/child_port_types.h",
"mach/composite_mach_message_server.cc",
"mach/composite_mach_message_server.h",
"mach/exc_client_variants.cc",
"mach/exc_client_variants.h",
"mach/exc_server_variants.cc",
"mach/exc_server_variants.h",
"mach/exception_behaviors.cc",
"mach/exception_behaviors.h",
"mach/exception_ports.cc",
"mach/exception_ports.h",
"mach/exception_types.cc",
"mach/exception_types.h",
"mach/mach_extensions.cc",
"mach/mach_extensions.h",
"mach/mach_message.cc",
"mach/mach_message.h",
"mach/mach_message_server.cc",
"mach/mach_message_server.h",
"mach/notify_server.cc",
"mach/notify_server.h",
"mach/scoped_task_suspend.cc",
"mach/scoped_task_suspend.h",
"mach/symbolic_constants_mach.cc",
"mach/symbolic_constants_mach.h",
"mach/task_for_pid.cc",
"mach/task_for_pid.h",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_mac.S",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"misc/clock_mac.cc",
"misc/paths_mac.cc",
"net/http_transport_mac.mm",
"posix/process_info_mac.cc",
Move and rename TaskMemory to ProcessMemoryMac Bug: crashpad:263 Change-Id: I5efa4fe26f09c8b8a8db6dbcedc416724404b894 Reviewed-on: https://chromium-review.googlesource.com/c/1387884 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-20 13:12:55 -08:00
"process/process_memory_mac.cc",
"process/process_memory_mac.h",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"synchronization/semaphore_mac.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
]
}
fuchsia: Fix build vs. TLS support when in-tree Depend on the BoringSSL target instead of the libs when building in the Fuchsia tree. Bug: crashpad:196 Change-Id: Ib1faa9335eedff1fd9dd072234df2d48612ab423 Reviewed-on: https://chromium-review.googlesource.com/1079434 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-30 15:08:18 -07:00
deps = []
android: enable upload This patch also updates WorkerThread to execute DoWork() when DoWorkNow() has been called, which is relevant when DoWorkNow() and Stop() have both been called. This occurs regularly on Android where the handler's current normal mode is to dump a single process and exit. This change ensures the upload thread has a chance to upload the report before the handler exits. This change should not affect upload on Chrome/WebView/Chromecast which don't pass Crashpad a --url option and are still responsible for their own uploads. Change-Id: Ie5553eafc13714f0438b4b133a92516f7abec153 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1643710 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-06-18 09:48:52 -07:00
if (crashpad_is_linux || crashpad_is_fuchsia || crashpad_is_android) {
Implementation of HTTPTransport via raw socket Partial implementation: Currently only handles http (i.e. no TLS), only POST, and only certain response types (only when Content-Length is specified, and not chunked). Used for Linux and Fuchsia lacking anything better (that's shippable). Removes libcurl HTTPTransport, since it isn't available in the Chromium sysroot anyway. This is an intermediate step until BoringSSL is available in the Fuchsia SDK. Once that's available, it should be "relatively straightfoward" to make http_transport_socket.cc secure its socket using BoringSSL or OpenSSL depending on the platform. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: If33a0d3f11b9000cbc3f52f96cd024ef274a922f Reviewed-on: https://chromium-review.googlesource.com/1022717 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-04-26 17:21:45 -07:00
sources += [ "net/http_transport_socket.cc" ]
fuchsia: Don’t require test certificate setup for disabled TLS tests This is a follow-up to e6f26587e435. Bug: DX-382 Change-Id: I3116ea5dd2eca33961465d62c9200aa8dd1baf5d Reviewed-on: https://chromium-review.googlesource.com/1173339 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-08-13 19:24:49 -04:00
if (crashpad_use_boringssl_for_http_transport_socket) {
[fuchsia] fix crashpad_use_boringssl_for_http_transport_socket path * https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1745355/17/util/BUILD.gn#184 defines "defines" earlier in the target * this only affects Fuchsia in the Fuchsia tree, not the Crashpad tree TESTED=`fx build` in Fuchsia tree Change-Id: I5ac454828f958d6de4e4c6788d7c9a31408dc732 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1796964 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-09-10 14:43:56 -07:00
defines += [ "CRASHPAD_USE_BORINGSSL" ]
fuchsia: Fix build vs. TLS support when in-tree Depend on the BoringSSL target instead of the libs when building in the Fuchsia tree. Bug: crashpad:196 Change-Id: Ib1faa9335eedff1fd9dd072234df2d48612ab423 Reviewed-on: https://chromium-review.googlesource.com/1079434 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-30 15:08:18 -07:00
linux: add deps for boringssl in chromium Change-Id: Icc0acddd7218c85950874555405c8f8b5c3149dd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1869251 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-10-18 07:28:43 -07:00
if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
Add ProcessSnapshotSanitized A ProcessSnapshotSanitized enables filtering possibly sensitive information from a snapshot. WebView has different privacy constraints than Chrome and needs to avoid collecting data in annotations or from stack memory that may contain PII. This CL enables: 1. Filtering annotations by name using a whitelist. 2. Filtering for crashes which reference a particular module. 3. Redacting non-essential information from stack memory. This CL does not provide a client interface to enable sanitization. Bug: crashpad:30 Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254 Reviewed-on: https://chromium-review.googlesource.com/1070472 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-11 09:38:24 -07:00
deps += [ "//third_party/boringssl" ]
fuchsia: Fix build vs. TLS support when in-tree Depend on the BoringSSL target instead of the libs when building in the Fuchsia tree. Bug: crashpad:196 Change-Id: Ib1faa9335eedff1fd9dd072234df2d48612ab423 Reviewed-on: https://chromium-review.googlesource.com/1079434 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-30 15:08:18 -07:00
} else {
libs = [
"crypto",
"ssl",
]
}
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
}
gn, android: Build for Android with GN With a companion mini_chromium change at https://crrev.com/c/841203, it’s possible to configure via “gn args” as follows: android_ndk = "/android/android-ndk-r16" target_cpu = "x86_64" target_os = "android" Note that a standalone toolchain is not required. Bug: crashpad:30, crashpad:79 Change-Id: Ica55bdcb82c730909c05dd9fecb40a74eca78c8a Reviewed-on: https://chromium-review.googlesource.com/841286 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-12-21 17:54:12 -05:00
}
if (crashpad_is_linux || crashpad_is_android) {
android: unset source filters to use linux files Also disable testing reading AT_ENTRY on Android. Bug: crashpad:30 Change-Id: I10353bbbb3ff28721a2c05d69463df5eac4df281 Reviewed-on: https://chromium-review.googlesource.com/980811 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-03-26 17:26:08 -07:00
set_sources_assignment_filter([])
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
sources += [
"linux/address_types.h",
"linux/auxiliary_vector.cc",
"linux/auxiliary_vector.h",
"linux/checked_linux_address_range.h",
"linux/direct_ptrace_connection.cc",
"linux/direct_ptrace_connection.h",
gn, linux: Update build after 9b2ba587f618 Bug: crashpad:30, crashpad:79 Change-Id: Ib50352cfd36d40786b9732e7c4ab50781963369b Reviewed-on: https://chromium-review.googlesource.com/835028 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-12-19 17:13:13 -05:00
"linux/exception_handler_client.cc",
"linux/exception_handler_client.h",
android/linux: add a client interface to control sanitization Sanitization is controlled by a SanitizationInformation struct to be read from the client's memory. The address of this struct is either passed in a ClientInformation when the client requests a crash dump, or as a flag to the handler --sanitization_information. Bug: crashpad:30 Change-Id: I2744f8fb85b4fea7362b2b88faa4bef1da74e36b Reviewed-on: https://chromium-review.googlesource.com/1083143 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-12 08:30:36 -07:00
"linux/exception_handler_protocol.cc",
gn, linux: Update build after 9b2ba587f618 Bug: crashpad:30, crashpad:79 Change-Id: Ib50352cfd36d40786b9732e7c4ab50781963369b Reviewed-on: https://chromium-review.googlesource.com/835028 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-12-19 17:13:13 -05:00
"linux/exception_handler_protocol.h",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"linux/exception_information.h",
"linux/memory_map.cc",
"linux/memory_map.h",
"linux/proc_stat_reader.cc",
"linux/proc_stat_reader.h",
linux: support multi client sockets in ExceptionHandlerServer Multi client socket connections allow multiple clients to request crash dumps from a handler process using a single, shared socket connection. This connection mode does not support using a broker process which requires a dedicated socket connection to ensure handler messages aren't intercepted by the wrong clients. The handler uses SIGCONT to indicate to the crasher when a crash dump is complete (or has failed) and may continue. Bug: crashpad:284 Change-Id: I2031029cd254f17497cbf7e7d8740c289581e8aa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1559306 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-29 14:28:53 -07:00
"linux/proc_task_reader.cc",
"linux/proc_task_reader.h",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"linux/ptrace_broker.cc",
"linux/ptrace_broker.h",
"linux/ptrace_client.cc",
"linux/ptrace_client.h",
"linux/ptrace_connection.h",
"linux/ptracer.cc",
"linux/ptracer.h",
linux: Add ScopedPrSetDumpable Bug: 914246 Change-Id: I529467e92a5cbc2a372f4c12234cfd3af8ddfe0a Reviewed-on: https://chromium-review.googlesource.com/c/1382598 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-18 09:17:52 -08:00
"linux/scoped_pr_set_dumpable.cc",
"linux/scoped_pr_set_dumpable.h",
linux: Move ScopedPrSetPtracer to util/ CrashpadClient will need ScopedPrSetPtracer when launching a handler process in response to a crash. Bug: crashpad:30 Change-Id: I35bc784b948349ca771f9cd65ef1089e626976bb Reviewed-on: https://chromium-review.googlesource.com/927352 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-20 13:07:16 -08:00
"linux/scoped_pr_set_ptracer.cc",
"linux/scoped_pr_set_ptracer.h",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"linux/scoped_ptrace_attach.cc",
"linux/scoped_ptrace_attach.h",
linux: add wrappers for send/recvmsg sendmsg() and recvmsg() are complicated to use. Refactor their usage into functions with a simpler, tested interface and use those instead. This also adds CreateCredentialSocketpair() to create a pair of connected sockets with SO_PASSCRED set. This option should be set before the possibility of any calls to sendmsg() with the socket pair to avoid race conditions in properly setting credentials. Also update the handler to use Strategy::kNoPtrace (which causes the crash dump to fail without breaking the socket connection) if the credentials were invalid, which can happen if SO_PASSCRED was set after the call to sendmsg() or if the sending process does not exist in this namespace. Change-Id: Id09f87125540255687a3c35d5bed7fa01ec07cff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1584639 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-05-02 13:55:08 -07:00
"linux/socket.cc",
"linux/socket.h",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"linux/thread_info.cc",
"linux/thread_info.h",
"linux/traits.h",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_linux.S",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"misc/paths_linux.cc",
linux: fix proc stat reader flakiness ProcStatReader.Threads is flaky because it relies on an internal, imprecise measurement of boot time. The flaky test asserts that a thread started after the main thread should have a start time >= the main thread. The start time is returned in a timeval, with microsecond precision, but the measurement of boot time requires two system calls and the time between those system calls can be approximately a microsecond. An unlucky event such as a change in system time could make this imprecision arbitrarily bad. This patch lets the caller of ProcStatReader.StartTime() inject the boot time, allowing ProcStatReader to guarantee that threads have correctly ordered time, given the same input boot time. Bug: 1016765 Change-Id: I6e4a944a1d58c3916090bab6a4b99573e71a89fc Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1891588 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2019-11-06 10:00:13 -08:00
"misc/time_linux.cc",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"posix/process_info_linux.cc",
"process/process_memory_linux.cc",
"process/process_memory_linux.h",
Add ProcessMemorySanitized The ProcessMemorySanitized implementation only allows reads to a given process if it falls within a given whitelist of memory ranges. This ensures that 'sanitized' snapshots only allow reading memory that was explicitly allowed. Bug: crashpad:263, chromium:973167 Change-Id: I72712d7ea3cabfd49cc91ffbe563cb349e6fcfdb Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1752593 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-08-14 16:13:35 -07:00
"process/process_memory_sanitized.cc",
"process/process_memory_sanitized.h",
fuchsia: Add implemention of ProcessMemory Bug: crashpad:196 Change-Id: I04a29afcbb16b5ef14d6f83d7af1d954f5164ee9 Reviewed-on: https://chromium-review.googlesource.com/868736 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-01-16 14:46:29 -08:00
]
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_win) {
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
sources += [
"file/directory_reader_win.cc",
"file/file_io_win.cc",
"file/filesystem_win.cc",
"misc/clock_win.cc",
"misc/paths_win.cc",
"misc/time_win.cc",
"net/http_transport_win.cc",
Add ProcessMemoryWin and re-factor tests Currently, ProcessMemory is only implemented for Linux and Fuchsia. Implement the interface for Windows as well and re-factor tests to support it, mostly this consists of using a new ScopedGuardedPage class instead of ScopedMmap in the ProcessMemory tests. BUG=crashpad:262 Change-Id: I1b42718972be5ad838d12356d09f764053f09e4f Reviewed-on: https://chromium-review.googlesource.com/c/1278829 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-11-05 13:14:20 -08:00
"process/process_memory_win.cc",
"process/process_memory_win.h",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"synchronization/semaphore_win.cc",
"thread/thread_win.cc",
"win/address_types.h",
"win/checked_win_address_range.h",
"win/command_line.cc",
"win/command_line.h",
Add Windows ARM64 support to Chromium crashpad Bug: chromium:893460 Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435 Reviewed-on: https://chromium-review.googlesource.com/c/1347773 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2018-12-12 12:58:24 -08:00
"win/context_wrappers.h",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"win/critical_section_with_debug_info.cc",
"win/critical_section_with_debug_info.h",
"win/exception_handler_server.cc",
"win/exception_handler_server.h",
"win/get_function.cc",
"win/get_function.h",
"win/get_module_information.cc",
"win/get_module_information.h",
"win/handle.cc",
"win/handle.h",
"win/initial_client_data.cc",
"win/initial_client_data.h",
[Windows] Add checks for DLL loader lock. This CL adds code to check if the current thread holds the DLL loader lock. This code can be used to enforce the requirement that certain parts of crashpad, such as process creation are not done during calls to DllMain which can lead to deadlocks and crashes. Only one check is current enforced, in client process creation, and only in debug builds. Bug: crashpad: 316 Change-Id: I5757a264bbf28ce2ab88a0cd7ac9481e46428c17 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1945993 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org>
2019-12-03 10:20:34 -08:00
"win/loader_lock.cc",
"win/loader_lock.h",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"win/module_version.cc",
"win/module_version.h",
"win/nt_internals.cc",
"win/nt_internals.h",
"win/ntstatus_logging.cc",
"win/ntstatus_logging.h",
"win/process_info.cc",
"win/process_info.h",
"win/process_structs.h",
"win/registration_protocol_win.cc",
"win/registration_protocol_win.h",
"win/safe_terminate_process.h",
"win/scoped_handle.cc",
"win/scoped_handle.h",
"win/scoped_local_alloc.cc",
"win/scoped_local_alloc.h",
"win/scoped_process_suspend.cc",
"win/scoped_process_suspend.h",
"win/scoped_set_event.cc",
"win/scoped_set_event.h",
"win/session_end_watcher.cc",
"win/session_end_watcher.h",
"win/termination_codes.h",
"win/xp_compat.h",
]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
# There's no ml.exe yet in cross builds, so provide broken-but-not-asm
# versions of the functions defined in .asm files.
URL cleanups: switch to HTTPS, fix dead ones, use canonical ones Change-Id: I4b247d7fae1a212350f8ffcf2bf5ba1fa730f5c1 Reviewed-on: https://chromium-review.googlesource.com/780339 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-11-20 16:57:43 -05:00
#
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
# CaptureContext() in capture_context_broken.cc just calls CHECK(false).
# SafeTerminateProcess() in safe_terminate_process.cc just calls regular
# TerminateProcess() without the protection against broken third-party
# patching of TerminateProcess().
URL cleanups: switch to HTTPS, fix dead ones, use canonical ones Change-Id: I4b247d7fae1a212350f8ffcf2bf5ba1fa730f5c1 Reviewed-on: https://chromium-review.googlesource.com/780339 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-11-20 16:57:43 -05:00
#
# TODO(thakis): Use the .asm file in cross builds somehow,
# https://crbug.com/762167.
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
if (host_os == "win") {
Add Windows ARM64 support to Chromium crashpad Bug: chromium:893460 Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435 Reviewed-on: https://chromium-review.googlesource.com/c/1347773 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2018-12-12 12:58:24 -08:00
if (current_cpu != "arm64") {
sources += [
"misc/capture_context_win.asm",
"win/safe_terminate_process.asm",
]
} else {
Add support for capture CPU context on Windows on ARM64 Most Crashpad builds use Microsoft's armasm64.exe macro assembler for .asm source files. When building in Chromium, clang-cl is used as the assembler instead. Since the two assemblers recognize different assembly dialects, the same .asm file can't be used for each. As a workaround, use a prebuilt .obj file when the Microsoft-dialect assembler isn't available. The obj file is generated from the capture_context_win_arm64.asm by armasm64 macro assembler. If this asm file is modified, the obj file needs to be updated. Change-Id: Id5a4a949997a27b04815aeb79b2540d30a52d34c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1632749 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-07-17 16:07:23 +02:00
# Most Crashpad builds use Microsoft's armasm64.exe macro assembler for
# .asm source files. When building in Chromium, clang-cl is used as the
# assembler instead. Since the two assemblers recognize different
# assembly dialects, the same .asm file can't be used for each. As a
# workaround, use a prebuilt .obj file when the Microsoft-dialect
# assembler isn't available.
if (crashpad_is_in_chromium) {
sources += [ "misc/capture_context_win_arm64.obj" ]
} else {
sources += [ "misc/capture_context_win_arm64.asm" ]
}
Add Windows ARM64 support to Chromium crashpad Bug: chromium:893460 Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435 Reviewed-on: https://chromium-review.googlesource.com/c/1347773 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2018-12-12 12:58:24 -08:00
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
} else {
sources += [
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_broken.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"win/safe_terminate_process_broken.cc",
]
}
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_fuchsia) {
Get crashpad_client_test and crashpad_handler_test building Stubs a variety of classes (CrashReportExceptionHandler, ExceptionHandlerServer, HTTPTransport, CrashReportDatabase). Bug: crashpad:196 Change-Id: I4772f90d0d2ad07cc2f3c2ef119e92fde5c7acef Reviewed-on: https://chromium-review.googlesource.com/809940 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-12-06 10:08:11 -08:00
sources += [
fuchsia: Get generate_dump to start attempting process dumps Add pid->handle mapping code to generate_dump. This is enough to get generate_dump to start capturing a dump for an arbitrary system process. It currently CHECK()s in ProcessSnapshotFuchsia on some unimplemented functionality. Bug: crashpad:196 Change-Id: Idfbaa4fbf32af63ad6db5b0b78a7a1991b82728e Reviewed-on: https://chromium-review.googlesource.com/1005804 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-10 14:25:06 -07:00
"fuchsia/koid_utilities.cc",
"fuchsia/koid_utilities.h",
fuchsia: Add implementation of ScopedTaskSuspend This implementation has some limitations as documented in the header, however, threads must be suspended in order to use the register capture debug API so this is somewhat useful for now in the context of generate_dump. Also, refactor some child-object retrieval helpers used in a few places. Bug: crashpad:196 Change-Id: I1fdae5fc3d4b43841e535724eac10c1e58af04c5 Reviewed-on: https://chromium-review.googlesource.com/1007966 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-04-13 09:42:19 -07:00
"fuchsia/scoped_task_suspend.cc",
"fuchsia/scoped_task_suspend.h",
fuchsia: Implement CaptureContext() for x64 Fuchsia enables safe-stack by default in the compiler. Disable it for the test function so that a candidate RSP value can be found by using the value of locals on the stack. (This also reduces the function prolog size sufficiently for the PC comparison to work, otherwise it required 75 bytes for the delta comparison.) Bug: crashpad:196 Change-Id: I2adbcee93c90dbc415309b79e3d16e9c4635f989 Reviewed-on: https://chromium-review.googlesource.com/1000140 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-06 15:13:03 -07:00
"misc/capture_context_fuchsia.S",
Get crashpad_client_test and crashpad_handler_test building Stubs a variety of classes (CrashReportExceptionHandler, ExceptionHandlerServer, HTTPTransport, CrashReportDatabase). Bug: crashpad:196 Change-Id: I4772f90d0d2ad07cc2f3c2ef119e92fde5c7acef Reviewed-on: https://chromium-review.googlesource.com/809940 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-12-06 10:08:11 -08:00
"misc/paths_fuchsia.cc",
fuchsia: Add implemention of ProcessMemory Bug: crashpad:196 Change-Id: I04a29afcbb16b5ef14d6f83d7af1d954f5164ee9 Reviewed-on: https://chromium-review.googlesource.com/868736 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-01-16 14:46:29 -08:00
"process/process_memory_fuchsia.cc",
"process/process_memory_fuchsia.h",
Get crashpad_client_test and crashpad_handler_test building Stubs a variety of classes (CrashReportExceptionHandler, ExceptionHandlerServer, HTTPTransport, CrashReportDatabase). Bug: crashpad:196 Change-Id: I4772f90d0d2ad07cc2f3c2ef119e92fde5c7acef Reviewed-on: https://chromium-review.googlesource.com/809940 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-12-06 10:08:11 -08:00
]
fuchsia: Add runner, get crashpad_test_test building and running - Implement build/run_tests.py to run on Fuchsia device - Implement paths_fuchsia.cc using standard Fuchsia namespace layout - Exclude multiprocess tests, currently unimplemented - Don't use unnecessary O_ flags on Fuchsia in open() call. Bug: crashpad:196, chromium:726124, ZX-797 Change-Id: Ie59dce685b4c3fe54f3e36f357c1101d402ee8b7 Reviewed-on: https://chromium-review.googlesource.com/802180 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-05 10:52:44 -08:00
}
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
public_configs = [ "..:crashpad_config" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
gn: Fix a couple of things after 9465fc72ad90 and 2bb56fafe3bd When I redid the Crashpad GN build a few weeks ago (https://chromium-review.googlesource.com/c/chromium/src/+/751403), I tried to order things according to the GN style guide (https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/style_guide.md). As for conditionals, I tried to stick to doing a set of conditionals after “sources” for just “sources”, and then another one at the bottom for everything else. It turns out that this was a good idea because it’s an error to say “deps += [something]” inside a conditional until you’ve already said “deps = [something_else]” first. (Maybe that’s why I did it.) 9465fc72ad90 regressed this. 2bb56fafe3bd also left behind a couple of straggler paths that were absolute to Chromium’s root but should have been made relative. This also fixes a comment (about something that won’t yet work outside of Chromium anyway, but still…) Bug: crashpad:79 Change-Id: I8a6f84bfad368cbcdae4fbff11f1d00e2af14b93 Reviewed-on: https://chromium-review.googlesource.com/798172 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-11-29 18:04:25 -05:00
# Include generated files starting with "util".
fuchsia: Fix include_dirs for host Mac build Change-Id: I157fe2ab95d0b152ef5cc09cd0b6e56649c9f727 Reviewed-on: https://chromium-review.googlesource.com/c/1277777 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-10-11 15:56:22 -07:00
if (crashpad_is_in_fuchsia) {
include_dirs = [ "$root_gen_dir/third_party/crashpad" ]
} else {
include_dirs = [ "$root_gen_dir/third_party/crashpad/crashpad" ]
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
[log minidump] add option to log minidump in handler_main - Add option to log minidump in handler_main, also add option to disable to dump minidump and generate report. - Implement log minidump in CrashReportExceptionHandler. Bug: crashpad:308 Change-Id: I8d2f7e118912011a8416f1ec36c9ee9d561d06e6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1995825 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2020-01-28 12:02:55 -08:00
public_deps = [
"../compat",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"../third_party/zlib",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
]
[log minidump] add option to log minidump in handler_main - Add option to log minidump in handler_main, also add option to disable to dump minidump and generate report. - Implement log minidump in CrashReportExceptionHandler. Bug: crashpad:308 Change-Id: I8d2f7e118912011a8416f1ec36c9ee9d561d06e6 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1995825 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2020-01-28 12:02:55 -08:00
deps += [ "../third_party/mini_chromium:base" ]
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_mac) {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
libs = [
"bsm",
"CoreFoundation.framework",
"Foundation.framework",
"IOKit.framework",
]
Add missing BUILD.gn for third_party/apple_cf apple_cf is just a header, but we’ve got a BUILD.gn for third_party/cpp-httplib, which is also just a header. Change-Id: Ib42c25657b5964678d14682a0a802ebef0e4cb2f Reviewed-on: https://chromium-review.googlesource.com/c/1489182 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-02-26 11:13:20 -05:00
deps += [
Prepare crashpad mig stuff for -Wunreachable-code in chromium_code. Bug: chromium:346399 Change-Id: I5d93a2f6781dd4dd3483009d9c470050d490be3c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2116252 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
2020-03-23 14:59:21 -04:00
":mig_output",
Add missing BUILD.gn for third_party/apple_cf apple_cf is just a header, but we’ve got a BUILD.gn for third_party/cpp-httplib, which is also just a header. Change-Id: Ib42c25657b5964678d14682a0a802ebef0e4cb2f Reviewed-on: https://chromium-review.googlesource.com/c/1489182 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2019-02-26 11:13:20 -05:00
"../third_party/apple_cf:apple_cf",
]
gn, mac: Get basic generation working A couple targets compile, but not linking yet. Requires https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/812410 Bug: crashpad:79 Change-Id: Ifc472628ec5233fc88c746e74a1f7b3ce0637f91 Reviewed-on: https://chromium-review.googlesource.com/811884 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-06 15:36:31 -08:00
include_dirs += [ "$root_build_dir/gen" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_win) {
gn win: Get main test binaries building - default to subsystem:console - don't build posix/timezone.* - add some missing libs This gets all the main binaries building and running. Most configs pass, but there's some offsets that seem different in some builds; need to investigate more. Additionally, the binaries used by end_to_end_test.py aren't yet built, so that script fails. Includes mini_chromium roll to 46eeaf9: 46eea49 gn win: Add debug info and pdb to cc/cxx 902a29f gn win: Various fixes towards making GN build work Bug: crashpad:79 Change-Id: Ie56a469b84bed7b0330172cec9f1a8aeb95f702e Reviewed-on: https://chromium-review.googlesource.com/902403 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-06 10:57:23 -08:00
libs = [
"user32.lib",
win: use version.lib instead of mincore.lib Also enable wd4702: unreachable code for zlib and gtest. Change-Id: Ie1603b16e96f29b6ac82a1122c5ab5a8942eef24 Reviewed-on: https://chromium-review.googlesource.com/955895 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-03-09 13:20:09 -08:00
# TODO(jperaza): version.lib is needed for Windows 7 compatibility.
# mincore.lib may be linked against instead when targeting Windows 8+.
"version.lib",
gn win: Get main test binaries building - default to subsystem:console - don't build posix/timezone.* - add some missing libs This gets all the main binaries building and running. Most configs pass, but there's some offsets that seem different in some builds; need to investigate more. Additionally, the binaries used by end_to_end_test.py aren't yet built, so that script fails. Includes mini_chromium roll to 46eeaf9: 46eea49 gn win: Add debug info and pdb to cc/cxx 902a29f gn win: Various fixes towards making GN build work Bug: crashpad:79 Change-Id: Ie56a469b84bed7b0330172cec9f1a8aeb95f702e Reviewed-on: https://chromium-review.googlesource.com/902403 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-06 10:57:23 -08:00
"winhttp.lib",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
]
win gn: reintroduce flags to disable warnings These flags were moved to mini_chromium's build/BUILD.gn, but that configuration is not present when building in chromium. Change-Id: I0d03c7461869882cf2ee7544ecd3d100eb189160 Reviewed-on: https://chromium-review.googlesource.com/940436 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-27 15:29:38 -08:00
cflags = [ "/wd4201" ] # nonstandard extension used: nameless struct/union.
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
if (current_cpu == "x86") {
asmflags = [ "/safeseh" ]
}
}
Migrate from ScopedZxHandle to libzx containers. Bug: chromium:852541 Change-Id: Ie05c70f249e6f843183a02ec61fd09f6a0607598 Reviewed-on: https://chromium-review.googlesource.com/1148923 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org>
2018-07-30 15:50:17 -07:00
if (crashpad_is_fuchsia) {
[fuchsia] rename gn group to fuchsia now that we import fuchsia-sysinfo and fdio, this isn't really just zx anymore Change-Id: Ic42359ce3d230e214ebdbbefb880ccb021434a0f Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1555533 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Francois Rousseau <frousseau@google.com>
2019-04-05 15:45:15 -07:00
public_deps += [ "../third_party/fuchsia" ]
Migrate from ScopedZxHandle to libzx containers. Bug: chromium:852541 Change-Id: Ie05c70f249e6f843183a02ec61fd09f6a0607598 Reviewed-on: https://chromium-review.googlesource.com/1148923 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org>
2018-07-30 15:50:17 -07:00
}
linux: add wrappers for send/recvmsg sendmsg() and recvmsg() are complicated to use. Refactor their usage into functions with a simpler, tested interface and use those instead. This also adds CreateCredentialSocketpair() to create a pair of connected sockets with SO_PASSCRED set. This option should be set before the possibility of any calls to sendmsg() with the socket pair to avoid race conditions in properly setting credentials. Also update the handler to use Strategy::kNoPtrace (which causes the crash dump to fail without breaking the socket connection) if the credentials were invalid, which can happen if SO_PASSCRED was set after the call to sendmsg() or if the sending process does not exist in this namespace. Change-Id: Id09f87125540255687a3c35d5bed7fa01ec07cff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1584639 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-05-02 13:55:08 -07:00
if (crashpad_is_android || crashpad_is_linux) {
deps += [ "../third_party/lss" ]
}
[UBSan] Temporarily disable UBSan for gtest and file These should be the remaining instances of UB errors we see. Bug: fuchsia:46805 Change-Id: Id8285386fd6cb52518f6076ddb79ac60025f9f87 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2067754 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2020-02-21 20:40:08 -08:00
configs += [ "..:disable_ubsan" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
if (!crashpad_is_android) {
crashpad_executable("http_transport_test_server") {
testonly = true
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
sources = [ "net/http_transport_test_server.cc" ]
Implementation in C++ of HTTPTransport test server - Pulls in cpp-httplib for test-only usage in third_party/. - Replaces http_transport_test_server.py with .cc server. - Remove unnecessary Go toolchain pull. This was planned to be used for the test server, but the toolchain integration was too messy when covering all target platforms/configs. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: I5990781473dcadfcc036fbe711c02928638ff851 Reviewed-on: https://chromium-review.googlesource.com/1013293 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-18 12:49:04 -07:00
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
deps = [
":util",
"../third_party/cpp-httplib",
"../third_party/mini_chromium:base",
"../third_party/zlib",
"../tools:tool_support",
fuchsia: Various build fixes for building in Fuchsia tree - Use "deprecated_system_image" (merging from downstream) - Add package for crashpad_handler - Depend on launchpad target instead of a lib when in tree, as launchpad is no longer in the sysroot. - Don't try to remove the -Wexit_time_destructors unless building standalone, when it's added by mini_chromiums BUILDCONFIG.gn Bug: crashpad:196 Change-Id: I08e0faaa989346b078a41896eb4ace69e7b1bcdc Reviewed-on: https://chromium-review.googlesource.com/1026514 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-24 13:02:29 -07:00
]
Implementation in C++ of HTTPTransport test server - Pulls in cpp-httplib for test-only usage in third_party/. - Replaces http_transport_test_server.py with .cc server. - Remove unnecessary Go toolchain pull. This was planned to be used for the test server, but the toolchain integration was too messy when covering all target platforms/configs. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: I5990781473dcadfcc036fbe711c02928638ff851 Reviewed-on: https://chromium-review.googlesource.com/1013293 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-18 12:49:04 -07:00
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
if (crashpad_is_standalone) {
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
remove_configs = [ "//third_party/mini_chromium/mini_chromium/build:Wexit_time_destructors" ]
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
}
if (crashpad_is_win) {
libs = [ "ws2_32.lib" ]
}
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
fuchsia: Don’t require test certificate setup for disabled TLS tests This is a follow-up to e6f26587e435. Bug: DX-382 Change-Id: I3116ea5dd2eca33961465d62c9200aa8dd1baf5d Reviewed-on: https://chromium-review.googlesource.com/1173339 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-08-13 19:24:49 -04:00
if (crashpad_use_boringssl_for_http_transport_socket) {
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
defines = [ "CRASHPAD_USE_BORINGSSL" ]
fuchsia: Fix build vs. TLS support when in-tree Depend on the BoringSSL target instead of the libs when building in the Fuchsia tree. Bug: crashpad:196 Change-Id: Ib1faa9335eedff1fd9dd072234df2d48612ab423 Reviewed-on: https://chromium-review.googlesource.com/1079434 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-30 15:08:18 -07:00
linux: add deps for boringssl in chromium Change-Id: Icc0acddd7218c85950874555405c8f8b5c3149dd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1869251 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-10-18 07:28:43 -07:00
if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
Add ProcessSnapshotSanitized A ProcessSnapshotSanitized enables filtering possibly sensitive information from a snapshot. WebView has different privacy constraints than Chrome and needs to avoid collecting data in annotations or from stack memory that may contain PII. This CL enables: 1. Filtering annotations by name using a whitelist. 2. Filtering for crashes which reference a particular module. 3. Redacting non-essential information from stack memory. This CL does not provide a client interface to enable sanitization. Bug: crashpad:30 Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254 Reviewed-on: https://chromium-review.googlesource.com/1070472 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-11 09:38:24 -07:00
deps += [ "//third_party/boringssl" ]
fuchsia: Fix build vs. TLS support when in-tree Depend on the BoringSSL target instead of the libs when building in the Fuchsia tree. Bug: crashpad:196 Change-Id: Ib1faa9335eedff1fd9dd072234df2d48612ab423 Reviewed-on: https://chromium-review.googlesource.com/1079434 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-30 15:08:18 -07:00
} else {
libs = [
"crypto",
"ssl",
]
}
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
}
Implementation in C++ of HTTPTransport test server - Pulls in cpp-httplib for test-only usage in third_party/. - Replaces http_transport_test_server.py with .cc server. - Remove unnecessary Go toolchain pull. This was planned to be used for the test server, but the toolchain integration was too messy when covering all target platforms/configs. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: I5990781473dcadfcc036fbe711c02928638ff851 Reviewed-on: https://chromium-review.googlesource.com/1013293 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-18 12:49:04 -07:00
}
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
source_set("util_test") {
testonly = true
sources = [
"file/delimited_file_reader_test.cc",
"file/directory_reader_test.cc",
"file/file_io_test.cc",
"file/file_reader_test.cc",
"file/filesystem_test.cc",
"file/string_file_test.cc",
Remove base's arraysize from Crashpad. BUG=837308 R=mark@chromium.org Change-Id: Ibecbfc7bc2d61ee54bc1114e4b20978adbc77db2 Reviewed-on: https://chromium-review.googlesource.com/c/1393921 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org>
2019-01-03 13:36:02 -05:00
"misc/arraysize_test.cc",
fuchsia: Implement CaptureContext() for x64 Fuchsia enables safe-stack by default in the compiler. Disable it for the test function so that a candidate RSP value can be found by using the value of locals on the stack. (This also reduces the function prolog size sufficiently for the PC comparison to work, otherwise it required 75 bytes for the delta comparison.) Bug: crashpad:196 Change-Id: I2adbcee93c90dbc415309b79e3d16e9c4635f989 Reviewed-on: https://chromium-review.googlesource.com/1000140 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-06 15:13:03 -07:00
"misc/capture_context_test.cc",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_test_util.h",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/clock_test.cc",
"misc/from_pointer_cast_test.cc",
"misc/initialization_state_dcheck_test.cc",
"misc/initialization_state_test.cc",
"misc/paths_test.cc",
"misc/random_string_test.cc",
Add ProcessSnapshotSanitized A ProcessSnapshotSanitized enables filtering possibly sensitive information from a snapshot. WebView has different privacy constraints than Chrome and needs to avoid collecting data in annotations or from stack memory that may contain PII. This CL enables: 1. Filtering annotations by name using a whitelist. 2. Filtering for crashes which reference a particular module. 3. Redacting non-essential information from stack memory. This CL does not provide a client interface to enable sanitization. Bug: crashpad:30 Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254 Reviewed-on: https://chromium-review.googlesource.com/1070472 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-11 09:38:24 -07:00
"misc/range_set_test.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"misc/reinterpret_bytes_test.cc",
"misc/scoped_forbid_return_test.cc",
"misc/time_test.cc",
"misc/uuid_test.cc",
"net/http_body_gzip_test.cc",
"net/http_body_test.cc",
"net/http_body_test_util.cc",
"net/http_body_test_util.h",
"net/http_multipart_builder_test.cc",
"net/url_test.cc",
"numeric/checked_address_range_test.cc",
"numeric/checked_range_test.cc",
"numeric/in_range_cast_test.cc",
"numeric/int128_test.cc",
Make TaskMemory a child class of ProcessMemory Currently TaskMemory re-implements a number of Read* routines that are implemented in a platform-independent way in ProcessMemory with access to a single platform-specific ReadUpTo method. Implement the ReadUpTo method for TaskMemory and subclass it from ProcessMemory to inherit the remaining methods. The ProcessMemoryTests didn't work on macOS because MultiprocessExec can not access the child process' task port without root privileges or the task_for_pid entitlement. Create an adaptor class for those tests to use MachMultiprocess so that the child process sends its task port to the parent. Bug: crashpad:263 Change-Id: Id8e1788a74fe957f05703a5eb569ca3bf9870369 Reviewed-on: https://chromium-review.googlesource.com/c/1387265 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-20 11:12:51 -08:00
"process/process_memory_range_test.cc",
"process/process_memory_test.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"stdlib/aligned_allocator_test.cc",
"stdlib/map_insert_test.cc",
"stdlib/string_number_conversion_test.cc",
"stdlib/strlcpy_test.cc",
"stdlib/strnlen_test.cc",
"stdlib/thread_safe_vector_test.cc",
[log minidump] Base94OutputStream implementation Add Base94 encoding/decoding implementation and tests. Bug: crashpad:308 Change-Id: If3f25efcb277eacd5d8cbe1d66f22919872c7d64 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1796682 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-06 10:54:44 -08:00
"stream/base94_output_stream_test.cc",
[log minidump] add tool to encode/decode minidump log. - This tool could compress/encode or decode/decompress the minidump log file, will be used by script to symbolize the crash. - Added FileOutputStream and FileEncoder. Bug: crashpad:308 Change-Id: I15c3e4908882a09983ec81a90e38249967c29fc4 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1968059 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-18 11:33:39 -08:00
"stream/file_encoder_test.cc",
[log minidump] LogOutputStream implementation Emit the received data to Android logcat in Android, and noop for other platforms. Bug: crashpad:308 Change-Id: I6e46e2fa8bd61f93f614ad0bfb6441a79139b04b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1958711 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-12-12 13:15:05 -08:00
"stream/log_output_stream_test.cc",
[Log minidump] OutputStream interface and zlib implementation This is the 1st patch for logging minidump in Android. it adds OutputStream interface and zlib implementation for output pipline. Bug: crashpad:308 Change-Id: I4738b8f223886049e6e259b9b25c00e5120156e5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1745355 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-09-05 17:53:01 -07:00
"stream/test_output_stream.cc",
"stream/test_output_stream.h",
"stream/zlib_output_stream_test.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"string/split_string_test.cc",
"synchronization/semaphore_test.cc",
"thread/thread_log_messages_test.cc",
"thread/thread_test.cc",
"thread/worker_thread_test.cc",
]
Implementation of HTTPTransport via raw socket Partial implementation: Currently only handles http (i.e. no TLS), only POST, and only certain response types (only when Content-Length is specified, and not chunked). Used for Linux and Fuchsia lacking anything better (that's shippable). Removes libcurl HTTPTransport, since it isn't available in the Chromium sysroot anyway. This is an intermediate step until BoringSSL is available in the Fuchsia SDK. Once that's available, it should be "relatively straightfoward" to make http_transport_socket.cc secure its socket using BoringSSL or OpenSSL depending on the platform. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: If33a0d3f11b9000cbc3f52f96cd024ef274a922f Reviewed-on: https://chromium-review.googlesource.com/1022717 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-04-26 17:21:45 -07:00
if (!crashpad_is_android) {
# Android requires an HTTPTransport implementation.
fuchsia: Get crashpad_util_test building Links, but various tests fail. Also adds support to run_tests.py to run a single binary, likely only useful on Fuchsia. Bug: crashpad:196 Change-Id: Ie82ef26ec214ff4262194e877469953aa8fb367e Reviewed-on: https://chromium-review.googlesource.com/809467 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-05 15:16:08 -08:00
sources += [ "net/http_transport_test.cc" ]
}
Prepare for removal of is_posix from the Fuchsia build This also rolls crashpad/third_party/mini_chromium/mini_chromium/ d42eb4101..6e0fdb2e4 (2 commits) https://chromium.googlesource.com/chromium/mini_chromium/+log/d42eb4101236..6e0fdb2e4966 $ git log d42eb4101..6e0fdb2e4 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 scottmg@chromium.org Repair Linux-with-sysroot build after clang update 2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Bug: chromium:812974 Change-Id: I3d8efc3124c97981eda63f104a7adfb670babab7 Reviewed-on: https://chromium-review.googlesource.com/988231 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-04-04 15:12:50 -07:00
if (crashpad_is_posix || crashpad_is_fuchsia) {
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (!crashpad_is_fuchsia) {
fuchsia: Get crashpad_util_test building Links, but various tests fail. Also adds support to run_tests.py to run a single binary, likely only useful on Fuchsia. Bug: crashpad:196 Change-Id: Ie82ef26ec214ff4262194e877469953aa8fb367e Reviewed-on: https://chromium-review.googlesource.com/809467 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-05 15:16:08 -08:00
sources += [
"posix/process_info_test.cc",
"posix/signals_test.cc",
"posix/symbolic_constants_posix_test.cc",
]
}
sources += [ "posix/scoped_mmap_test.cc" ]
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_mac) {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
sources += [
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"mac/launchd_test.mm",
"mac/mac_util_test.mm",
"mac/service_management_test.mm",
"mac/xattr_test.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
"mach/child_port_handshake_test.cc",
"mach/child_port_server_test.cc",
"mach/composite_mach_message_server_test.cc",
"mach/exc_client_variants_test.cc",
"mach/exc_server_variants_test.cc",
"mach/exception_behaviors_test.cc",
"mach/exception_ports_test.cc",
"mach/exception_types_test.cc",
"mach/mach_extensions_test.cc",
"mach/mach_message_server_test.cc",
"mach/mach_message_test.cc",
"mach/notify_server_test.cc",
"mach/scoped_task_suspend_test.cc",
"mach/symbolic_constants_mach_test.cc",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_test_util_mac.cc",
Move and rename TaskMemory to ProcessMemoryMac Bug: crashpad:263 Change-Id: I5efa4fe26f09c8b8a8db6dbcedc416724404b894 Reviewed-on: https://chromium-review.googlesource.com/c/1387884 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-20 13:12:55 -08:00
"process/process_memory_mac_test.cc",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
]
}
gn, android: Build for Android with GN With a companion mini_chromium change at https://crrev.com/c/841203, it’s possible to configure via “gn args” as follows: android_ndk = "/android/android-ndk-r16" target_cpu = "x86_64" target_os = "android" Note that a standalone toolchain is not required. Bug: crashpad:30, crashpad:79 Change-Id: Ica55bdcb82c730909c05dd9fecb40a74eca78c8a Reviewed-on: https://chromium-review.googlesource.com/841286 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-12-21 17:54:12 -05:00
if (crashpad_is_linux || crashpad_is_android) {
android: unset source filters to use linux files Also disable testing reading AT_ENTRY on Android. Bug: crashpad:30 Change-Id: I10353bbbb3ff28721a2c05d69463df5eac4df281 Reviewed-on: https://chromium-review.googlesource.com/980811 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-03-26 17:26:08 -07:00
set_sources_assignment_filter([])
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
sources += [
"linux/auxiliary_vector_test.cc",
"linux/memory_map_test.cc",
"linux/proc_stat_reader_test.cc",
linux: support multi client sockets in ExceptionHandlerServer Multi client socket connections allow multiple clients to request crash dumps from a handler process using a single, shared socket connection. This connection mode does not support using a broker process which requires a dedicated socket connection to ensure handler messages aren't intercepted by the wrong clients. The handler uses SIGCONT to indicate to the crasher when a crash dump is complete (or has failed) and may continue. Bug: crashpad:284 Change-Id: I2031029cd254f17497cbf7e7d8740c289581e8aa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1559306 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-29 14:28:53 -07:00
"linux/proc_task_reader_test.cc",
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
"linux/ptrace_broker_test.cc",
"linux/ptracer_test.cc",
"linux/scoped_ptrace_attach_test.cc",
linux: add wrappers for send/recvmsg sendmsg() and recvmsg() are complicated to use. Refactor their usage into functions with a simpler, tested interface and use those instead. This also adds CreateCredentialSocketpair() to create a pair of connected sockets with SO_PASSCRED set. This option should be set before the possibility of any calls to sendmsg() with the socket pair to avoid race conditions in properly setting credentials. Also update the handler to use Strategy::kNoPtrace (which causes the crash dump to fail without breaking the socket connection) if the credentials were invalid, which can happen if SO_PASSCRED was set after the call to sendmsg() or if the sending process does not exist in this namespace. Change-Id: Id09f87125540255687a3c35d5bed7fa01ec07cff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1584639 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-05-02 13:55:08 -07:00
"linux/socket_test.cc",
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_test_util_linux.cc",
Add ProcessMemorySanitized The ProcessMemorySanitized implementation only allows reads to a given process if it falls within a given whitelist of memory ranges. This ensures that 'sanitized' snapshots only allow reading memory that was explicitly allowed. Bug: crashpad:263, chromium:973167 Change-Id: I72712d7ea3cabfd49cc91ffbe563cb349e6fcfdb Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1752593 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2019-08-14 16:13:35 -07:00
"process/process_memory_sanitized_test.cc",
fuchsia: Add implemention of ProcessMemory Bug: crashpad:196 Change-Id: I04a29afcbb16b5ef14d6f83d7af1d954f5164ee9 Reviewed-on: https://chromium-review.googlesource.com/868736 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-01-16 14:46:29 -08:00
]
}
gn, linux: Build for Linux with GN This is sufficient for a native Linux build using GN. Android is not yet supported. mini_chromium side: https://crrev.com/c/833407 This also updates mini_chromium to 404f6dbf9928. c913ef97a236 gn, linux: Build for Linux with GN 404f6dbf9928 gn: Don’t use .rsp files; rationalize descriptions and output dirs Bug: crashpad:79 Change-Id: I4f3b72fd02884d77812e520fb95231b35815677d Reviewed-on: https://chromium-review.googlesource.com/833408 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-12-19 14:21:14 -05:00
fuchsia: Implement CaptureContext() for x64 Fuchsia enables safe-stack by default in the compiler. Disable it for the test function so that a candidate RSP value can be found by using the value of locals on the stack. (This also reduces the function prolog size sufficiently for the PC comparison to work, otherwise it required 75 bytes for the delta comparison.) Bug: crashpad:196 Change-Id: I2adbcee93c90dbc415309b79e3d16e9c4635f989 Reviewed-on: https://chromium-review.googlesource.com/1000140 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-06 15:13:03 -07:00
if (crashpad_is_fuchsia) {
sources += [ "misc/capture_context_test_util_fuchsia.cc" ]
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_win) {
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
sources += [
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
"misc/capture_context_test_util_win.cc",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"win/command_line_test.cc",
"win/critical_section_with_debug_info_test.cc",
"win/exception_handler_server_test.cc",
"win/get_function_test.cc",
"win/handle_test.cc",
"win/initial_client_data_test.cc",
[Windows] Add checks for DLL loader lock. This CL adds code to check if the current thread holds the DLL loader lock. This code can be used to enforce the requirement that certain parts of crashpad, such as process creation are not done during calls to DllMain which can lead to deadlocks and crashes. Only one check is current enforced, in client process creation, and only in debug builds. Bug: crashpad: 316 Change-Id: I5757a264bbf28ce2ab88a0cd7ac9481e46428c17 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1945993 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org>
2019-12-03 10:20:34 -08:00
"win/loader_lock_test.cc",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"win/process_info_test.cc",
"win/registration_protocol_win_test.cc",
"win/safe_terminate_process_test.cc",
"win/scoped_process_suspend_test.cc",
"win/session_end_watcher_test.cc",
]
win: disable string_number_conversion_test for asan/dll Upstreams: https://chromium-review.googlesource.com/c/chromium/src/+/1113664 Change-Id: I8c3000eebf2be54e8d693bf08a6e92b68c1d5d72 Reviewed-on: https://chromium-review.googlesource.com/1195567 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-08-29 09:33:25 -07:00
win: move string_number_conversion_test asan/dll disabling into the win clause This fixes the upstreaming of https://chromium-review.googlesource.com/c/chromium/src/+/1113664 Bug: chromium:856174 Change-Id: I88cf6aeecef60e4eaf5c14dc9a66f0409255ccac Reviewed-on: https://chromium-review.googlesource.com/1245481 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-09-26 17:54:38 +02:00
if (crashpad_is_in_chromium && is_asan && is_component_build) {
win: disable string_number_conversion_test for asan/dll Upstreams: https://chromium-review.googlesource.com/c/chromium/src/+/1113664 Change-Id: I8c3000eebf2be54e8d693bf08a6e92b68c1d5d72 Reviewed-on: https://chromium-review.googlesource.com/1195567 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-08-29 09:33:25 -07:00
# TODO(crbug.com/856174): Re-enable these once Windows ASan is fixed.
sources -= [ "stdlib/string_number_conversion_test.cc" ]
}
}
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
data = [ "net/testdata/" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
deps = [
":util",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"../client",
"../compat",
"../test",
gn: Refactor build files to avoid build/secondary In doing standalone bringup of Crashpad targeting Fuchsia, it seemed tidy to keep the same literal paths to the dependencies that Chromium needed and add stubs/forwarding to build/secondary in the Crashpad tree as required to make those work. However, when trying to build Crashpad in the Fuchsia tree itself, that would require adding forwarding files to the Fuchsia tree to match the Chromium directory structure, which would be awkward. Instead, have explicit dependencies in the Crashpad tree that select the locations for various dependencies. Bug: crashpad:79, crashpad:196 Change-Id: Ib506839f9c97d8ef823663cdc733cbdcfa126139 Reviewed-on: https://chromium-review.googlesource.com/826025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-18 14:35:55 -08:00
"../third_party/gtest:gmock",
"../third_party/gtest:gtest",
"../third_party/mini_chromium:base",
Rework GN files to start to support building standalone, and also in Chromium - Adds a .gn and a build/BUILDCONFIG.gn that uses mini_chromium's build/BUILD.gn. - Adds some stub BUILD.gn files in locations where Chromium expects them (in //build, //testing, //third_party) containing empty targets/configs. These are no-ops in standalone builds, but add functionality when building in Chromium. This is in preference to having a global bool that conditionally does Chromium-y things in the Crashpad build files. These stub files are all contained in a secondary source root in build/chromium_compatibility, referred to by //.gn. - Adds //base/BUILD.gn which forwards to mini_chromium/base. This is only used when building standalone so that both Chromium and Crashpad can refer to it as "//base". - Changes references to other Crashpad targets to be relatively specified so that they work when the root of the project is //, and also when it's //third_party/crashpad/crashpad as it is in Chromium. - Moves any error-causing Mac/Win-specific files into explicit if (is_mac) or if (is_win) blocks as part of removing the dependency on set_sources_assignment_filter(). As yet unresolved: - CRASHPAD_IN_CHROMIUM needs to be removed when standalone; to be tackled in a follow up. - Not sure what to do with zlib yet, the build file currently assumes "in Chromium" too, and similarly having Crashpad //third_party/zlib:zlib pointing at itself doesn't work. Bug: crashpad:79 Change-Id: I6a7dda214e4b3b14a60c1ed285267ab97432a1a8 Reviewed-on: https://chromium-review.googlesource.com/777410 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-28 10:31:13 -08:00
"../third_party/zlib",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
]
linux: support multi client sockets in ExceptionHandlerServer Multi client socket connections allow multiple clients to request crash dumps from a handler process using a single, shared socket connection. This connection mode does not support using a broker process which requires a dedicated socket connection to ensure handler messages aren't intercepted by the wrong clients. The handler uses SIGCONT to indicate to the crasher when a crash dump is complete (or has failed) and may continue. Bug: crashpad:284 Change-Id: I2031029cd254f17497cbf7e7d8740c289581e8aa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1559306 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-29 14:28:53 -07:00
if (crashpad_is_android || crashpad_is_linux) {
deps += [ "../third_party/lss" ]
}
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
if (!crashpad_is_android) {
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
data_deps = [ ":http_transport_test_server" ]
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
fuchsia: Don’t require test certificate setup for disabled TLS tests This is a follow-up to e6f26587e435. Bug: DX-382 Change-Id: I3116ea5dd2eca33961465d62c9200aa8dd1baf5d Reviewed-on: https://chromium-review.googlesource.com/1173339 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-08-13 19:24:49 -04:00
if (crashpad_use_boringssl_for_http_transport_socket) {
fuchsia: Implement TLS support in HTTPTransportSocket With use_boringssl_for_http_transport_socket set, this also works on Linux, however the bots fail during run lacking libcrypto.so.1.1. So, not enabled on Linux until that's figured out. (Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands and I'll do a full roll of cpp-httplib then.) Bug: crashpad:30, crashpad:196 Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff Reviewed-on: https://chromium-review.googlesource.com/1075726 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-05-29 12:51:41 -07:00
defines = [ "CRASHPAD_USE_BORINGSSL" ]
}
Update cpp-httplib to 37130cd Also exclude http_transport_test_server from Android where it doesn't build. Change-Id: I51cc3f50e4fb9db982d91b2924b8ea87d86926d4 Reviewed-on: https://chromium-review.googlesource.com/1054160 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-05-10 22:58:14 -07:00
}
Implementation in C++ of HTTPTransport test server - Pulls in cpp-httplib for test-only usage in third_party/. - Replaces http_transport_test_server.py with .cc server. - Remove unnecessary Go toolchain pull. This was planned to be used for the test server, but the toolchain integration was too messy when covering all target platforms/configs. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: I5990781473dcadfcc036fbe711c02928638ff851 Reviewed-on: https://chromium-review.googlesource.com/1013293 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-18 12:49:04 -07:00
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_mac) {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
libs = [ "Foundation.framework" ]
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_win) {
gn win: Get main test binaries building - default to subsystem:console - don't build posix/timezone.* - add some missing libs This gets all the main binaries building and running. Most configs pass, but there's some offsets that seem different in some builds; need to investigate more. Additionally, the binaries used by end_to_end_test.py aren't yet built, so that script fails. Includes mini_chromium roll to 46eeaf9: 46eea49 gn win: Add debug info and pdb to cc/cxx 902a29f gn win: Various fixes towards making GN build work Bug: crashpad:79 Change-Id: Ie56a469b84bed7b0330172cec9f1a8aeb95f702e Reviewed-on: https://chromium-review.googlesource.com/902403 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-06 10:57:23 -08:00
libs = [
"rpcrt4.lib",
"dbghelp.lib",
]
Implementation in C++ of HTTPTransport test server - Pulls in cpp-httplib for test-only usage in third_party/. - Replaces http_transport_test_server.py with .cc server. - Remove unnecessary Go toolchain pull. This was planned to be used for the test server, but the toolchain integration was too messy when covering all target platforms/configs. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: I5990781473dcadfcc036fbe711c02928638ff851 Reviewed-on: https://chromium-review.googlesource.com/1013293 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-04-18 12:49:04 -07:00
data_deps += [
[Windows] Add checks for DLL loader lock. This CL adds code to check if the current thread holds the DLL loader lock. This code can be used to enforce the requirement that certain parts of crashpad, such as process creation are not done during calls to DllMain which can lead to deadlocks and crashes. Only one check is current enforced, in client process creation, and only in debug builds. Bug: crashpad: 316 Change-Id: I5757a264bbf28ce2ab88a0cd7ac9481e46428c17 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1945993 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org>
2019-12-03 10:20:34 -08:00
":crashpad_util_test_loader_lock_test",
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
":crashpad_util_test_process_info_test_child",
":crashpad_util_test_safe_terminate_process_test_child",
]
}
}
gn: Avoid depending on BUILDCONFIG.gn globals Goes with https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/834648. Includes mini_chromium DEPS roll to pull in https://chromium.googlesource.com/chromium/mini_chromium/+/edfe51ce818e55eae73ab3f144a360e855533888 Bug: crashpad:79, crashpad:196 Change-Id: Ib45cc738aecf9ae727f8faeff81f3b71e2dc9de8 Reviewed-on: https://chromium-review.googlesource.com/834543 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 15:31:04 -08:00
if (crashpad_is_win) {
gn: add templates for executables and loadable_modules When building in chromium, executables and loadable_modules should depend on: //build/config:exe_and_shlib_deps which, among other things, may be needed to introduce a dependency on a custom libc++. Bug: crashpad:30 Change-Id: Ic46a3cf5b46bdac09cca22950f9236e0776ba44a Reviewed-on: https://chromium-review.googlesource.com/974713 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-03-21 19:18:07 -07:00
crashpad_executable("crashpad_util_test_process_info_test_child") {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
testonly = true
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
sources = [ "win/process_info_test_child.cc" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
gn: add templates for executables and loadable_modules When building in chromium, executables and loadable_modules should depend on: //build/config:exe_and_shlib_deps which, among other things, may be needed to introduce a dependency on a custom libc++. Bug: crashpad:30 Change-Id: Ic46a3cf5b46bdac09cca22950f9236e0776ba44a Reviewed-on: https://chromium-review.googlesource.com/974713 Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-03-21 19:18:07 -07:00
crashpad_executable("crashpad_util_test_safe_terminate_process_test_child") {
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
testonly = true
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
sources = [ "win/safe_terminate_process_test_child.cc" ]
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
[Windows] Add checks for DLL loader lock. This CL adds code to check if the current thread holds the DLL loader lock. This code can be used to enforce the requirement that certain parts of crashpad, such as process creation are not done during calls to DllMain which can lead to deadlocks and crashes. Only one check is current enforced, in client process creation, and only in debug builds. Bug: crashpad: 316 Change-Id: I5757a264bbf28ce2ab88a0cd7ac9481e46428c17 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1945993 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org>
2019-12-03 10:20:34 -08:00
crashpad_loadable_module("crashpad_util_test_loader_lock_test") {
testonly = true
Reformat all gn files Port of chromium-side https://chromium-review.googlesource.com/c/chromium/src/+/1997899 Bug: chromium:1041419 Change-Id: Ic7afefa0dea024da37fe4bb0f965840a160e2166 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2015428 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-01-23 08:00:33 -05:00
sources = [ "win/loader_lock_test_dll.cc" ]
deps = [ ":util" ]
[Windows] Add checks for DLL loader lock. This CL adds code to check if the current thread holds the DLL loader lock. This code can be used to enforce the requirement that certain parts of crashpad, such as process creation are not done during calls to DllMain which can lead to deadlocks and crashes. Only one check is current enforced, in client process creation, and only in debug builds. Bug: crashpad: 316 Change-Id: I5757a264bbf28ce2ab88a0cd7ac9481e46428c17 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1945993 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org>
2019-12-03 10:20:34 -08:00
}
Upstream lightly modified Chromium BUILD.gn files Unreferenced, and not working at all in Crashpad-standalone. Copied from Chromium at 52a9831d81f2099ef9f50fcdaca5853019262c35 to have a point where a roll back into Chromium should be a no-op (with Chromium's build/secondary/third_party/crashpad/... removed). I'm not sure what we want to do about the various gni references into Chromium (e.g. //build/config/sanitizers/sanitizers.gni, //testing/test.gni, etc.) but I guess the sooner they live in Crashpad rather than in Chromium the sooner we can figure out the sort of knobs and dials we need. Bug: crashpad:79 Change-Id: Id99c29123bcd4174ee2bcc128c2be87e3c94fa3f Reviewed-on: https://chromium-review.googlesource.com/777819 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-11-17 17:48:22 -08:00
}
Reference in New Issue Copy Permalink