win: use version.lib instead of mincore.lib

Also enable wd4702: unreachable code for zlib and gtest.

Change-Id: Ie1603b16e96f29b6ac82a1122c5ab5a8942eef24
Reviewed-on: https://chromium-review.googlesource.com/955895
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

third_party/gtest/BUILD.gn

@@ -138,6 +138,10 @@ if (crashpad_is_in_chromium) {
       ":gtest",
       ":gtest_main",
     ]
+
+    if (crashpad_is_win) {
+      cflags = [ "/wd4702" ]  # unreachable code
+    }
   }
 
   test("gtest_environment_test") {

third_party/zlib/BUILD.gn

@@ -89,6 +89,7 @@ if (zlib_source == "external") {
         "/wd4245",  # conversion from 't1' to 't2', signed/unsigned mismatch
         "/wd4267",  # conversion from 'size_t' to 't', possible loss of data
         "/wd4324",  # structure was padded due to alignment specifier
+        "/wd4702",  # unreachable code
       ]
     } else {
       defines += [

util/BUILD.gn

@@ -425,8 +425,12 @@ static_library("util") {
 
   if (crashpad_is_win) {
     libs = [
-      "mincore.lib",
       "user32.lib",
+
+      # TODO(jperaza): version.lib is needed for Windows 7 compatibility.
+      # mincore.lib may be linked against instead when targeting Windows 8+.
+      "version.lib",
+
       "winhttp.lib",
     ]