github/codeql-action
0
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-04-27 09:18:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Michael B. Gale
2025-10-22 17:11:19 +01:00
parent c98d5a9a4f
commit ebd514f490
2 changed files with 30 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/analyze-action.js
Generated
+14 -10
View File
@@ -96411,14 +96411,18 @@ async function run() {
);
}
}
core14.setOutput(
"sarif-id",
uploadResults["code-scanning" /* CodeScanning */]?.sarifID
);
core14.setOutput(
"quality-sarif-id",
uploadResults["code-quality" /* CodeQuality */]?.sarifID
);
if (uploadResults["code-scanning" /* CodeScanning */] !== void 0) {
core14.setOutput(
"sarif-id",
uploadResults["code-scanning" /* CodeScanning */].sarifID
);
}
if (uploadResults["code-quality" /* CodeQuality */] !== void 0) {
core14.setOutput(
"quality-sarif-id",
uploadResults["code-quality" /* CodeQuality */].sarifID
);
}
} else {
logger.info("Not uploading results");
}
@@ -96445,7 +96449,7 @@ async function run() {
}
if (isInTestMode()) {
logger.debug("In test mode. Waiting for processing is disabled.");
} else if (uploadResults !== void 0 && uploadResults["code-scanning" /* CodeScanning */] !== void 0 && getRequiredInput("wait-for-processing") === "true") {
} else if (uploadResults?.["code-scanning" /* CodeScanning */] !== void 0 && getRequiredInput("wait-for-processing") === "true") {
await waitForProcessing(
getRepositoryNwo(),
uploadResults["code-scanning" /* CodeScanning */].sarifID,
@@ -96477,7 +96481,7 @@ async function run() {
);
return;
}
if (runStats !== void 0 && uploadResults !== void 0 && uploadResults["code-scanning" /* CodeScanning */] !== void 0) {
if (runStats !== void 0 && uploadResults?.["code-scanning" /* CodeScanning */] !== void 0) {
await sendStatusReport2(
startedAt,
config,
src/analyze-action.ts
+16 -12
View File
@@ -385,14 +385,20 @@ async function run() {
}
}
core.setOutput(
"sarif-id",
uploadResults[analyses.AnalysisKind.CodeScanning]?.sarifID,
);
core.setOutput(
"quality-sarif-id",
uploadResults[analyses.AnalysisKind.CodeQuality]?.sarifID,
);
// Set the SARIF id outputs only if we have results for them, to avoid
// having keys with empty values in the action output.
if (uploadResults[analyses.AnalysisKind.CodeScanning] !== undefined) {
core.setOutput(
"sarif-id",
uploadResults[analyses.AnalysisKind.CodeScanning].sarifID,
);
}
if (uploadResults[analyses.AnalysisKind.CodeQuality] !== undefined) {
core.setOutput(
"quality-sarif-id",
uploadResults[analyses.AnalysisKind.CodeQuality].sarifID,
);
}
} else {
logger.info("Not uploading results");
}
@@ -434,8 +440,7 @@ async function run() {
if (util.isInTestMode()) {
logger.debug("In test mode. Waiting for processing is disabled.");
} else if (
uploadResults !== undefined &&
uploadResults[analyses.AnalysisKind.CodeScanning] !== undefined &&
uploadResults?.[analyses.AnalysisKind.CodeScanning] !== undefined &&
actionsUtil.getRequiredInput("wait-for-processing") === "true"
) {
await uploadLib.waitForProcessing(
@@ -479,8 +484,7 @@ async function run() {
if (
runStats !== undefined &&
uploadResults !== undefined &&
uploadResults[analyses.AnalysisKind.CodeScanning] !== undefined
uploadResults?.[analyses.AnalysisKind.CodeScanning] !== undefined
) {
await sendStatusReport(
startedAt,