mirror of
https://github.com/github/codeql-action.git
synced 2026-05-02 03:40:10 +00:00
Address review comments
This commit is contained in:
+1
-1
@@ -5,7 +5,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th
|
||||
## [UNRELEASED]
|
||||
|
||||
- Fixed [a bug](https://github.com/github/codeql-action/issues/3555) which caused the CodeQL Action to fail loading repository properties if a "Multi select" repository property was configured for the repository. [#3557](https://github.com/github/codeql-action/pull/3557)
|
||||
- Added an experimental change which skips collecting file coverage information on pull requests to improve analysis performance. File coverage information will still be computed when analyzing the default branch and protected branches.
|
||||
- Added an experimental change which skips collecting file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.
|
||||
|
||||
Repositories owned by an organization can opt out of this change by creating a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then setting this property to `true` in the repository's settings. For more information, see [Managing custom properties for repositories in your organization](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization).
|
||||
|
||||
|
||||
Generated
+1
-1
@@ -109761,7 +109761,7 @@ async function run(startedAt) {
|
||||
)
|
||||
);
|
||||
}
|
||||
if (config.enableFileCoverageInformation && isAnalyzingPullRequest() && repositoryPropertiesResult.orElse({})["github-codeql-file-coverage-on-prs" /* FILE_COVERAGE_ON_PRS */] === true) {
|
||||
if (config.enableFileCoverageInformation && isAnalyzingPullRequest() && await features.getValue("skip_file_coverage_on_prs" /* SkipFileCoverageOnPrs */, codeql) && repositoryPropertiesResult.orElse({})["github-codeql-file-coverage-on-prs" /* FILE_COVERAGE_ON_PRS */] === true) {
|
||||
addNoLanguageDiagnostic(
|
||||
config,
|
||||
makeTelemetryDiagnostic(
|
||||
|
||||
@@ -403,6 +403,7 @@ async function run(startedAt: Date) {
|
||||
if (
|
||||
config.enableFileCoverageInformation &&
|
||||
isAnalyzingPullRequest() &&
|
||||
(await features.getValue(Feature.SkipFileCoverageOnPrs, codeql)) &&
|
||||
repositoryPropertiesResult.orElse({})[
|
||||
RepositoryPropertyName.FILE_COVERAGE_ON_PRS
|
||||
] === true
|
||||
|
||||
Reference in New Issue
Block a user