667 Commits

Author SHA1 Message Date
Robert Edmonds
5f2aa966de
Merge pull request #482 from KivApple/master
Use CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR
2023-07-02 02:19:16 -04:00
Robert Edmonds
484e6b98b2
Merge pull request #472 from morrisonlevi/cmake-targets
Export and install CMake targets
2023-07-02 02:11:05 -04:00
Robert Edmonds
0c5f04555a
Merge pull request #525 from defold/fix-unzip-on-windows
GitHub actions fail on Windows due to missing unzip command
2023-07-02 01:37:51 -04:00
Robert Edmonds
5c5a9981c0
Merge pull request #486 from franksinankaya/frkaya/linkorder
Makefile.am: change link order
2023-01-04 23:45:17 -05:00
Björn Ritzl
182953ead0 Use 7zip instead
7zip is installed on the GitHub runners: https://github.com/actions/runner-images/blob/main/images/win/Windows2019-Readme.md#tools
2022-10-01 22:00:23 +02:00
Robert Edmonds
abc67a11c6 ChangeLog: 1.4.1 v1.4.1 2022-07-10 21:33:59 -04:00
Robert Edmonds
471aaa5f6d Bump copyright years to 2022 2022-07-10 21:33:59 -04:00
Robert Edmonds
a0a0131c89 Bump version to 1.4.1 2022-07-10 21:33:59 -04:00
Robert Edmonds
6d4eafd55f
Merge pull request #514 from protobuf-c/edmonds/issue512
Fix issue #512: clang analyzer 14 warning about a possible NULL deref.
2022-07-10 21:12:43 -04:00
Todd C. Miller
ab5f76a52b Fix a clang analyzer 14 warning about a possible NULL deref.
[edmonds: Import commit from
bfc6249902.patch.]
2022-07-10 20:39:06 -04:00
Robert Edmonds
ec3d900001
Merge pull request #513 from protobuf-c/edmonds/issue499
Fix issue #499: unsigned integer overflow
2022-07-10 20:37:15 -04:00
Todd C. Miller
0d1fd124a4 Fix regression with zero-length messages introduced in protobuf-c PR 500.
[edmonds: Import bugfix from
b6a6451482.patch.]
2022-07-10 20:09:23 -04:00
10054172
289f5c18b1 Fix issue #499: unsigned integer overflow
Signed-off-by: 10054172 <hui.zhang@thalesgroup.com>
2022-07-10 20:02:21 -04:00
Robert Edmonds
fc9b2b2ea9
Merge pull request #508 from millert/master
Only shift unsigned values to avoid implementation-specific behavior.
2022-07-10 19:57:15 -04:00
Todd C. Miller
6e389ce2c3 Only shift unsigned values to avoid implementation-specific behavior.
This converts the arithmetic shifts to logical shifts.
It is based in part on a stackoverflow answer by John Schultz,
https://stackoverflow.com/questions/4533076/google-protocol-buffers-zigzag-encoding
2022-06-06 13:57:38 -06:00
Sinan Kaya
d3651a3c50 Makefile.am: change link order
protoc depends on protobuf libraries for execution. Order libraries
accordingly. Observing link errors with yocto's meta-mingw project
during static linkage.

Signed-off-by: Sinan Kaya <sinan.kaya@microsoft.com>
2021-08-11 14:49:42 +03:00
Ivan KOLESNIKOV
500256bb37 Replace more CMAKE_BINARY_DIR to CMAKE_CURRENT_BINARY_DIR 2021-07-28 14:26:58 +02:00
Ivan KOLESNIKOV
6957eb54eb Use CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR to improve compatibility (especially with building using add_subdirectory) 2021-07-28 13:36:37 +02:00
Robert Edmonds
f224ab2eeb ChangeLog: 1.4.0 v1.4.0 2021-05-18 20:45:28 -04:00
Robert Edmonds
a124b38608 Bump version to 1.4.0 2021-05-18 20:28:48 -04:00
Levi Morrison
9fd8df92ca Export and install CMake targets
The steps to add this functionality are from the cmake tutorial:
https://cmake.org/cmake/help/latest/guide/tutorial/index.html

The include directories being set on the targets is necessary
for dependent targets. There is some redundancy with the
INCLUDE_DIRECTORIES calls alreday present, but I left it alone
to make the PR smaller and more approachable.

The project currently uses mixed cases in functions. This uses
lowercase on calls I touched, as this is what CMake documentation
uses and seems to be the preferred way.

I also started wrapping long lines, as some of the lines I touched
were over 170 characters.

I tested this on both Mac OS 10.15 Catalina and CentOS 7 (with
devtoolset-7) with CMake 3.10.3.
Will work on tests in CI next.
2021-04-12 18:42:47 -06:00
Ilya Lipnitskiy
9c0fdd12c3
Merge pull request #471 from protobuf-c/ga-pr
Run GitHub actions also on pull requests
2021-04-09 20:00:55 -07:00
Ilya Lipnitskiy
50851e47bc
Run GitHub actions also on pull requests
The push trigger didn't seem to work for PRs based in outside repos. So
limit the push trigger to master and next and enable a PR trigger.
2021-04-09 19:48:17 -07:00
Robert Edmonds
7c6b54b162
Merge pull request #467 from protobuf-c/issue-440
protobuf-c.c: fix packed repeated bool parsing
2021-04-06 20:18:34 -04:00
Robert Edmonds
1b6519e4a8
Merge pull request #466 from protobuf-c/options
protoc-c: add custom options support
2021-04-06 20:16:02 -04:00
Robert Edmonds
5ae0762b85
Merge branch 'next' into options 2021-04-06 19:57:36 -04:00
Robert Edmonds
53004955b0
Merge pull request #463 from protobuf-c/wiretype
protobuf-c: don't use ProtobufCWireType internally
2021-04-06 19:12:44 -04:00
Robert Edmonds
760c5daf03
Merge pull request #459 from protobuf-c/issue-458
protoc-c: fix shared lib build on windows, migrate from Travis CI to GitHub Actions
2021-04-06 18:31:47 -04:00
Ilya Lipnitskiy
733ae77e23
protobuf-c.c: fix packed repeated bool parsing
From https://developers.google.com/protocol-buffers/docs/proto3#updating:
  int32, uint32, int64, uint64, and bool are all compatible – this means
  you can change a field from one of these types to another without
  breaking forwards- or backwards-compatibility. If a number is parsed
  from the wire which doesn't fit in the corresponding type, you will
  get the same effect as if you had cast the number to that type in C++
  (e.g. if a 64-bit number is read as an int32, it will be truncated to
  32 bits).

Until this fix, protobuf-c did not conform to the rule above when it
came to deserializing non-boolean packed repeated data into a
protobuf_c_boolean array. Fully scan the varint and use parse_boolean to
truncate the resulting value.

Fixes #440
2021-03-28 12:27:51 -07:00
Ilya Lipnitskiy
7df109917a
protoc-c: add c_package option
This option allows to override the top-level 'package' setting, or even
remove the package prefix altogether (if set to "").

Fixes #322
2021-03-21 21:11:51 -07:00
Ilya Lipnitskiy
4f39ca6e0c
protoc-c: don't use FullName helpers for non-full names
FullName* methods are designed to split a full name based on '.' in the
name. name() does not have '.' separators, so call CamelToLower and
CamelToUpper in place of FullNameToLower and FullNameToUpper.
2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
1b4e45e445
protoc-c: remove dead code 2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
f486c8ed66
protoc-c: add use_oneof_field_name option
Allows for generic oneof offset lookups based on the name of the oneof,
instead of having to know the field name. All oneof fields should have
the same offset, since they are members of a union.

Fixes #204
2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
dfb6e300fa
protoc-c: add const_strings option
Keep default as false to preserve backwards compatibility.

Fixes #239
2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
cebe3d03f9
protoc-c: add string as bytes option
Allows treating proto strings as ProtobufCBinaryData to work around
limitations such as NULL characters in strings, which are allowed in
protobuf, but not allowed in 'char *' types.

Fixes #203
2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
6962695641
protoc-c: add option to customize base field name
Fixes #287
2021-03-21 21:11:50 -07:00
Ilya Lipnitskiy
baa860ff97
protoc-c: add options for function generation
Add options controller helper function generation. Preserve existing
behavior of not generating pack/unpack functions for sub-messages if
option is not explicitly set.

Fixes #240
Fixes #442
2021-03-21 21:11:49 -07:00
Ilya Lipnitskiy
883b1acc1b
protoc-c: add no_generate option
Allows suppression of .pb-c.{c,h} file generation on a .proto file
basis.

protobuf-c.proto: Use the new option in itself, because the options are
never used by protobuf-c runtime, only by the protoc-gen-c compiler.

t/test-full.proto: import protobuf-c.proto to test that
protobuf-c.pb-c.h dependency does not get included in test-full.pb-c.h.
2021-03-21 21:11:49 -07:00
Ilya Lipnitskiy
0e060260f0
protoc-c: add custom options support 2021-03-21 20:28:33 -07:00
Ilya Lipnitskiy
73a2ebefe6
Migrate from TravisCI to GitHub actions
We are now able to build against Mac and Windows.
But, mainly, see:
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://docs.travis-ci.com/user/migrate/open-source-on-travis-ci-com/
2021-03-21 13:57:22 -07:00
Ilya Lipnitskiy
e79f7d3ac6
cmake: use static build by default, fix MSVC build
Matches protobuf default behavior:
https://github.com/protocolbuffers/protobuf/tree/master/cmake#dlls-vs-static-linking

Bump min cmake version to use Protobuf_USE_STATIC_LIBS:
https://cmake.org/cmake/help/latest/module/FindProtobuf.html
2021-03-15 18:01:47 -07:00
Ilya Lipnitskiy
18ede005af
protobuf-c.{c,h}: use static empty_string on WIN32
MSVC has issues importing protobuf_c_empty_string from the DLL and using
it in initializers, resulting in errors like when linking against
protobuf-c.dll:
  test-proto3.pb-c.c(13): error C2099: initializer is not a constant
  test-proto3.pb-c.c(19): error C2440: 'initializing': cannot convert from 'void *' to 'Foo__Person__PhoneType'

Work around the issue by not exporting protobuf_c_empty string and
defining it as static const char[] in the protobuf-c.h file itself. This
change only applies to _WIN32 shared library builds.
2021-03-15 18:01:47 -07:00
Ilya Lipnitskiy
d9f098e3ab
Revert "protobuf-c.h: Fix Windows DLL export (Fixes #331)"
This reverts commit 4c8043d02659d18937447d53b38e6bb029cf8e62.
2021-03-15 18:01:47 -07:00
Ilya Lipnitskiy
2a278e0756
protoc-c: fix shared lib build on windows
Fixes #458

Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
2021-03-15 18:01:47 -07:00
Ilya Lipnitskiy
d97abfaea2
protobuf-c: don't use ProtobufCWireType internally
protobuf-c parsing code operates on wire type as uint8_t, so keep it
defined as such to avoid confusion and unnecessary compiler warnings.
2021-03-11 18:13:54 -08:00
Robert Edmonds
38af0d26ab
Merge pull request #453 from wolframroesler/no-unused-parameter
Avoid "unused function parameter" compiler warning
2021-02-18 21:36:05 -05:00
Wolfram Rösler
a60f2680d2
Avoid "unused function parameter" compiler warning 2021-02-18 18:33:24 -08:00
Robert Edmonds
1afa3f67b0
Merge pull request #455 from ihsinme/patch-1
fix invalid unsigned arithmetic.
2021-02-18 21:30:57 -05:00
Robert Edmonds
32f0a781c7
Merge pull request #456 from ppietrasa/master
Install debug symbols alongside the protobuf-c.lib
2021-02-18 21:21:46 -05:00
ihsinme
abca6f6cb6 fix invalid unsigned arithmetic. 2021-02-10 11:41:38 +03:00