6671 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Simon Giesecke	7c0efcb588	Problem: huge stack allocation in Windows select code ... Solution: use fast_vector_t as in poll implementation	2018-06-01 18:20:10 +02:00
Simon Giesecke	2533ffed86	Problem: memcpy code fragment is duplicated ... Solution: unify between Windows and non-Windows code	2018-06-01 18:19:46 +02:00
Simon Giesecke	04dedfbc2a	Problem: duplicated calculation of valid bytes in select pollset ... Solution: extract to function	2018-06-01 18:16:46 +02:00
Simon Giesecke	e4c3297ed8	Problem: fragile handling of possibly dynamically allocated pollfds ... Solution: extract class template fast_vector_t	2018-06-01 17:08:39 +02:00
Simon Giesecke	c6e4b0abb1	Problem: zmq_poll implementation is complex ... Solution: extract compute_timeout method	2018-06-01 17:08:38 +02:00
Simon Giesecke	3db3bbfbbb	Problem: duplication in implementation zmq_poller_poll ... Solution: remove duplication	2018-06-01 17:08:38 +02:00
Luca Boccassi	89e5f15ac4	Merge pull request #3149 from sigiesec/analyze ... Few more code style fixes	2018-05-31 17:57:16 +01:00
Simon Giesecke	67b602fe76	Problem: unused variable warnings for values only used in asserts ... Solution: use a Debug build for analysis	2018-05-31 11:25:35 +02:00
Simon Giesecke	3cb4754602	Problem: analysis job prolongs overall build ... Solution: start analysis job first, if enabled, since it takes the longest time	2018-05-31 11:23:04 +02:00
Simon Giesecke	4604014c12	Problem: unused result of call to pull_msg ... Solution: add TODO comment regarding handling of the result	2018-05-31 11:21:33 +02:00
Simon Giesecke	c2ba553d87	Problem: unused values stored to variable, duplicated code ... Solution: remove duplicated and redundant code	2018-05-31 11:02:26 +02:00
Simon Giesecke	ee4cdf8bf0	Problem: suspicious use of memcmp result ... Solution: explicitly compare result against 0	2018-05-31 11:02:26 +02:00
Luca Boccassi	6bfa91f13f	Merge pull request #3145 from sigiesec/analyze ... More code style fixes and improvements to static analysis configuration	2018-05-31 07:59:43 +01:00
Simon Giesecke	0b8f586d8f	Merge pull request #3144 from bluca/autoconf_taut ... Problem: autoconf checks tautological compiler flag only for C++	2018-05-30 23:25:03 +02:00
Simon Giesecke	a2f91c5509	Problem: unnecessary passing of non-const data ... Solution: make const	2018-05-30 23:21:53 +02:00
Simon Giesecke	c641644bb2	Problem: inconsistent parameter names ... Solution: harmonize	2018-05-30 23:21:52 +02:00
Simon Giesecke	ce4b71c3fa	Problem: cppcoreguidelines-pro-type-static-cast-downcast warnings that are not meant to be resolved ... Solution: disable cppcoreguidelines-pro-type-static-cast-downcast warning	2018-05-30 23:21:52 +02:00
Simon Giesecke	9e6f1c9a3c	Problem: redundant else after return ... Solution: remove redundant else	2018-05-30 23:21:52 +02:00
Simon Giesecke	6fa12bd692	Problem: unused stored value warning ... Solution: add LIBZMQ_UNUSED	2018-05-30 23:21:52 +02:00
Simon Giesecke	0f2979a38e	Problem: assignment used as condition warning ... Solution: changed condition	2018-05-30 23:21:52 +02:00
Simon Giesecke	24edc828ab	Problem: redundant else after return ... Solution: remove redundant else	2018-05-30 23:21:52 +02:00
Simon Giesecke	88646438d2	Problem: differing parameter names between declaration and definition ... Solution: harmonize	2018-05-30 23:21:52 +02:00
Simon Giesecke	6c67fca7e0	Problem: numerous hicpp-signed-bitwise warnings that cannot easily be solved because of externally defined types ... Solution: disable this warning for now	2018-05-30 23:21:52 +02:00
Simon Giesecke	da4309da13	Problem: violation of parameter naming conventions ... Solution: change to comply with naming conventions	2018-05-30 23:21:52 +02:00
Simon Giesecke	29f1f39df3	Problem: unused parameter warning ... Solution: mark parameter as unused depending on platform definitions	2018-05-30 23:21:52 +02:00
Simon Giesecke	b59d7d574d	Problem: typo in parameter name ... Solution: correct spelling	2018-05-30 22:52:19 +02:00
Simon Giesecke	a91c7e718c	Problem: warnings on violations of CERT ERR-58 ... Solution: declare functions noexcept	2018-05-30 22:52:19 +02:00
Simon Giesecke	0dce223341	Problem: no check if noexcept is supported by compiler ... Solution: add compile check	2018-05-30 22:50:30 +02:00
Simon Giesecke	93194e7c53	Problem: non-portable memset ... Solution: add dummy pointer meber to union instead	2018-05-30 22:50:30 +02:00
Simon Giesecke	9c8fde09ca	Problem: inconsistent control structures in address.cpp, redundant check for NULLness before delete ... Solution: harmonize, remove redundant checks	2018-05-30 22:50:30 +02:00
Simon Giesecke	0179b7577a	Problem: literals protocol names used at various places ... Solution: introduced named constants	2018-05-30 22:50:29 +02:00
Luca Boccassi	06eaf20571	Problem: autoconf checks tautological compiler flag only for C++ ... Solution: check for C as well and set the flags separately	2018-05-30 21:21:59 +01:00
Simon Giesecke	bd76926f5b	Problem: code style issues in options_t (C-style cast, suboptimal std::string::find call, redundant method is_valid) ... Solution: resolved these issues	2018-05-30 13:13:31 +02:00
Simon Giesecke	a96a87f343	Problem: problematic atoi function is used (CERT ERR-34C) ... Solution: use strtol instead	2018-05-30 10:35:01 +02:00
Simon Giesecke	273137741a	Problem: protected data members in ip_address_t, ip_address_mask_t violates LSP ... Solution: make ip_address_mask_t independent of ip_address_t, they do not share that much, remove some code duplication between ip_address_t and ip_addr_t	2018-05-30 10:28:14 +02:00
Simon Giesecke	314ac28dbd	Problem: protected data member in ip_resolver_t ... Solution: declare private	2018-05-30 10:03:55 +02:00
Simon Giesecke	573815da83	Problem: protected data member in encoder_base_t ... Solution: encapsulate data member properly	2018-05-30 09:57:46 +02:00
Luca Boccassi	088fd65bf2	Merge pull request #3143 from sigiesec/remove-extra-files ... Problem: temporary files in repo	2018-05-30 08:36:33 +01:00
Simon Giesecke	be8e7de6be	Problem: temporary files in repo ... Solution: remove them	2018-05-30 09:30:00 +02:00
Luca Boccassi	c6c63481c3	Merge pull request #3142 from sigiesec/analyze ... Remove duplication between stream_t and router_t	2018-05-29 16:47:57 +01:00
Simon Giesecke	5a343fc27b	Problem: stream_t/router_t access data member of base class ... Solution: pull up functionality to base class	2018-05-29 15:05:27 +02:00
Simon Giesecke	ab3895a470	Problem: duplicated code in stream_t & router_t ... Solution: pulled up to routing_socket_base_t	2018-05-29 15:05:27 +02:00
Simon Giesecke	09fab930b3	Problem: xwrite_activated duplicated between stream_t and router_t ... Solution: pull up into routing_socket_base_t	2018-05-29 15:05:27 +02:00
Simon Giesecke	c9d6ef3035	Problem: Member outpipes is duplicate between router_t and stream_t ... Solution: extract into common base class routing_socket_base_t, for now as protected	2018-05-29 15:05:26 +02:00
Simon Giesecke	728eddfcfd	Problem: socket_base_t::connect_routing_id is protected and only used in router_t and stream_t ... Solution: add an intermediary base class routing_socket_base_t, move common functionality there and make connect_routing_id private	2018-05-29 15:05:26 +02:00
Simon Giesecke	25461a78dd	Problem: members of mechanmism_t are needlessly protected ... Solution: make them private	2018-05-29 11:08:22 +02:00
Luca Boccassi	2dfdcaff26	Merge pull request #3141 from sigiesec/analyze ... More code style improvements	2018-05-28 19:22:56 +01:00
Simon Giesecke	47dcd84f21	Problem: C-style casts ... Solution: replace by reinterpret_casts or avoid entirely	2018-05-28 18:47:07 +02:00
Simon Giesecke	917a4a8e10	Problem: reinterpret_casts between unsigned char* and char* ... Solution: use char* from the beginning	2018-05-28 18:47:07 +02:00
Simon Giesecke	0a43c66a32	Problem: magic literals in zap_client.cpp ... Solution: extracted constants	2018-05-28 18:47:07 +02:00