Luca Boccassi
|
79d5ac3dee
|
Merge pull request #3135 from sigiesec/fix-heartbeat-ttl-max
Fix ZMQ_HEARTBEAT_TTL maximum value check
|
2018-05-25 15:57:45 +01:00 |
|
Simon Giesecke
|
763760988f
|
Problem: VS2008 has no definition of UINT16_MAX
Solution: provide definition based on _UI16_MAX
|
2018-05-25 15:13:07 +02:00 |
|
Simon Giesecke
|
8b030a9256
|
Problem: no tests for corner cases of setsockopt ZMQ_HEARTBEAT_TTL
Solution: added tests
|
2018-05-25 15:13:07 +02:00 |
|
Simon Giesecke
|
d90e70c1cf
|
Problem: maximum allowed value for ZMQ_HEARTBEAT_TTL is wrong
Solution: use UINT16_MAX
|
2018-05-25 15:06:11 +02:00 |
|
Luca Boccassi
|
50374bf6f5
|
Merge pull request #3134 from sigiesec/fix-sonarcloud-component-name
Fix sonarcloud component name
|
2018-05-24 17:05:24 +01:00 |
|
Simon Giesecke
|
b791645a49
|
Problem: project key is not unique across organizations
Solution: prefix project key with repo name
|
2018-05-24 18:04:43 +02:00 |
|
Luca Boccassi
|
f0f029c549
|
Merge pull request #3132 from sigiesec/add-vs2008-vs2010-ci
Add CI for VS2008 and VS2010 and fix their builds
|
2018-05-24 17:02:57 +01:00 |
|
Simon Giesecke
|
653c2073de
|
Merge pull request #3133 from bluca/sonarqube_token
Problem: missing sonarqube token
|
2018-05-24 17:08:34 +02:00 |
|
Luca Boccassi
|
cf41aed29d
|
Problem: missing sonarqube token
Solution: add it
|
2018-05-24 16:06:08 +01:00 |
|
Luca Boccassi
|
1644d162fb
|
Merge pull request #3115 from sigiesec/analyze
Add static analysis
|
2018-05-24 16:04:31 +01:00 |
|
Simon Giesecke
|
6afa1cee3a
|
Problem: travis-ci analysis build is always run
Solution: configure to run only on scheduled runs or on specifically named branches
|
2018-05-24 16:15:58 +02:00 |
|
Simon Giesecke
|
51fd4b6a9d
|
Problem: analysis build on PR virtual merges
Solution: skip analysis build in install stage
|
2018-05-24 16:15:57 +02:00 |
|
Simon Giesecke
|
100745d312
|
Problem: appveyor analysis runs on all branches
Solution: restrict to specific branches
|
2018-05-24 16:15:57 +02:00 |
|
Simon Giesecke
|
51d4b00196
|
Problem: no clang-tidy configuration
Solution: add initial .clang-tidy config file
|
2018-05-24 16:15:30 +02:00 |
|
Simon Giesecke
|
7b686900f9
|
Problem: VS2008 build fails due to unavailable stdint.h
Solution: specify not to use stdint.h for VS<=2008, fixes #3025
|
2018-05-24 15:56:08 +02:00 |
|
Simon Giesecke
|
1e89a51734
|
Problem: broken indentation
Solution: fix indentation
|
2018-05-24 15:56:08 +02:00 |
|
Simon Giesecke
|
2ae0c4e2c5
|
Problem: unnecessarily complex inheritance hierarchy in decoders, warning C4355 with VS2010
Solution: make allocator a member of decoder_base_t
|
2018-05-24 15:17:08 +02:00 |
|
Simon Giesecke
|
d96a030125
|
Problem: no CI builds for VS2008/VS2010
Solution: add to appveyor jobs
|
2018-05-24 15:17:04 +02:00 |
|
Simon Giesecke
|
4d3516f634
|
Problem: no static analysis under Linux
Solution: activate clang-tidy, scan-build and sonar-scanner
|
2018-05-24 13:44:46 +02:00 |
|
Simon Giesecke
|
2b31e50b01
|
Problem: No static analysis under Windows
Solution: Enable VS static analyzer and core guideline checks
|
2018-05-24 13:44:45 +02:00 |
|
Luca Boccassi
|
edd9a0c5c8
|
Merge pull request #3130 from sigiesec/fix-automake
Problem: autotools build broken
|
2018-05-24 09:22:26 +01:00 |
|
Simon Giesecke
|
b6d36c92a2
|
Problem: autotools build broken
Solution: fix directory reference
|
2018-05-24 09:09:39 +02:00 |
|
Luca Boccassi
|
f3e7911dd6
|
Merge pull request #3127 from sigiesec/integrate-wepoll
Support epoll polling under Windows with wepoll
|
2018-05-23 21:15:56 +01:00 |
|
Luca Boccassi
|
a6cfbca3ac
|
Merge pull request #3128 from sigiesec/fix-test-inproc-connect
Problem: test_context_socket is not thread-safe
|
2018-05-23 18:47:07 +01:00 |
|
Simon Giesecke
|
06e0c0776d
|
Problem: cmake run is very slow with MSVC
Solution: skip tests than can never succeed with MSVC
|
2018-05-23 18:13:22 +02:00 |
|
Luca Boccassi
|
013958299b
|
Merge pull request #3129 from sigiesec/deprecate-msvc-sln-builds
Problem: prepared Visual Studio solution files are hard to maintain and redundant with CMake builds
|
2018-05-23 16:47:08 +01:00 |
|
Simon Giesecke
|
64f2b100da
|
Problem: test_context_socket is not thread-safe
Solution: use regular zmq_socket instead in thread functions
|
2018-05-23 17:32:27 +02:00 |
|
Simon Giesecke
|
af6d70ec72
|
Problem: prepared Visual Studio solution files are hard to maintain and redundant with CMake builds
Solution: declare them as deprecated
|
2018-05-23 17:26:28 +02:00 |
|
Simon Giesecke
|
9df851225a
|
Problem: test_radio_dish takes time near timeout
Solution: increase timeout
|
2018-05-23 16:31:05 +02:00 |
|
Simon Giesecke
|
945c79de67
|
Problem: test cases setting ZMQ_MULTICAST_LOOP to false fail on Windows
Solution: disable test cases
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
57ef8e2e3e
|
Problem: custom test ignore
Solution: use unity mechanism for ignoring with message
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
2bdf86d6c2
|
Problem: timeout on test_many_sockets with epoll
Solution: increase timeout, remove timeout settings for unsupported poll poller
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
275a89ac3c
|
Problem: test_many_sockets does not show number of sockets that could be created
Solution: add diagnostic output
|
2018-05-23 16:25:08 +02:00 |
|
Simon Giesecke
|
bd129e78ff
|
Problem: test assertion unnecessary complex
Solution: use TEST_ASSERT_FAILURE_ERRNO
|
2018-05-23 16:25:08 +02:00 |
|
Simon Giesecke
|
f5aec6fb27
|
Problem: no CI build with epoll under Windows
Solution: add epoll build job
|
2018-05-23 16:25:07 +02:00 |
|
Simon Giesecke
|
082b6aa641
|
Problem: epoll not supported under Windows
Solution: Use wepoll on Windows
|
2018-05-23 16:25:07 +02:00 |
|
Simon Giesecke
|
c62df64bc2
|
Problem: wepoll source not in repository
Solution: import wepoll 1.5.0 source
|
2018-05-23 16:25:07 +02:00 |
|
Luca Boccassi
|
b56e7f13c5
|
Merge pull request #3126 from sigiesec/migrate-test-inproc-connect
Problem: test_inproc_connect not using test framework
|
2018-05-23 14:54:33 +01:00 |
|
Luca Boccassi
|
3730833f9d
|
Merge pull request #3125 from sigiesec/improve-socket-inheritance
Improve socket inheritance handling
|
2018-05-23 13:50:39 +01:00 |
|
Simon Giesecke
|
fdfa907187
|
Problem: test_inproc_connect not using test framework
Solution: migrate to unity
|
2018-05-23 13:48:58 +02:00 |
|
Simon Giesecke
|
2d9a8955f5
|
Problem: race condition in making socket non-inheritable
Solution: create sockets with WSA_FLAG_NO_HANDLE_INHERIT
|
2018-05-23 11:23:33 +02:00 |
|
Simon Giesecke
|
44da0e7e42
|
Problem: code duplication in making sockets non-inheritable
Solution: extracted make_socket_noninheritable function
|
2018-05-23 11:23:33 +02:00 |
|
Simon Giesecke
|
c432aada84
|
Problem: inconsistent error handling and unnecessary code duplication
Solution: make error handling consistent and use retired_fd to remove code duplication
|
2018-05-23 11:23:33 +02:00 |
|
Luca Boccassi
|
44b0753c5c
|
Merge pull request #3047 from acsearle/master
Allow EBADF on iOS #3046
|
2018-05-23 09:56:32 +01:00 |
|
Luca Boccassi
|
d02ba13576
|
Merge pull request #3122 from sigiesec/test-migrations
Migrated some more tests to unity and fixed some more code style issues
|
2018-05-22 20:37:34 +01:00 |
|
Luca Boccassi
|
6c106d3930
|
Merge pull request #3121 from sigiesec/split-poller-config
Split poller config and disable 'poll' poller on Windows for I/O thread polling
|
2018-05-22 19:31:05 +01:00 |
|
Simon Giesecke
|
440be28d7e
|
Problem: unnecessary non-const variables
Solution: add const
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
d6952ded71
|
Problem: unused include directives and redundant forward declarations
Solution: removed
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
04ec6aaf28
|
Problem: malloc call may fail
Solution: add alloc_assert
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
18eabed6ea
|
Problem: I/O thread poll poller build unsupported
Solution: use API_POLLER=poll instead of POLLER=poll
|
2018-05-22 18:36:04 +02:00 |
|
Simon Giesecke
|
d326434b37
|
Problem: API poller cannot be set independently from I/O thread poller, poll I/O thread poller broken on Windows
Solution: change platform definitions to separate API poller from I/O thread poller, disallow configuring poll I/O thread poller on Windows
|
2018-05-22 18:36:04 +02:00 |
|
Simon Giesecke
|
ad100b0b9f
|
Problem: test_xpub_nodrop not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
f13377de05
|
Problem: test_pub_invert_matching failing
Solution: insert some sleeps to remedy timing dependencies
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
12c6ae2283
|
Problem: test_pub_invert_matching not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
fa467d3425
|
Problem: test_hwm_pubsub not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:17 +02:00 |
|
Simon Giesecke
|
ee85957dc4
|
Problem: no test case for polling pending connect that ultimately fails
Solution: added test case, reproduces the likely cause for #3107
|
2018-05-22 18:21:06 +02:00 |
|
Bill Torpey
|
8ad0d5896e
|
prevent duplicate connections from PUB sockets also (see https://gith… (#3117)
* Update zmq_connect documentation to mention issue of multiple connects to the same endpoint
|
2018-05-22 16:05:32 +01:00 |
|
Luca Boccassi
|
c178193c50
|
Merge pull request #3116 from sigiesec/fix-some-more-style-issues
Fix some more code style issues
|
2018-05-18 17:53:34 +01:00 |
|
Simon Giesecke
|
4e616f30dd
|
Problem: C-style casts used
Solution: replace by C++-style casts
|
2018-05-18 17:04:01 +02:00 |
|
Simon Giesecke
|
d002eb5578
|
Problem: analyzer does not know that zmq_abort does not return
Solution: add no-return attributes
|
2018-05-18 16:25:24 +02:00 |
|
Simon Giesecke
|
7b3acd47b2
|
Problem: malloc may fail in blob_t ctors
Solution: add alloc_assert calls
|
2018-05-18 16:25:24 +02:00 |
|
Simon Giesecke
|
9da0c6d62f
|
Problem: goto jumping backwards
Solution: replace by for loop
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
62e48f837d
|
Problem: assignment within complex condition
Solution: restructured code, inverted condition
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
fcee4ccdfd
|
Problem: type of retired_fd is not fd_t (but int)
Solution: properly declared underlying type of enum declaring retired_fd
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
f103f62630
|
Problem: unreachable return statement
Solution: fix #if/#else structure
|
2018-05-18 14:34:42 +02:00 |
|
Simon Giesecke
|
290d215324
|
Problem: stream_engine assumes options_t.type is a single byte, but its type is int
Solution: change options_t.type to int8_t
|
2018-05-18 14:34:42 +02:00 |
|
Luca Boccassi
|
6a5051fac3
|
Merge pull request #3114 from sigiesec/fix-some-style-issues
Fix some code style issues
|
2018-05-17 15:43:20 +01:00 |
|
Simon Giesecke
|
e19823d83a
|
Problem: redundant else
Solution: remove redundant else
|
2018-05-17 15:17:55 +02:00 |
|
Simon Giesecke
|
ad781319ef
|
Problem: ternary operator used with boolean literals\n\nSolution: Use comparison with 0 instead
|
2018-05-17 15:17:55 +02:00 |
|
Simon Giesecke
|
22b72bb678
|
Problem: deallocate calls release after de-allocation
Solution: reduce to newly extracted function clear, which does not use the freed pointer
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
e37fc47fb6
|
Problem: return value is stored but never used
Solution: add code to make non-use explicit
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
2120f6aced
|
Problem: ypipe_t::read is called with NULL argument
Solution: call check_read instead
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
440d428153
|
Problem: single-argument ctor of blob_t is not marked explicit
Solution: add explicit
|
2018-05-17 13:29:27 +02:00 |
|
Antony Searle
|
fa027970bb
|
Allow EBADF on iOS #3046
|
2018-05-16 14:59:44 +10:00 |
|
Luca Boccassi
|
cbd52feb48
|
Merge pull request #3112 from devindusoft/FixCompilation_ZMQ_ATOMIC_PTR_MUTEX
Fixed compilation with ZMQ_ATOMIC_PTR_MUTEX
|
2018-05-15 15:10:49 +01:00 |
|
Luca Boccassi
|
6a9c6d427f
|
Merge pull request #3111 from sigiesec/win-draft-fix-and-migrate-test
Reenable DRAFT builds on Appveyor and fix test_radio_dish_udp_ipv6
|
2018-05-15 15:08:56 +01:00 |
|
Simon Giesecke
|
e78d20ff2c
|
Problem: test_radio_dish_udp_ipv6 triggers assertion under Windows
Solution: fix handling of sockaddr in recvfrom
|
2018-05-15 14:53:40 +02:00 |
|
Simon Giesecke
|
dd1c87f9d9
|
Problem: type mismatch errors/warnings in Windows build
Solution: fix types
|
2018-05-15 14:53:40 +02:00 |
|
Simon Giesecke
|
10cb710ab8
|
Problem: appveyor builds do not build DRAFT
Solution: set ENABLE_DRAFTS=ON
|
2018-05-15 14:53:40 +02:00 |
|
Luca Boccassi
|
7953083617
|
Merge pull request #3109 from sigiesec/migrate-test-spec-dealer-to-unity
Problem: test_spec_dealer not using test framework
|
2018-05-15 13:25:18 +01:00 |
|
Simon Giesecke
|
b30cbfc112
|
Problem: test_spec_dealer not using test framework
Solution: migrate to Unity
|
2018-05-15 13:58:08 +02:00 |
|
korbes
|
63e1e745f8
|
Fixed compilation with ZMQ_ATOMIC_PTR_MUTEX
|
2018-05-14 22:08:15 -03:00 |
|
Luca Boccassi
|
d81a041f18
|
Merge pull request #3103 from sigiesec/win-warnings-as-errors
Warnings in Windows builds
|
2018-05-14 22:53:04 +01:00 |
|
Simon Giesecke
|
d437d668c0
|
Problem: MSVC warnings in connection with poll
Solution: handle types properly
|
2018-05-14 22:25:21 +02:00 |
|
Simon Giesecke
|
e447f058e2
|
Problem: C4244 warnings regarding SOCKET vs. int in test_system
Solution: Use fd_t
|
2018-05-14 21:09:57 +02:00 |
|
Simon Giesecke
|
106127b5d6
|
Problem: C4267 warnings in test_stream_disconnect
Solution: Use size_t instead of int
|
2018-05-14 21:09:57 +02:00 |
|
Simon Giesecke
|
5ca0d4e8a9
|
Problem: C4267 warnings in test_spec_router
Solution: Use unsigned char instead of size_t
|
2018-05-14 21:09:57 +02:00 |
|
Simon Giesecke
|
69a6b86310
|
Problem: C4267 warning test_spec_pushpull
Solution: Use unsigned char instead of size_t
|
2018-05-14 21:09:57 +02:00 |
|
Simon Giesecke
|
3cbc7cb0dc
|
Problem: C4244 warnings regarding SOCKET vs. int in test_security_null and test_security_plain
Solution: Use fd_t
|
2018-05-14 21:09:56 +02:00 |
|
Simon Giesecke
|
3ee65906af
|
Problem: various warnings regarding SOCKET vs. int in test_security_curve
Solution: Use fd_t
|
2018-05-14 21:09:56 +02:00 |
|
Simon Giesecke
|
28631d1cd3
|
Problem: C4550 warning in testutil_security
Solution: explicitly compare function pointer against NULL
|
2018-05-14 19:18:43 +02:00 |
|
Simon Giesecke
|
b0c3a42ed2
|
Problem: C4800 warnings in unittest_ip_resolver.cpp
Solution: make proper boolean expression
|
2018-05-14 19:18:42 +02:00 |
|
Simon Giesecke
|
c589f2b603
|
Problem: C4800 warning in socket_base.cpp
Solution: make proper boolean expression
|
2018-05-14 19:18:37 +02:00 |
|
Simon Giesecke
|
c52871f82c
|
Problem: C4627 warning in proxy.cpp and signaler.cpp
Solution: move conditional include directive to precompiled.hpp
|
2018-05-14 18:07:13 +02:00 |
|
Simon Giesecke
|
a8095a1046
|
Problem: C4800 warning in ip_resolver.cpp
Solution: fix type specification
|
2018-05-14 18:07:13 +02:00 |
|
Simon Giesecke
|
95c770a275
|
Problem: C4099 warning in udp_engine.cpp
Solution: fix type specification
|
2018-05-14 17:17:11 +02:00 |
|
Simon Giesecke
|
d7e99085ef
|
Problem: Warnings in Windows builds
Solution: enable warnings-as-errors
|
2018-05-14 17:17:10 +02:00 |
|
Luca Boccassi
|
6092431b97
|
Merge pull request #3100 from sigiesec/fix-poller-invalid-events
Problem: zmq_poller_[add/modify] accept invalid events arguments silently
|
2018-05-14 15:26:19 +01:00 |
|
Simon Giesecke
|
8ad43907e6
|
Merge pull request #3101 from bluca/heartbeat_disabled
Problem: heartbeat tests are disabled
|
2018-05-14 15:05:29 +02:00 |
|
Simon Giesecke
|
bf6bde3ae3
|
Problem: unnecessary ifdefs regarding handling of int vs. SOCKET at various places
Solution: use a typedef instead
|
2018-05-14 14:58:36 +02:00 |
|