Luca Boccassi
|
6c613902da
|
Merge pull request #3467 from sigiesec/improve-hwm-pubsub-test
Improve hwm pubsub test
|
2019-04-02 19:44:55 +01:00 |
|
Simon Giesecke
|
b9041bf78c
|
Problem: missing information on assertion failure
Solution: include sent and received counts on assertion failure
|
2019-04-02 18:52:48 +02:00 |
|
Simon Giesecke
|
d328f90bb7
|
Problem: inadequate recv variant used which assumes 0-terminated string
Solution: use array recv variant instead
|
2019-04-02 18:44:55 +02:00 |
|
Simon Giesecke
|
a5ee4fb001
|
Problem: code duplication for multiple transports, multiple test cases combined in one
Solution: split test cases and remove code duplication
|
2019-04-02 18:36:18 +02:00 |
|
Simon Giesecke
|
06f5a6f282
|
Problem: use of generic assertion macro
Solution: use more specific assertion macro
|
2019-04-02 18:35:35 +02:00 |
|
Simon Giesecke
|
d4401b230b
|
Problem: test case not making use of test_bind helper function
Solution: replace custom code by test_bind
|
2019-04-02 18:34:51 +02:00 |
|
Simon Giesecke
|
bdccfe4097
|
Merge pull request #3464 from bluca/ericcson_grant
Relicensing grant from Ericsson
|
2019-03-28 12:33:11 +01:00 |
|
Luca Boccassi
|
2de7f9ccf9
|
Relicensing grant from Ericsson
Received via email on 2019/03/27, message-id:
BL0PR1501MB2003AF12CCA96A583B16D10F9A590@BL0PR1501MB2003.namprd15.prod.outlook.com
|
2019-03-28 10:53:32 +00:00 |
|
Luca Boccassi
|
e20861a065
|
Merge pull request #3463 from sigiesec/fix-3269
Problem: socket returned by ZMQ_FD cannot be used with CreateIoComple…
|
2019-03-27 13:17:47 +00:00 |
|
Simon Giesecke
|
42e27b7d0d
|
Problem: socket returned by ZMQ_FD cannot be used with CreateIoCompletionPort
Solution: add WSA_FLAG_OVERLAPPED socket flag
|
2019-03-27 09:56:11 +01:00 |
|
Luca Boccassi
|
25bb43c33a
|
Merge pull request #3461 from sigiesec/refactor-tests
Refactor tests
|
2019-03-25 09:07:21 +00:00 |
|
Simon Giesecke
|
47dba21005
|
Problem: code is unnecessarily imperative
Solution: make more functional-style
|
2019-03-24 13:46:15 -04:00 |
|
Simon Giesecke
|
bfec30b1e5
|
Problem: test_address_tipc is unnecessarily verbose
Solution: make use of custom Unity macros
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
386de33030
|
Problem: code from bind_loopback_tipc is duplicated
Solution: call bind_loopback_tipc where applicable
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
0e0bead3cf
|
Problem: code from bind_loopback_ipc is duplicated
Solution: call bind_loopback_ipc where applicable
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
7f64b925aa
|
Problem: code from bind_loopback_ipv4 is duplicated
Solution: call bind_loopback_ipv4 where applicable
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
8dc933f2ed
|
Problem: non-expressive test case name
Solution: rename to more meaningful name
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
34999d5069
|
Problem: s_send(more) can be replaced by safer send_string_expect_success
Solution: remove s_send(more) and replace all uses
|
2019-03-24 13:34:13 -04:00 |
|
Simon Giesecke
|
af4fa22fd8
|
Problem: default test setUp/tearDown functions duplicated in many test programs
Solution: define setUp/tearDown functions via SETUP_TEARDOWN_TESTCONTEXT macro where possible
|
2019-03-24 12:53:12 -04:00 |
|
Simon Giesecke
|
2b80dd7add
|
Problem: test_bind used with explicit endpoint where bind_loopback_ipv4 could be used
Solution: use bind_loopback_ipv4 instead
|
2019-03-24 12:35:19 -04:00 |
|
Simon Giesecke
|
454c0b834a
|
Merge pull request #3460 from bluca/borken
Problem: removing header from testutil.hpp breaks unittest build with…
|
2019-03-24 13:18:01 +01:00 |
|
Luca Boccassi
|
dc91981df7
|
Problem: removing header from testutil.hpp breaks unittest build with gcc8
Solution: include unistd.h in unittest_poller.cpp
|
2019-03-24 11:37:41 +00:00 |
|
Luca Boccassi
|
6d77558c77
|
Merge pull request #3459 from sigiesec/migrate-testutil
Migrate testutil* to Unity, and build testutil as separate library
|
2019-03-23 22:40:41 +00:00 |
|
Simon Giesecke
|
c2cd2966ab
|
Problem: no documentation of testutil_unity functions
Solution: add documentation
|
2019-03-23 14:58:47 -04:00 |
|
Simon Giesecke
|
de622c8198
|
Problem: functions are unnecessarily declared in header
Solution: remove from header and declare as static
|
2019-03-23 14:09:06 -04:00 |
|
Simon Giesecke
|
1450830611
|
Problem: unused include directives
Solution: remove and add where needed
|
2019-03-23 09:46:37 -04:00 |
|
Simon Giesecke
|
d0c4402daf
|
Problem: needless use of macros
Solution: convert streq/strneq into functions
|
2019-03-23 09:09:36 -04:00 |
|
Simon Giesecke
|
a62e9d35be
|
Problem: internal functions present in header file
Solution: remove declaration and make functions static
|
2019-03-23 09:09:36 -04:00 |
|
Simon Giesecke
|
5d74eba64a
|
Problem: remaining basic assertions
Solution: use unity assertions instead
|
2019-03-23 09:09:36 -04:00 |
|
Simon Giesecke
|
5b40bdb194
|
Problem: redundant specific of testutil headers
Solution: remove redundant entries
|
2019-03-23 09:09:24 -04:00 |
|
Simon Giesecke
|
347708bcf2
|
Problem: test utilities are in headers and recompiled for every test
Solution: move test utilities to separate testutil library
|
2019-03-23 09:09:24 -04:00 |
|
Simon Giesecke
|
cbd4157638
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:36:28 -04:00 |
|
Simon Giesecke
|
9528983d95
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:36:24 -04:00 |
|
Simon Giesecke
|
90a4d268d9
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:07:32 -04:00 |
|
Simon Giesecke
|
6ed03e9333
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:07:14 -04:00 |
|
Simon Giesecke
|
75cd23d6af
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:39 -04:00 |
|
Simon Giesecke
|
06e713e9e0
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:39 -04:00 |
|
Simon Giesecke
|
4ab381436d
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
6f083df5fb
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
2f40d21618
|
Problem: access to moved object
Solution: use move target instead
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
740780293a
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
e17232f725
|
Problem: possible use-after-free
Solution: check for failure and do not access any members afterwards
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
f083e60d8c
|
Problem: use of extra context
Solution: use test context instead
|
2019-03-22 12:06:12 -04:00 |
|
Simon Giesecke
|
924d47f818
|
Problem: tests without test framework
Solution: migrate to Unity
|
2019-03-22 12:06:12 -04:00 |
|
Luca Boccassi
|
f4b9cc994d
|
Merge pull request #3457 from sigiesec/migrate-zap-test
Migration of further tests & test utilities to Unity
|
2019-03-20 18:40:25 +00:00 |
|
Simon Giesecke
|
0266d4ac27
|
Problem: testutil_monitoring not using unity
Solution: migrate to unity and adapt users
|
2019-03-20 17:03:26 +01:00 |
|
Simon Giesecke
|
f46a96926c
|
Problem: test_security_curve uses custom assertion macro
Solution: use standard TEST_ASSERT_SUCCESS_ERRNO macro instead
|
2019-03-20 16:49:46 +01:00 |
|
Simon Giesecke
|
efaca82bff
|
Problem: testutil_security not using unity
Solution: migrate to unity and adapt users
|
2019-03-20 16:49:46 +01:00 |
|
Simon Giesecke
|
6e0724609a
|
Problem: errno not output on test failure
Solution: use appropriate test assertion macro
|
2019-03-20 16:49:46 +01:00 |
|
Simon Giesecke
|
669fc4df5a
|
Problem: test_security_zap not using a test framework
Solution: migrate to unity
|
2019-03-20 16:49:46 +01:00 |
|