3party/libzmq
0
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2024-12-31 01:43:02 +08:00
Code Issues Projects Releases Wiki Activity
6,660 Commits 4 Branches 39 Tags 31 MiB
Commit Graph

829 Commits

Author SHA1 Message Date
Simon Giesecke
84a3767d61 Problem: open TODO comment regarding explicit zmq_disconnect/zmq_unbind 
Solution: replaced by a comment explaining why the calls are in the test
 2018-03-21 16:28:10 +01:00
Simon Giesecke
786a8d48d5 Problem: code duplication in test_reqrep_tcp 
Solution: extracted make_connect_address
 2018-03-21 15:09:23 +01:00
Simon Giesecke
8372797cc3 Problem: code duplication in test_reqrep_tcp 
Solution: extracted bind_loopback
 2018-03-21 15:09:22 +01:00
Simon Giesecke
c84c3a525a Problem: test_reqrep_tcp not yet using unity 
Solution: migrate to unity
 2018-03-21 15:09:19 +01:00
Simon Giesecke
6d89635f9a Problem: test_udp not using unity 
Solution: migrate to unity, merge into test_radio_dish, and split up test cases
 2018-03-16 17:03:45 +01:00
Simon Giesecke
dc2764f58c Problem: test_last_endpoint not using unity 
Solution: migrate to unity
 2018-03-16 16:35:31 +01:00
Simon Giesecke
1747cbdcac Problem: test_immediate not using unity 
Solution: migrate to unity, and split test cases
 2018-03-16 15:46:39 +01:00
Simon Giesecke
6f8b604648 Problem: test_radio_dish not using unity 
Solution: migrate to unity, and split test cases
 2018-03-16 15:22:14 +01:00
Simon Giesecke
cdc298f567 Problem: bind_loopback_ipv4 not reusable 
Solution: Moved bind_loopback_ipv4 to testutil_unity to allow for reuse
 2018-03-16 15:21:39 +01:00
Kachanovskiy
eb76ea06bd Fix for #2997 2018-03-16 12:48:00 +01:00
Luca Boccassi
4cb15ec638
Merge pull request #2994 from sigiesec/migrate-to-unity 
Migrate further tests to unity, and split up into individual test cases
 2018-03-15 16:55:05 +00:00
Simon Giesecke
7bd57ba83b Problem: test case tests multiple aspects 
Solution: split test case
 2018-03-15 16:43:34 +01:00
Simon Giesecke
3e374d98f1 Problem: test case tests multiple aspects 
Solution: split test case
 2018-03-15 16:43:33 +01:00
Simon Giesecke
eb0307a9a6 Problem: test case tests multiple aspects 
Solution: split test case
 2018-03-15 16:43:32 +01:00
Simon Giesecke
10dae6e830 Problem: test_poller not using unity 
Solution: migrate to unity, and split test cases
 2018-03-15 16:43:30 +01:00
Simon Giesecke
991b2336e4 Problem: test_thread_safe not using unity 
Solution: migrate to unity, and split test cases
 2018-03-15 16:43:27 +01:00
Simon Giesecke
5d32828bbf Problem: test_reconnect_ivl not using unity 
Solution: migrate to unity, and reduce code duplication
 2018-03-15 16:43:26 +01:00
Luca Boccassi
e388774737
Merge pull request #2981 from eponsko/master 
Problem: no support for ZMTP 3.1 application metadata
 2018-03-15 12:57:40 +00:00
Simon Giesecke
1e217ac063 Problem: unity built with unnecessary float but without command line argument support 
Solution: add appropriate definitions to build
 2018-03-15 11:28:50 +01:00
Simon Giesecke
f92cdf9470 Problem: test_ctx_destroy not using unity, and mixing test cases 
Solution: migrate to unit and split up test cases
 2018-03-15 10:58:56 +01:00
Simon Giesecke
9553a1f33e Problem: test_connect_resolve not yet using unity 
Solution: migrate to unity
 2018-03-14 22:40:24 +01:00
Simon Giesecke
6f9459e3fb Migrate tests/test_conflate.cpp to unity 2018-03-14 19:05:19 +01:00
Simon Giesecke
d318c95bc2 Problem: different aspects mixed in one test case 
Solution: split up test case
 2018-03-14 18:59:36 +01:00
Simon Giesecke
dbcd42c58d Migrate tests/test_client_server.cpp to unity 2018-03-14 18:45:26 +01:00
Simon Giesecke
0114572ce6 Migrate tests/test_bind_src_address.cpp to unity 2018-03-14 18:45:25 +01:00
Simon Giesecke
be33dce68e Migrate tests/test_bind_after_connect_tcp.cpp to unity 2018-03-14 18:45:25 +01:00
Simon Giesecke
631de94563 Problem: test_router_hangover not yet using unity 
Solution: migrate to unity
 2018-03-14 15:09:13 +01:00
Pontus Sköldström
dd5eec35be Support application metadata through ZMQ_METADATA 
Lets the application set per-connection metadata.
Metadata is specified as "X-key:value" and set using zmq_setsockopt, eg:
zmq_setsockopt (s, ZMQ_METADATA, "X-key:value", 11);

The peer can then obtain the metadata from a received message:
char *data = zmq_msg_gets(msg, "X-key");
 2018-03-14 12:56:15 +01:00
Simon Giesecke
59157f0e2f Problem: missing guidelines on proper test cleanup 
Solution: add guidelines to tests/README.md
 2018-03-14 12:26:06 +01:00
Simon Giesecke
9e3932b46b Problem: test assertion failures do not clean up properly 
Solution: provide test_context and manage sockets of test_context via setup and teardown
 2018-03-14 12:24:21 +01:00
Simon Giesecke
437e9f4f59 Problem: tests readme outdated 
Solution: fixed description for building tests, added references to unity and unittests
 2018-03-14 08:22:23 +01:00
Simon Giesecke
ae558706bf Problem: test_hwm and test_router_mandatory not yet using unity 
Solution: migrate to unity
 2018-03-14 08:22:23 +01:00
Luca Boccassi
19060345e4 Problem: TIPC availability check is too strict (#2977) 
* Problem: TIPC availability check is too strict

Solution: at build time only check if the API is available. In the tests
do a first check and a skip if the functionality is not available.

TIPC needs an in-tree but not loaded by default kernel module, tipc.ko
to be loaded, which requires root, so it is unlikely to be available on
any build system by default.
This will allow most distributions to ship with TIPC support built in,
and to avoid tests failure if the module is not there.

* Problem: no Travis tests for TIPC

Solution: mark one job with sudo: required and load the kernel module

* Problem: CMake fails when test returns 77 (skip)

Solution: set property to let it mark the test as skipped as intended
 2018-03-09 17:47:42 +01:00
Pontus.Skoeldstroem
7abb8388d6 Problem: Tests for different TIPC address types missing (#2956) 
* Tests for different TIPC address types and code cleanup

* Adds tests for binding/connecting with different TIPC address types
  using Unity
* Adds error checking for address type misuse
 2018-03-07 17:31:26 +00:00
Stefan Kaes
fcbd2a5710 Problem: enormous memory increase due to zero copy decoding 
The zero copy decoding strategy implemented for 4.2.0 can lead to a large
increase of main memory usage in some cases (I have seen one program go up to
40G from 10G after upgrading from 4.1.4). This commit adds a new option to
contexts, called ZMQ_ZERO_COPY_RECV, which allows one to switch to the old
decoding strategy.
 2018-03-05 18:13:28 +01:00
Luca Boccassi
354491ddf2 Problem: no test for ZMQ_XPUB_VERBOSE(R) 
Solution: add test_xpub_verbose to cover those APIs
 2018-03-02 13:42:44 +01:00
Simon Giesecke
0458b85dec Problem: Some tests timeout on appveyor for POLLER=poll 
Solution: Increase test timeouts for poll poller under Windows
 2018-02-13 18:38:26 +01:00
Simon Giesecke
922053237f Problem: test_sockopt_hwm not using unity 
Solution: migrate test_sockopt_hwm to unity
 2018-02-13 18:38:23 +01:00
Simon Giesecke
9ec95f9d46 Problem: build failure with VS <2015, has no snprintf 
Solution: use _snprintf when snprintf is not available
 2018-02-11 17:33:13 +00:00
sigiesec
5f854a31b7 Problem: test_security_curve not using test framework 
Solution: use unity in test_security_curve
 2018-02-11 17:25:36 +00:00
sigiesec
21879abb5b Problem: test_socket_null not using test framework 
Solution: rewrite test_socket_null to use unity
 2018-02-11 17:25:36 +00:00
sigiesec
61a28a26cc Problem: no test framework 
Solution: add unity test framework, and integrate into cmake build
 2018-02-11 17:25:36 +00:00
Luca Boccassi
9b1ce59719 Problem: DRAFT build broken with GCC 4.7 
Solution: change variable type in test_timers to match public API
 2018-02-10 17:08:01 +00:00
Simon Giesecke
a5e763039d Problem: use of TCP loopback fastpath not available for user sockets 
Solution: add socket option
 2018-02-09 14:22:42 +01:00
sigiesec
50d80d0835 Problem: test_timeo frequently fails on travis, probably because of slow 
execution

Solution: relax test assertion to what can be guaranteed
 2018-02-09 09:56:38 +01:00
sigiesec
88d8c768d1 Problem: test_timers frequently fails on travis-ci 
Solution: relaxed test assertions, based on the actual time passed,
instead of assuming that this equals to the time slept
 2018-02-09 09:55:40 +01:00
sigiesec
41f459e1dc Problem: formatting inconsistent 
Solution: applied clang-format
 2018-02-02 15:47:43 +01:00
Luca Boccassi
0298d037d0 Problem: CMake rebuilds everything twice 
Solution: build all the objects separately before the link step, to
avoid rebuilding when doing both static and shared builds
 2017-11-20 15:55:35 +00:00
Luca Boccassi
5264d49eab Problem: duplicate definition in CMake tweetnacl builds 
Solution: don't redefine preprocessor macro if it's already defined in
platform.hpp
 2017-11-19 12:47:05 +00:00
Luca Boccassi
de8f14adf5 Problem: test_security_{zap|curve} often hangs 
Solution: set 0 linger on the sockets immediately after creating them
rather than immediately before closing them.
Running through helgrind/drd highlights a few race conditions, one of
which is the setting of linger vs checking it when closing the socket.
Work around it by setting it immediately to fix the test hangs.
 2017-11-16 00:44:29 +00:00
Luca Boccassi
498c6bbb67 Problem: test_stream_exceeds_buffer cannot be ran in parallel 
Solution: bind to wildcard and let the OS pick a free port instead
of using an hard-coded 12345 TCP port
 2017-11-10 09:49:54 +00:00
Rolf Timmermans
c8592dfbc3 Problem: REQ socket with ZMQ_REQ_RELAXED does not report ZMQ_POLLOUT when queried for events after first message. 
Solution: Check for strictness before returning false if no reply has been received.
 2017-11-08 09:55:14 +01:00
f18m
2aa0e6fd4d Change ZMQ_THREAD_AFFINITY to ZMQ_THREAD_AFFINITY_CPU_ADD/ZMQ_THREAD_AFFINITY_CPU_REMOVE. Avoid prefix thread names when no prefix was set. 2017-10-25 09:55:47 +02:00
Luca Boccassi
bd2ff7fbf8 Problem: DRAFT build broken with old GCC due to missing SIZE_MAX 
Solution: define __STDC_LIMIT_MACROS in test_timers.cpp before
including testutil.hpp so that the definitions are included
 2017-10-17 14:13:28 +01:00
Luca Boccassi
2e2c22dd5b Problem: DRAFT build broken with old GCC due to GNU modifier 
Solution: print unsigned integers instead of size_t to avoid the error:

  error: ISO C++ does not support the 'z' gnu_printf length modifier

due to very old version of GCC.
 2017-10-17 13:36:10 +01:00
f18m
f25cd6e7be Background thread names (#2784) 
* Add ZMQ_THREAD_NAME_PREFIX ctx option
 2017-10-17 12:06:50 +01:00
Luca Boccassi
4c2a95eab2 Problem: test_ctx_options only checks global DRAFT flag 
Solution: this will break once the tested APIs move from DRAFT to STABLE
so instead check for the specific macros.
 2017-10-16 12:34:13 +01:00
f18m
bfbb4ff2e9 Background threads enhancements (#2778) 
* Background thread scheduling 

- add ZMQ_THREAD_AFFINITY ctx option; set all thread scheduling options
from the context of the secondary thread instead of using the main
process thread context!
- change ZMQ_THREAD_PRIORITY to support setting NICE of the background
thread when using SCHED_OTHER
 2017-10-16 12:29:03 +01:00
Luca Boccassi
b6aee51691 Problem: strict ZAP protocol adherence is backward incompatible 
Solution: add ZMQ_ZAP_ENFORCE_DOMAIN to hide backward incompatible
change and make it disabled by default.
In a future release that breaks API compatibility we can then switch
the default to enabled in order to achieve full RFC compatibility.

Fixes #2762
 2017-10-09 17:48:33 +01:00
Luca Boccassi
ed64585e93 Problem: test_rebind_ipc might not see race condition on fast envs 
Solution: pre-create the second socket to save a few cycles between
closing the old one and binding the new one
 2017-10-06 11:32:14 +01:00
Luca Boccassi
53f463a3fa Problem: test_rebind_ipc uses generic socket file name 
Solution: name it after the test to avoid possible clashes when
running tests in parallel.
 2017-10-06 11:08:40 +01:00
Ilya Kulakov
656cdb959a Problem: Race condition in IPC sockets 
Solution: Don't unlink file on close

File may not belong to the socket at that point.
 2017-10-05 14:57:10 -07:00
Luca Boccassi
44f96a3652 Merge pull request #2745 from sigiesec/rename-identity 
Problem: term "identity" is confusing
 2017-09-20 10:08:45 +02:00
Constantin Rack
f6688f0516 Merge pull request #2756 from bluca/reconnect_ivl_connect 
Problem: zmq_connect fails after disconnect due to RECONNECT_IVL == -1
 2017-09-20 07:46:19 +02:00
sigiesec
4b821d8f84 Problem: remaining uses of "identity" 
Solution: replaced by "routing id"
 2017-09-19 17:54:59 +02:00
sigiesec
1414bf938c Problem: use of unqualified "id" in code example 
Solution: use "routing_id" instead
 2017-09-19 17:54:52 +02:00
sigiesec
41bae55af7 Problem: inconsistent naming related to routing ids 
Solution: renamed routing_id fields in pipe_t, renamed ZMQ_CONNECT_RID to ZMQ_CONNECT_ROUTING_ID
 2017-09-19 17:53:53 +02:00
sigiesec
9e7507b38b Problem: term "identity" is confusing 
Solution: replace by "routing id"
 2017-09-19 17:53:44 +02:00
Luca Boccassi
edb4ca1023 Problem: zmq_connect fails after disconnect due to RECONNECT_IVL == -1 
Solution: when a connection breaks and ZMQ_RECONNECT_IVL is set to -1,
which means a reconnection will not be attempted, send a message from
the I/O thread to the application thread to make the socket call
term_endpoint, which is the equivalent of manually calling
zmq_disconnect.
This way subsequent zmq_connect call to the same endpoint will attempt
again to do a connection.
Otherwise, for some socket types like SUBs, those new connects will
fail as the endpoint is recorded, despite the connection having been
permanently closed.

Add test cases to exercise this corner case with TCP and IPC.
 2017-09-19 14:05:43 +01:00
sigiesec
e0243dcbca Problem: tests where client should receive an ERROR sometimes do not 
receive an ERROR (probably because the connection is closed before)

Solution: wait for client-side monitor events before closing the client
socket

Fixes #2705
 2017-09-19 11:16:05 +02:00
sigiesec
77f76a49b2 Problem: no tests for cases 5 and 6 of #2711 
Solution: added tests
 2017-09-18 18:43:32 +02:00
sigiesec
e546f9296e Problem: duplicated code & inconsistent behaviour between 
mechanisms

Solution: uniformly require a ZAP domain to be set to activate ZAP
handling, clarify comment on Stonehouse pattern
 2017-09-18 17:01:38 +02:00
sigiesec
ee8b8bd29c Problem: no test for ZAP handler terminating in flight 
Solution: added test & some improvements of test utils
 2017-09-18 16:54:03 +02:00
sigiesec
a5f94cb610 Problem: tests without ZAP handler are failing 
Solution: emit events as expected by tests, and refuse connections when
ZAP is required but no handler started

Addresses #2711 partially
 2017-09-18 12:58:09 +02:00
sigiesec
13b972b226 Problem: no tests without ZAP handler where one is expected 
Solution: added test case for NULL/PLAIN/CURVE
 2017-09-18 10:26:28 +02:00
Doron Somech
af03241dcb Revert "Problem: term "identity" is confusing" 2017-09-07 15:47:43 +03:00
sigiesec
e00131dd43 Problem: inconsistent naming related to routing ids 
Solution: renamed routing_id fields in pipe_t, renamed ZMQ_CONNECT_RID to ZMQ_CONNECT_ROUTING_ID
 2017-09-07 10:33:13 +02:00
sigiesec
1daf83079a Problem: term "identity" is confusing 
Solution: replace by "routing id"
 2017-09-06 17:45:56 +02:00
Luca Boccassi
b8695a47b5 Problem: proxy_steerable STATISTICS returns conflated buffers 
Solution: split each stat into its own frame, to make it simpler and
easier to use it, especially from high level bindings
 2017-09-06 01:28:28 +01:00
Luca Boccassi
78c4d33600 Problem: new STATISTICS proxy_steerable not behind DRAFT 
Solution: ifdef it until it's declared stable
 2017-09-05 17:37:52 +01:00
Luca Boccassi
c5aef5e078 Problem: compilation fails on 32 bit 
Solution: trucate 64 bit stats in test_proxy, as it's much easier than
to try and print 64 unsigned integers in a portable way
 2017-09-05 17:23:08 +01:00
f18m
4be9513443 Add "STATISTICS" command to zmq_proxy_steerable() (#2737) 
* Issue #2736: Add STATISTICS command to zmq_proxy_steerable()
 2017-09-05 17:05:04 +01:00
Luca Boccassi
0382118371 Problem: unused variable in test_wait_corner_cases 
Solution: don't pass it
 2017-09-01 19:55:51 +01:00
sigiesec
f3b268d84f Problem: no tests for error cases of zmq_socket_get_peer_state 
Solution: added tests
 2017-09-01 16:28:59 +02:00
sigiesec
eeccbbd6f8 Problem: test case fails with tcp transport 
Solution: use inproc transport instead
 2017-09-01 16:28:59 +02:00
sigiesec
fc334bc759 Problem: unclean and duplicated test code 
Solution: refactoring
 2017-09-01 16:28:59 +02:00
sigiesec
f70097c1cf Problem: test does not trigger HWM 
Solution: modify order of operations, add diagnostic output
 2017-09-01 16:28:59 +02:00
sigiesec
cda20260b3 Problem: missing call to zmq_poller_destroy 
Solution: added call
 2017-09-01 16:28:58 +02:00
sigiesec
efa86fe629 Problem: no test case using the proposed zmq_socket_get_peer_state function 
Solution: added test case (with dummy implementation of zmq_socket_get_peer_state)
 2017-09-01 16:28:58 +02:00
sigiesec
49e1b8b75f Problem: test case in main function 
Solution: extracted test_basic function
 2017-09-01 16:28:57 +02:00
Luca Boccassi
fab14a3cc1 Problem: support for CMake << 3.1 broken 
Solution: remove redundant target_sources directive
 2017-09-01 10:59:48 +01:00
sigiesec
7eebed56a5 Problem: no test for zmq_timers_timeout without any active timers 
Solution: add test
 2017-08-23 10:31:44 +02:00
sigiesec
6147e45a07 Problem: missing tests for zmq_timers_* corner cases, missing handling of such corner cases, code duplication, missing assertions in test code 
Solution: add tests, add checks to timers_t, add match_by_id functor, add assertions
 2017-08-23 09:41:34 +02:00
sigiesec
d072d57e2e Problem: no tests for zmq_timer_* with NULL timers argument 
Solution: added tests
 2017-08-23 09:41:22 +02:00
sigiesec
8b263d5820 Problem: test_timers.cpp sleep_ duplicates msleep from testutil 
Solution: replace sleep_ my msleep
 2017-08-23 09:05:10 +02:00
sigiesec
8ae91fdf9a Problem: no test cases for zmq_poller_add*, zmq_poller_modify*, zmq_poller_remove* corner cases 
Solution: added test cases
 2017-08-22 20:22:39 +02:00
sigiesec
68f416c0ca Problem: missing test case for zmq_poller_wait_all with negative number of events 
Solution: add test case
 2017-08-22 20:04:55 +02:00
sigiesec
a71f7b0405 Problem: zmq_poller_* uses ETIMEDOUT (instead of the usual EAGAIN) to indicate timeouts 
Solution: replace ETIMEDOUT within socket_poller_t and all client code by EAGAIN

Fixes #2713
 2017-08-22 20:00:29 +02:00
sigiesec
6a3c053a3e Problem: EFAULT is returned for bad file descriptors passed to zmq_poller_*_fd 
Solution: Return EBADF instead
 2017-08-22 19:43:56 +02:00
sigiesec
74303b08e6 Problem: calling zmq_poller_wait* with NULL events causes an assertion, as opposed to other NULL arguments, which return an error 
Solution: return EFAULT when such an operation is attempted
 2017-08-22 19:43:56 +02:00