3party/libzmq
0
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-03-09 15:26:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: open TODO comment regarding explicit zmq_disconnect/zmq_unbind

Browse Source 
Solution: replaced by a comment explaining why the calls are in the test
This commit is contained in:
Simon Giesecke 2018-03-21 16:28:10 +01:00
parent 786a8d48d5
commit 84a3767d61
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_reqrep_tcp.cpp
View File

@ -55,8 +55,9 @@ void test_single_connect (int ipv6)
bounce (sb, sc);
// TODO is explicit disconnect/unbind essential for the test? if not,
// these calls should probably be left out, for clarity/readability
// the sockets are disconnected and unbound explicitly in this test case
// to check that this can be done successfully with the expected
// endpoints/addresses
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc, my_endpoint));
@ -108,6 +109,8 @@ void test_multi_connect (int ipv6)
bounce (sb2, sc);
bounce (sb0, sc);
/// see comment on zmq_disconnect/zmq_unbind in test_single_connect
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc, my_endpoint_0));
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc, my_endpoint_3));
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc, my_endpoint_1));
@ -161,6 +164,8 @@ void test_multi_connect_same_port (int ipv6)
bounce (sb0, sc0);
bounce (sb1, sc0);
/// see comment on zmq_disconnect/zmq_unbind in test_single_connect
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc1, my_endpoint_4));
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc1, my_endpoint_5));
TEST_ASSERT_SUCCESS_ERRNO (zmq_disconnect (sc0, my_endpoint_2));