3935 Commits

Author SHA1 Message Date
Luca Boccassi
12dede9a13
Finalize NEWS and ABI revision for 4.1.8 v4.1.8 2020-09-02 14:49:51 +01:00
Luca Boccassi
19dadf092e Problem: NEWS does not mention security advisories
Solution: add them
2020-09-02 14:28:18 +01:00
Doron Somech
13d27099e5
Merge pull request #179 from bluca/backport
Backport fixes from libzmq
2020-08-30 07:03:19 +03:00
Luca Boccassi
2fb9c40ca0 Problem: mtrie use of non-tail recursion leads to stack overflow
Solution: convert add and rm functions to iterative algorithms
2020-08-29 22:08:36 +01:00
Luca Boccassi
1a2022fedc Problem: unfinished message can be leaked by client pipe
When a pipe processes a delimiter and is already not in active state but still
has an unfinished message, the message is leaked.

Solution: issue a rollback before losing the reference to the pipe.
(cherry picked from commit 6815138501b9f2a69e807bc3527d93583e633233)

Conflicts:
	src/pipe.cpp
2020-08-29 18:25:58 +01:00
Luca Boccassi
7006df0ac1 Problem: test_security_zap occasionally segfaults
Solution: check if a session's _pipe has been allocated before using
it, since as a consequence of creating the pipes after the handshake
it's no longer guaranteed to be there.

(cherry picked from commit 350b4b34f460b91b8fa8f692cf6bc30d561a5711)

Conflicts:
	src/session_base.cpp
2020-08-29 18:20:31 +01:00
Doron Somech
03ebd39d1f problem: zeromq connects peer before handshake is completed
Solution: delay connecting the peer pipe until the handshake is completed
(cherry picked from commit e7f0090b161ce6344f6bd35009816a925c070b09)

Conflicts:
	src/i_engine.hpp
	src/norm_engine.hpp
	src/pgm_receiver.hpp
	src/pgm_sender.hpp
	src/raw_engine.cpp
	src/session_base.cpp
	src/session_base.hpp
	src/stream_engine_base.cpp
	src/stream_engine_base.hpp
	src/udp_engine.hpp
	src/ws_engine.cpp
	src/zmtp_engine.cpp
	tests/test_mock_pub_sub.cpp
2020-08-29 18:18:29 +01:00
Luca Boccassi
c9894a493d Finalize NEWS and bump ABI revision for 4.1.7 v4.1.7 2019-07-08 17:03:58 +01:00
Doron Somech
e3049f3da9
Merge pull request #176 from bluca/news
CVE-2019-13132
2019-07-08 19:03:08 +03:00
Luca Boccassi
4f4c4d5598 Problem: latest fixes missing from NEWS
Solution: add them
2019-07-05 15:31:35 +01:00
Luca Boccassi
1a9f3b1851 Problem: application metadata not parsed correctly when using CURVE
Solution: create buffers large enough to contain arbitrary metadata
2019-07-02 22:28:51 +01:00
Luca Boccassi
a3f98304da Merge pull request #171 from bluca/travis
Problems: no news for last change, Travis failures
2017-09-23 10:29:45 +01:00
Luca Boccassi
2a2079ef31 Problem: doc build not tested in travis
Solution: install asciidoc and xmlto to run it
2017-09-15 15:42:53 +01:00
Luca Boccassi
159b511b6c Problem: travis OSX job does not set ulimit
Solution: do it, as it's still needed for OSX
2017-09-15 15:42:53 +01:00
Luca Boccassi
63ed586aec Problem: travis job fails due to unsupported ulimit setting
Solution: remove it
2017-09-15 15:39:36 +01:00
Luca Boccassi
90586290a7 Problem: travis job uses custom build path
Solution: remove it, dependencies are in the standard path
2017-09-15 15:39:36 +01:00
Luca Boccassi
6d57807dd0 Problem: travis old brew workaround still in place
Solution: remove it as it's useless now
2017-09-15 15:39:36 +01:00
Luca Boccassi
99e027a152 Problem: travis builds libsodium from scratch everytime
Solution: use packages/brew
2017-09-15 15:39:36 +01:00
Luca Boccassi
448cc73f92 Update NEWS for #164 2017-09-15 15:30:56 +01:00
Luca Boccassi
3c3547a432 Merge pull request #170 from MarkMartinec/master
Add error code EHOSTDOWN to the list of acceptable error codes.
2017-09-14 15:17:58 +02:00
Mark Martinec
78edebb34c Added error code EHOSTDOWN to the list of acceptable error codes.
Fixes #164 (EHOSTDOWN from getsockopt must not cause assertion abort;
            causes SaltStack crashes)
2017-09-14 14:47:33 +02:00
Doron Somech
ebc1d60cf1 Merge pull request #169 from bluca/news
Update NEWS for #2623
2017-07-21 15:34:55 +03:00
Luca Boccassi
eb9e67d5a0 Update NEWS for #2623 2017-07-21 10:57:28 +01:00
Luca Boccassi
b7d9ee5b95 Merge pull request #168 from msune/master
Fix ROUTER's xhas_out() in MANDATORY mode
2017-07-21 10:48:53 +01:00
Marc Sune
10694373e3 Fix ROUTER's xhas_out() in MANDATORY mode
Before this commit, xhas_out() was returning true regardless. This
was correct before the ZMQ_ROUTER_MANDATORY flag as introduced.
However, ZMQ_POLLOUT.

With this commit, _if_ ZMQ_ROUTER_MANDATORY is set, xhas_out() will
return false if ALL peer's outgoing pipes are full.

There is an outstanding high-level design question:

If ZMQ_ROUTER_MANDATORY is set, and zmq_poll() waits for ZMQ_POLLOUT
events, zmq_poll() will immediately wake up if only 1 pipe has
room to send, regardless of the peer, creating a busy loop of
zmq_poll() wake-up, zmq_send() (EAGAIN). There is no way for
the application to selectively wait for ZMQ_POLLOUT for specific
peer(s), which seems somehow necessary in ZMQ_ROUTER_MANDATORY.

This discussion will be addressed in a separate issue.

Signed-off-by: Marc Sune <marc@voltanet.io>
Signed-off-by: Fredi Raspall <fredi@voltanet.io>
2017-07-21 11:21:32 +02:00
Luca Boccassi
44c56a8e09 Merge pull request #166 from pijyoi/master
Problem: pubsub inproc bug not backported
2017-04-07 09:11:41 +01:00
Martin Hurton
e67f935f3a Fix issue #1257 2017-04-07 09:06:48 +08:00
Luca Boccassi
742e303c0d Merge pull request #163 from chutz/fix-divide-by-zero
fix divide by zero in zmq::lb_t::sendpipe
2017-01-28 01:30:00 +00:00
Patrick McLean
b5e25e9f12 fix divide by zero in zmq::lb_t::sendpipe
This is based on https://github.com/zeromq/zeromq3-x/pull/116/files
2017-01-27 17:08:00 -08:00
Constantin Rack
5853120c1f Merge pull request #161 from bluca/news
Update NEWS for #2254
2016-12-15 18:30:45 +01:00
Luca Boccassi
8432d7060f Update NEWS for #2254 2016-12-15 15:27:49 +00:00
Luca Boccassi
4191141fee Merge pull request #160 from laplaceyang/pr_zmq4_pub_with_zmtp_v1_sub
fix bug zmq4.1.x PUB msg to ZMTP 1.0 SUB svr
2016-12-15 16:26:21 +01:00
laplaceyang
e4e6af1876 fix bug zmq4.1.x PUB msg to ZMTP 1.0 SUB svr 2016-12-15 22:55:19 +08:00
Constantin Rack
d23c22cf88 Merge pull request #157 from bluca/bump_ver
Problem: 4.1.6 is out, time to bump version
2016-11-14 19:11:43 +01:00
Luca Boccassi
0680cf6f82 Problem: 4.1.6 is out, time to bump version
Solution: increment version in NEWS and include/zmq.h for the next
round.
2016-11-04 13:17:58 +00:00
Doron Somech
f53060ee60 Merge pull request #159 from bluca/mechanism_off_by_one
Problem: socket_type_string off-by-one error
2016-11-04 14:55:54 +02:00
Luca Boccassi
904d0bd8d3 Problem: socket_type_string off-by-one error
Solution: check socket type from 0 to 11 to include ZMQ_STREAM
2016-11-04 12:13:42 +00:00
Constantin Rack
ec95f91e68 Merge pull request #156 from bluca/rel
Problem: need to tag a new release
v4.1.6
2016-11-01 18:15:43 +01:00
Luca Boccassi
ceb72c7e06 Finalize NEWS and bump ABI to 5:2:0 for 4.1.6 2016-11-01 15:58:34 +00:00
Luca Boccassi
b41ef3963b Problem: spec file hard codes .so version
Solution: use wildcard instead
2016-11-01 15:53:56 +00:00
Doron Somech
3ae04f1d3e Merge pull request #155 from bluca/alignment
Problem: pointer union for zmq_msg_t is a hack
2016-11-01 16:48:14 +02:00
Luca Boccassi
fb1ee2b078 Update NEWS for #1325 2016-11-01 13:07:53 +00:00
Luca Boccassi
f2de03a480 Problem: MS VC++ build broken
Solution: try to detect architecture if building with VC++ and
hardcode pointer size accordingly.
Expressions are not allowed inside declspec intrinsics, which
includes other intrinsics.
2016-11-01 13:07:18 +00:00
Luca Boccassi
a077adb4a0 Problem: pointer union for zmq_msg_t is a hack
Solution: use compiler's alignment attributes instead which is
clearer and less of a hack.
Pointer alignment violations causing crashes on architectures
such as sparc64 and aarch64.
This also avoid triggering ABI checkers as the change is compatible
even though applications that suffer from the bug should rebuild to
take advantage of the fix.
2016-11-01 13:07:18 +00:00
Luca Boccassi
21e484750e Merge pull request #154 from vielmetti/patch-1
Update INSTALL to note issues with parallel "make -j check"
2016-10-23 20:25:47 +01:00
Edward Vielmetti
dc68d2ef45 Update INSTALL to note issues with parallel "make -j check"
Documentation also patched in libzmq. 

Closes #151 to document non-support for parallel make check.
2016-10-23 15:21:57 -04:00
Luca Boccassi
7302228026 Merge pull request #153 from jens-auer/2158
Fixed function prototypes
2016-10-21 12:40:22 +01:00
Jens Auer
56611dd46b Fixed function prototypes 2016-10-21 12:27:32 +02:00
Constantin Rack
ff8b0aa6ec Merge pull request #150 from bluca/news
Problem: NEWS out of date
2016-10-13 13:13:58 +02:00
Luca Boccassi
5e207100f5 Problem: NEWS out of date
Solution: mention recently backported fixes
2016-10-13 10:48:16 +01:00