Simon Giesecke
|
06e0c0776d
|
Problem: cmake run is very slow with MSVC
Solution: skip tests than can never succeed with MSVC
|
2018-05-23 18:13:22 +02:00 |
|
Simon Giesecke
|
9df851225a
|
Problem: test_radio_dish takes time near timeout
Solution: increase timeout
|
2018-05-23 16:31:05 +02:00 |
|
Simon Giesecke
|
945c79de67
|
Problem: test cases setting ZMQ_MULTICAST_LOOP to false fail on Windows
Solution: disable test cases
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
57ef8e2e3e
|
Problem: custom test ignore
Solution: use unity mechanism for ignoring with message
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
2bdf86d6c2
|
Problem: timeout on test_many_sockets with epoll
Solution: increase timeout, remove timeout settings for unsupported poll poller
|
2018-05-23 16:26:52 +02:00 |
|
Simon Giesecke
|
275a89ac3c
|
Problem: test_many_sockets does not show number of sockets that could be created
Solution: add diagnostic output
|
2018-05-23 16:25:08 +02:00 |
|
Simon Giesecke
|
bd129e78ff
|
Problem: test assertion unnecessary complex
Solution: use TEST_ASSERT_FAILURE_ERRNO
|
2018-05-23 16:25:08 +02:00 |
|
Simon Giesecke
|
f5aec6fb27
|
Problem: no CI build with epoll under Windows
Solution: add epoll build job
|
2018-05-23 16:25:07 +02:00 |
|
Simon Giesecke
|
082b6aa641
|
Problem: epoll not supported under Windows
Solution: Use wepoll on Windows
|
2018-05-23 16:25:07 +02:00 |
|
Simon Giesecke
|
c62df64bc2
|
Problem: wepoll source not in repository
Solution: import wepoll 1.5.0 source
|
2018-05-23 16:25:07 +02:00 |
|
Luca Boccassi
|
b56e7f13c5
|
Merge pull request #3126 from sigiesec/migrate-test-inproc-connect
Problem: test_inproc_connect not using test framework
|
2018-05-23 14:54:33 +01:00 |
|
Luca Boccassi
|
3730833f9d
|
Merge pull request #3125 from sigiesec/improve-socket-inheritance
Improve socket inheritance handling
|
2018-05-23 13:50:39 +01:00 |
|
Simon Giesecke
|
fdfa907187
|
Problem: test_inproc_connect not using test framework
Solution: migrate to unity
|
2018-05-23 13:48:58 +02:00 |
|
Simon Giesecke
|
2d9a8955f5
|
Problem: race condition in making socket non-inheritable
Solution: create sockets with WSA_FLAG_NO_HANDLE_INHERIT
|
2018-05-23 11:23:33 +02:00 |
|
Simon Giesecke
|
44da0e7e42
|
Problem: code duplication in making sockets non-inheritable
Solution: extracted make_socket_noninheritable function
|
2018-05-23 11:23:33 +02:00 |
|
Simon Giesecke
|
c432aada84
|
Problem: inconsistent error handling and unnecessary code duplication
Solution: make error handling consistent and use retired_fd to remove code duplication
|
2018-05-23 11:23:33 +02:00 |
|
Luca Boccassi
|
44b0753c5c
|
Merge pull request #3047 from acsearle/master
Allow EBADF on iOS #3046
|
2018-05-23 09:56:32 +01:00 |
|
Luca Boccassi
|
d02ba13576
|
Merge pull request #3122 from sigiesec/test-migrations
Migrated some more tests to unity and fixed some more code style issues
|
2018-05-22 20:37:34 +01:00 |
|
Luca Boccassi
|
6c106d3930
|
Merge pull request #3121 from sigiesec/split-poller-config
Split poller config and disable 'poll' poller on Windows for I/O thread polling
|
2018-05-22 19:31:05 +01:00 |
|
Simon Giesecke
|
440be28d7e
|
Problem: unnecessary non-const variables
Solution: add const
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
d6952ded71
|
Problem: unused include directives and redundant forward declarations
Solution: removed
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
04ec6aaf28
|
Problem: malloc call may fail
Solution: add alloc_assert
|
2018-05-22 18:46:40 +02:00 |
|
Simon Giesecke
|
18eabed6ea
|
Problem: I/O thread poll poller build unsupported
Solution: use API_POLLER=poll instead of POLLER=poll
|
2018-05-22 18:36:04 +02:00 |
|
Simon Giesecke
|
d326434b37
|
Problem: API poller cannot be set independently from I/O thread poller, poll I/O thread poller broken on Windows
Solution: change platform definitions to separate API poller from I/O thread poller, disallow configuring poll I/O thread poller on Windows
|
2018-05-22 18:36:04 +02:00 |
|
Simon Giesecke
|
ad100b0b9f
|
Problem: test_xpub_nodrop not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
f13377de05
|
Problem: test_pub_invert_matching failing
Solution: insert some sleeps to remedy timing dependencies
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
12c6ae2283
|
Problem: test_pub_invert_matching not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:18 +02:00 |
|
Simon Giesecke
|
fa467d3425
|
Problem: test_hwm_pubsub not using test framework
Solution: migrate to unity
|
2018-05-22 18:33:17 +02:00 |
|
Simon Giesecke
|
ee85957dc4
|
Problem: no test case for polling pending connect that ultimately fails
Solution: added test case, reproduces the likely cause for #3107
|
2018-05-22 18:21:06 +02:00 |
|
Bill Torpey
|
8ad0d5896e
|
prevent duplicate connections from PUB sockets also (see https://gith… (#3117)
* Update zmq_connect documentation to mention issue of multiple connects to the same endpoint
|
2018-05-22 16:05:32 +01:00 |
|
Luca Boccassi
|
c178193c50
|
Merge pull request #3116 from sigiesec/fix-some-more-style-issues
Fix some more code style issues
|
2018-05-18 17:53:34 +01:00 |
|
Simon Giesecke
|
4e616f30dd
|
Problem: C-style casts used
Solution: replace by C++-style casts
|
2018-05-18 17:04:01 +02:00 |
|
Simon Giesecke
|
d002eb5578
|
Problem: analyzer does not know that zmq_abort does not return
Solution: add no-return attributes
|
2018-05-18 16:25:24 +02:00 |
|
Simon Giesecke
|
7b3acd47b2
|
Problem: malloc may fail in blob_t ctors
Solution: add alloc_assert calls
|
2018-05-18 16:25:24 +02:00 |
|
Simon Giesecke
|
9da0c6d62f
|
Problem: goto jumping backwards
Solution: replace by for loop
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
62e48f837d
|
Problem: assignment within complex condition
Solution: restructured code, inverted condition
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
fcee4ccdfd
|
Problem: type of retired_fd is not fd_t (but int)
Solution: properly declared underlying type of enum declaring retired_fd
|
2018-05-18 14:34:43 +02:00 |
|
Simon Giesecke
|
f103f62630
|
Problem: unreachable return statement
Solution: fix #if/#else structure
|
2018-05-18 14:34:42 +02:00 |
|
Simon Giesecke
|
290d215324
|
Problem: stream_engine assumes options_t.type is a single byte, but its type is int
Solution: change options_t.type to int8_t
|
2018-05-18 14:34:42 +02:00 |
|
Luca Boccassi
|
6a5051fac3
|
Merge pull request #3114 from sigiesec/fix-some-style-issues
Fix some code style issues
|
2018-05-17 15:43:20 +01:00 |
|
Simon Giesecke
|
e19823d83a
|
Problem: redundant else
Solution: remove redundant else
|
2018-05-17 15:17:55 +02:00 |
|
Simon Giesecke
|
ad781319ef
|
Problem: ternary operator used with boolean literals\n\nSolution: Use comparison with 0 instead
|
2018-05-17 15:17:55 +02:00 |
|
Simon Giesecke
|
22b72bb678
|
Problem: deallocate calls release after de-allocation
Solution: reduce to newly extracted function clear, which does not use the freed pointer
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
e37fc47fb6
|
Problem: return value is stored but never used
Solution: add code to make non-use explicit
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
2120f6aced
|
Problem: ypipe_t::read is called with NULL argument
Solution: call check_read instead
|
2018-05-17 15:05:41 +02:00 |
|
Simon Giesecke
|
440d428153
|
Problem: single-argument ctor of blob_t is not marked explicit
Solution: add explicit
|
2018-05-17 13:29:27 +02:00 |
|
Antony Searle
|
fa027970bb
|
Allow EBADF on iOS #3046
|
2018-05-16 14:59:44 +10:00 |
|
Luca Boccassi
|
cbd52feb48
|
Merge pull request #3112 from devindusoft/FixCompilation_ZMQ_ATOMIC_PTR_MUTEX
Fixed compilation with ZMQ_ATOMIC_PTR_MUTEX
|
2018-05-15 15:10:49 +01:00 |
|
Luca Boccassi
|
6a9c6d427f
|
Merge pull request #3111 from sigiesec/win-draft-fix-and-migrate-test
Reenable DRAFT builds on Appveyor and fix test_radio_dish_udp_ipv6
|
2018-05-15 15:08:56 +01:00 |
|
Simon Giesecke
|
e78d20ff2c
|
Problem: test_radio_dish_udp_ipv6 triggers assertion under Windows
Solution: fix handling of sockaddr in recvfrom
|
2018-05-15 14:53:40 +02:00 |
|