crashpad

mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:26:06 +00:00

History

Nico Weber 7ed4d5c454 arm: Properly mark _ZN8crashpad14CaptureContextEP10ucontext_t as %function

lld wants to remove bl/blx substitution for non-function symbols
(https://reviews.llvm.org/D73542). GNU ld apparently already doesn't
do it.

Since _ZN8crashpad14CaptureContextEP10ucontext_t wasn't marked as a function,
chromium's thumb code would then branch without mode transition into
crashpads non-thumb assembly (in arm32).

So mark the symbol as function, so that things work even if that patch
relands. This should also make things work with GNU ld, though I haven't
verified that it was broken before and works now.

I also did this for aarch64 since it seems like The Right Thing To Do
(assuming the assembler accepts it, which I also haven't checked --
the CQ will hopefully check that).

Bug: chromium:1049649
Change-Id: I3452c16f0d52a2dc0397fd3d60d06b5c39a4b524
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2044144
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

2020-02-07 23:42:19 +00:00

file

[log minidump] add option to log minidump in handler_main

2020-01-30 18:06:58 +00:00

fuchsia

Fuchsia: de-port generate_dump

2019-07-31 15:43:46 +00:00

linux

android: don't expect code addresses to be readable

2019-12-13 18:58:42 +00:00

mac

Use base::size where appropriate, and ArraySize elsewhere