3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

android: don't expect code addresses to be readable

Browse Source 
Change-Id: I252a93db5f4166216664ae8f67e331fc7eed8852
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1967548
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Joshua Peraza 2019-12-13 10:23:12 -08:00 committed by Commit Bot
parent a126f524fa
commit d3d0c8d3ca
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/linux/memory_map_test.cc
View File

@ -101,7 +101,10 @@ TEST(MemoryMap, SelfBasic) {
ASSERT_TRUE(mapping);
EXPECT_GE(code_address, mapping->range.Base());
EXPECT_LT(code_address, mapping->range.End());
#if !defined(OS_ANDROID)
// Android Q+ supports execute only memory.
EXPECT_TRUE(mapping->readable);
#endif
EXPECT_FALSE(mapping->writable);
EXPECT_TRUE(mapping->executable);
@ -167,7 +170,10 @@ class MapChildTest : public Multiprocess {
ASSERT_TRUE(mapping);
EXPECT_GE(code_address, mapping->range.Base());
EXPECT_LT(code_address, mapping->range.End());
#if !defined(OS_ANDROID)
// Android Q+ supports execute only memory.
EXPECT_TRUE(mapping->readable);
#endif
EXPECT_TRUE(mapping->executable);
EXPECT_FALSE(mapping->writable);