mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 07:48:14 +08:00
7fa69e7e43
The “and not memory after range” follow-up to the “extra memory range captured” test is very flaky in debug builds (https://ci.chromium.org/p/crashpad/builders/ci/crashpad_win_dbg/388), and occasionally flaky in release builds too (https://ci.chromium.org/p/crashpad/builders/ci/crashpad_win_rel/363). As with the already-disabled “extra memory removal” test, it’s likely that Crashpad is discovering a pointer that references the memory immediately beyond the intended range, and capturing that too. Unless the environment is very tightly controlled, it’s difficult to prevent valid memory from being pointed to, and thus to guarantee that Crashpad won’t capture a particular block of memory. These are probably never going to be fixed. The flaky tests are removed. Bug: crashpad:101 Change-Id: I629ed8ce3c901507689218baaa102d8737db3f5b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2150055 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>