3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 07:14:10 +08:00
Code Issues Projects Releases Wiki Activity

win: Remove disabled and flaky end-to-end tests

Browse Source 
The “and not memory after range” follow-up to the “extra memory range
captured” test is very flaky in debug builds
(https://ci.chromium.org/p/crashpad/builders/ci/crashpad_win_dbg/388),
and occasionally flaky in release builds too
(https://ci.chromium.org/p/crashpad/builders/ci/crashpad_win_rel/363).
As with the already-disabled “extra memory removal” test, it’s likely
that Crashpad is discovering a pointer that references the memory
immediately beyond the intended range, and capturing that too. Unless
the environment is very tightly controlled, it’s difficult to prevent
valid memory from being pointed to, and thus to guarantee that Crashpad
won’t capture a particular block of memory.

These are probably never going to be fixed. The flaky tests are removed.

Bug: crashpad:101
Change-Id: I629ed8ce3c901507689218baaa102d8737db3f5b
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2150055
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
This commit is contained in:
Mark Mentovai 2020-04-15 12:37:32 -04:00 committed by Commit Bot
parent dc9176b063
commit 7fa69e7e43
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
snapshot/win/end_to_end_test.py
View File

@ -363,23 +363,6 @@ def RunTests(cdb_path,
'L8')
out.Check(r'0000655e 0000656b 00006578 00006585',
'extra memory range captured')
out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? '
r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?',
' and not memory after range')
if False:
# TODO(scottmg): This is flakily capturing too much memory in Debug builds,
# possibly because a stale pointer is being captured via the stack.
# See: https://bugs.chromium.org/p/crashpad/issues/detail?id=101.
out = CdbRun(cdb_path, dump_path,
'dd poi(crashy_program!crashpad::g_extra_memory_not_saved)'
'+0x1f30 L4')
# We save only the pointer, not the pointed-to data. If the pointer itself
# wasn't saved, then we won't get any memory printed, so here we're
# confirming the pointer was saved but the memory wasn't.
out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? '
r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?',
'extra memory removal')
out = CdbRun(cdb_path, dump_path, '.dumpdebug')
out.Check(r'type \?\?\? \(333333\), size 00001000',