3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

Sever the connection between the test support library and snapshot

Browse Source 
This dependency was created in 107fb7631788 for macOS, but it’s not used
on other platforms. Since the test support library is broadly used to
test all of Crashpad, it’s useful even during early-stage porting. The
snapshot library is a higher-level module that builds upon other
components, and is not likely to be functional until the later stages of
porting. Expressing this dependency artifically makes it difficult to
test ports in development.

Change-Id: I9dc2e2c473c8519b4c2b0d774acc9c146ee4e121
Reviewed-on: https://chromium-review.googlesource.com/811564
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mark Mentovai 2017-12-06 13:07:51 -05:00 committed by Commit Bot
parent 612237a032
commit e0f3963131
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/BUILD.gn
View File

@ -90,7 +90,6 @@ static_library("test") {
deps = [
"../compat",
"../snapshot",
"../util",
"//base",
"//testing/gtest",
@ -98,7 +97,10 @@ static_library("test") {
if (is_mac) {
libs = [ "bsm" ]
deps += [ "../handler" ]
deps += [
"../handler",
"../snapshot",
]
}
}

2
test/test.gyp
View File

@ -22,7 +22,6 @@
'type': 'static_library',
'dependencies': [
'../compat/compat.gyp:crashpad_compat',
'../snapshot/snapshot.gyp:crashpad_snapshot',
'../third_party/gtest/gtest.gyp:gtest',
'../third_party/mini_chromium/mini_chromium.gyp:base',
'../util/util.gyp:crashpad_util',
@ -85,6 +84,7 @@
['OS=="mac"', {
'dependencies': [
'../handler/handler.gyp:crashpad_handler_lib',
'../snapshot/snapshot.gyp:crashpad_snapshot',
],
'link_settings': {
'libraries': [