From e0f396313154723a8e5d433ec9175fc42961dc37 Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Wed, 6 Dec 2017 13:07:51 -0500 Subject: [PATCH] Sever the connection between the test support library and snapshot MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This dependency was created in 107fb7631788 for macOS, but it’s not used on other platforms. Since the test support library is broadly used to test all of Crashpad, it’s useful even during early-stage porting. The snapshot library is a higher-level module that builds upon other components, and is not likely to be functional until the later stages of porting. Expressing this dependency artifically makes it difficult to test ports in development. Change-Id: I9dc2e2c473c8519b4c2b0d774acc9c146ee4e121 Reviewed-on: https://chromium-review.googlesource.com/811564 Reviewed-by: Scott Graham Commit-Queue: Mark Mentovai --- test/BUILD.gn | 6 ++++-- test/test.gyp | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/test/BUILD.gn b/test/BUILD.gn index e8c290c7..ae44fc57 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -90,7 +90,6 @@ static_library("test") { deps = [ "../compat", - "../snapshot", "../util", "//base", "//testing/gtest", @@ -98,7 +97,10 @@ static_library("test") { if (is_mac) { libs = [ "bsm" ] - deps += [ "../handler" ] + deps += [ + "../handler", + "../snapshot", + ] } } diff --git a/test/test.gyp b/test/test.gyp index 79e0671a..ce0c817e 100644 --- a/test/test.gyp +++ b/test/test.gyp @@ -22,7 +22,6 @@ 'type': 'static_library', 'dependencies': [ '../compat/compat.gyp:crashpad_compat', - '../snapshot/snapshot.gyp:crashpad_snapshot', '../third_party/gtest/gtest.gyp:gtest', '../third_party/mini_chromium/mini_chromium.gyp:base', '../util/util.gyp:crashpad_util', @@ -85,6 +84,7 @@ ['OS=="mac"', { 'dependencies': [ '../handler/handler.gyp:crashpad_handler_lib', + '../snapshot/snapshot.gyp:crashpad_snapshot', ], 'link_settings': { 'libraries': [