3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 23:01:05 +08:00
Code Issues Projects Releases Wiki Activity

[fuchsia][arm64] Don't query for fp registers

Browse Source 
Fuchsia devices are failing to read floating point context for ARM
because floating point registers are in the vector context for ARM.

This CL prevents warning logs from being emitted in this situation.

Fixed: fuchsia:129171

Tested: `fx shell crasher` @ 659207de7293cb30
Change-Id: I1d8d928da122aeb1bc4ac66b789cb638969d0fdf
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4617960
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Thomas Gales 2023-06-15 19:54:26 +00:00 committed by Joshua Peraza
parent a540e583ac
commit dcdccf56f2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
snapshot/fuchsia/process_reader_fuchsia.cc
View File

@ -345,6 +345,8 @@ void ProcessReaderFuchsia::InitializeThreads() {
} }
} }
// Floating point registers are in the vector context for ARM.
#if !defined(ARCH_CPU_ARM64)
zx_thread_state_fp_regs_t fp_regs; zx_thread_state_fp_regs_t fp_regs;
status = thread_handles[i].read_state( status = thread_handles[i].read_state(
ZX_THREAD_STATE_FP_REGS, &fp_regs, sizeof(fp_regs)); ZX_THREAD_STATE_FP_REGS, &fp_regs, sizeof(fp_regs));
@ -354,6 +356,7 @@ void ProcessReaderFuchsia::InitializeThreads() {
} else { } else {
thread.fp_registers = fp_regs; thread.fp_registers = fp_regs;
} }
#endif
zx_thread_state_vector_regs_t vector_regs; zx_thread_state_vector_regs_t vector_regs;
status = thread_handles[i].read_state( status = thread_handles[i].read_state(