3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:26:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fuchsia] Remove/replace outdated bug references

Browse Source 
Fuchsia migrated issue tracking to fxbug.dev. It appears that DX-1193
did not get migrated.

Fixed: 121707
Change-Id: I4a7fdf00aed223fedd8b66df87647a29139782a1
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4616910
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Thomas Gales 2023-06-14 21:43:46 +00:00 committed by Joshua Peraza
parent 9464ef52c7
commit a540e583ac
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
snapshot/fuchsia/process_reader_fuchsia.cc
View File

@ -234,7 +234,7 @@ void ProcessReaderFuchsia::InitializeModules() {
// Crashpad needs to use the same module name at run time for symbol
// resolution to work properly.
//
// TODO(fuchsia/DX-1234): once Crashpad switches to elf-search, the
// TODO: https://fxbug.dev/6057 - once Crashpad switches to elf-search, the
// following overwrites won't be necessary as only shared libraries will
// have a soname at runtime, just like at build time.
//
@ -265,7 +265,6 @@ void ProcessReaderFuchsia::InitializeModules() {
if (dsoname.empty()) {
// This value must be kept in sync with what is used at build time to
// index symbols for executables and loadable modules.
// See fuchsia/DX-1193 for more details.
module.name = "<_>";
module.type = ModuleSnapshot::kModuleTypeExecutable;
} else {

6
snapshot/fuchsia/system_snapshot_fuchsia.cc
View File

@ -75,7 +75,7 @@ uint32_t SystemSnapshotFuchsia::CPURevision() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Revision();
#else
// TODO(fuchsia/DX-712): Read actual revision.
// TODO: https://fxbug.dev/5561 - Read actual revision.
return 0;
#endif
}
@ -90,7 +90,7 @@ std::string SystemSnapshotFuchsia::CPUVendor() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.Vendor();
#else
// TODO(fuchsia/DX-712): Read actual vendor.
// TODO: https://fxbug.dev/5561 - Read actual vendor.
return std::string();
#endif
}
@ -193,7 +193,7 @@ bool SystemSnapshotFuchsia::NXEnabled() const {
#if defined(ARCH_CPU_X86_64)
return cpuid_.NXEnabled();
#else
// TODO(fuchsia/DX-712): Read actual NX bit value.
// TODO: https://fxbug.dev/5561 - Read actual NX bit value.
return false;
#endif
}