3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 23:01:05 +08:00
Code Issues Projects Releases Wiki Activity

Add missing virtual/protected destructor definitions on virtual classes

Browse Source 
Change-Id: Ic12e131e3e23d153dd5c9733d8f8c5062adbf802
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2259334
Commit-Queue: Eric Astor <epastor@google.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Eric Astor 2020-06-23 10:01:53 -04:00 committed by Commit Bot
parent 4145699874
commit ca0fd934d9
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/crashpad_client_linux.cc
View File

@ -164,6 +164,7 @@ class SignalHandler {
protected: protected:
SignalHandler() = default; SignalHandler() = default;
~SignalHandler() = default;
bool Install(const std::set<int>* unhandled_signals) { bool Install(const std::set<int>* unhandled_signals) {
DCHECK(!handler_); DCHECK(!handler_);

2
tools/mac/catch_exception_tool.cc
View File

@ -51,7 +51,7 @@ struct Options {
MachMessageServer::Persistent persistent; MachMessageServer::Persistent persistent;
}; };
class ExceptionServer : public UniversalMachExcServer::Interface { class ExceptionServer final : public UniversalMachExcServer::Interface {
public: public:
ExceptionServer(const Options& options, ExceptionServer(const Options& options,
const std::string& me, const std::string& me,