From ca0fd934d94f7672afbf73a28f5752dacf823d3b Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 23 Jun 2020 10:01:53 -0400 Subject: [PATCH] Add missing virtual/protected destructor definitions on virtual classes Change-Id: Ic12e131e3e23d153dd5c9733d8f8c5062adbf802 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2259334 Commit-Queue: Eric Astor Reviewed-by: Mark Mentovai --- client/crashpad_client_linux.cc | 1 + tools/mac/catch_exception_tool.cc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/client/crashpad_client_linux.cc b/client/crashpad_client_linux.cc index 9e5141f2..4fb99d84 100644 --- a/client/crashpad_client_linux.cc +++ b/client/crashpad_client_linux.cc @@ -164,6 +164,7 @@ class SignalHandler { protected: SignalHandler() = default; + ~SignalHandler() = default; bool Install(const std::set* unhandled_signals) { DCHECK(!handler_); diff --git a/tools/mac/catch_exception_tool.cc b/tools/mac/catch_exception_tool.cc index 4f40372c..06fda23d 100644 --- a/tools/mac/catch_exception_tool.cc +++ b/tools/mac/catch_exception_tool.cc @@ -51,7 +51,7 @@ struct Options { MachMessageServer::Persistent persistent; }; -class ExceptionServer : public UniversalMachExcServer::Interface { +class ExceptionServer final : public UniversalMachExcServer::Interface { public: ExceptionServer(const Options& options, const std::string& me,