3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-25 22:30:49 +08:00
Code Issues Projects Releases Wiki Activity

Increase kMaxNumberOfAnnotations

Browse Source 
Chrome on ChromeOS is starting to run into problems where there are more
than 200 annotations, primarily because we use a lot of command-line
switches (40 or more) and commandline-enabled-features as well, each of
which takes up an annotation. It's still rare (100s a day) but will
probably become worse over time as more CrashKey uses are added.

Increase kMaxNumberOfAnnotations to 400.

BUG=296821415

Change-Id: Iba7049014ee3c5ae9c45c4022600eaba50acd403
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5354336
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Ian Barkley-Yeung 2024-03-07 13:49:23 -08:00 committed by Crashpad LUCI CQ
parent bc4fd34fe2
commit 9c58b668ff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
snapshot/snapshot_constants.h
View File

@ -21,7 +21,7 @@ namespace crashpad {
//! a client process.
//!
//! \note This maximum was chosen arbitrarily and may change in the future.
constexpr size_t kMaxNumberOfAnnotations = 200;
constexpr size_t kMaxNumberOfAnnotations = 400;
} // namespace crashpad