From 9c58b668ff3372448b1c2ef6e1f3c34930825862 Mon Sep 17 00:00:00 2001 From: Ian Barkley-Yeung Date: Thu, 7 Mar 2024 13:49:23 -0800 Subject: [PATCH] Increase kMaxNumberOfAnnotations Chrome on ChromeOS is starting to run into problems where there are more than 200 annotations, primarily because we use a lot of command-line switches (40 or more) and commandline-enabled-features as well, each of which takes up an annotation. It's still rare (100s a day) but will probably become worse over time as more CrashKey uses are added. Increase kMaxNumberOfAnnotations to 400. BUG=296821415 Change-Id: Iba7049014ee3c5ae9c45c4022600eaba50acd403 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5354336 Reviewed-by: Mark Mentovai Commit-Queue: Ian Barkley-Yeung Reviewed-by: Joshua Peraza --- snapshot/snapshot_constants.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snapshot/snapshot_constants.h b/snapshot/snapshot_constants.h index d33d30a6..2006e7b5 100644 --- a/snapshot/snapshot_constants.h +++ b/snapshot/snapshot_constants.h @@ -21,7 +21,7 @@ namespace crashpad { //! a client process. //! //! \note This maximum was chosen arbitrarily and may change in the future. -constexpr size_t kMaxNumberOfAnnotations = 200; +constexpr size_t kMaxNumberOfAnnotations = 400; } // namespace crashpad