3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better location for adding ExtraMemory snapshots

Browse Source 
Follow up to https://codereview.chromium.org/1364053002/.

R=mark@chromium.org
BUG=crashpad:46

Review URL: https://codereview.chromium.org/1369823002 .
This commit is contained in:
Scott Graham 2015-09-25 13:42:57 -07:00
parent 599eda0403
commit 9bc0a99681
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
minidump/minidump_file_writer.cc
View File

@ -93,14 +93,14 @@ void MinidumpFileWriter::InitializeFromSnapshot(
auto crashpad_info = make_scoped_ptr(new MinidumpCrashpadInfoWriter());
crashpad_info->InitializeFromSnapshot(process_snapshot);
memory_list->AddFromSnapshot(process_snapshot->ExtraMemory());
// Since the MinidumpCrashpadInfo stream is an extension, it’s safe to not add
// it to the minidump file if it wouldn’t carry any useful information.
if (crashpad_info->IsUseful()) {
AddStream(crashpad_info.Pass());
}
memory_list->AddFromSnapshot(process_snapshot->ExtraMemory());
AddStream(memory_list.Pass());
}