From 9bc0a9968104c752f23b7138f3bfa62ab231073d Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Fri, 25 Sep 2015 13:42:57 -0700 Subject: [PATCH] Better location for adding ExtraMemory snapshots Follow up to https://codereview.chromium.org/1364053002/. R=mark@chromium.org BUG=crashpad:46 Review URL: https://codereview.chromium.org/1369823002 . --- minidump/minidump_file_writer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc index 33c4806c..f0c8d4b8 100644 --- a/minidump/minidump_file_writer.cc +++ b/minidump/minidump_file_writer.cc @@ -93,14 +93,14 @@ void MinidumpFileWriter::InitializeFromSnapshot( auto crashpad_info = make_scoped_ptr(new MinidumpCrashpadInfoWriter()); crashpad_info->InitializeFromSnapshot(process_snapshot); - memory_list->AddFromSnapshot(process_snapshot->ExtraMemory()); - // Since the MinidumpCrashpadInfo stream is an extension, it’s safe to not add // it to the minidump file if it wouldn’t carry any useful information. if (crashpad_info->IsUseful()) { AddStream(crashpad_info.Pass()); } + memory_list->AddFromSnapshot(process_snapshot->ExtraMemory()); + AddStream(memory_list.Pass()); }