3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 23:01:05 +08:00
Code Issues Projects Releases Wiki Activity

Disable fastfail end_to_end tests on Windows

Browse Source 
Something in how python is launching these tests changed and
means that although fastfails in fastfail_test_program launch
WerFault it is not looking for or finding the registered
module, so crashpad_wer.dll isn't being loaded, so no
crashes are there to be analyzed.

Run individually the test programs do produce a crash,
and Chrome continues to catch fast fails.

Bug: crashpad:458
Change-Id: I52a6aa7aefb02d393c93c2c43ec67fc92b2bd0b0
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637536
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Alex Gough 2023-06-23 10:09:41 -07:00 committed by Crashpad LUCI CQ
parent dcdccf56f2
commit 7e5b8ab50b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
snapshot/win/end_to_end_test.py
View File

@ -542,7 +542,8 @@ def main(args):
Run7zDumpTest(cdb_path, z7_dump_path)
# __fastfail() & CFG crash caught by WerRuntimeExceptionHelperModule.
if (Win32_20H1()):
# TODO(crashpad:458) These are not working when launched from python.
if (False and Win32_20H1()):
cfg_path = GetDumpFromFastFailProgram(args[0], pipe_name, "cf")
if not cfg_path:
return 1