From 7e5b8ab50b2e1c4baada95774965386079f11306 Mon Sep 17 00:00:00 2001 From: Alex Gough Date: Fri, 23 Jun 2023 10:09:41 -0700 Subject: [PATCH] Disable fastfail end_to_end tests on Windows Something in how python is launching these tests changed and means that although fastfails in fastfail_test_program launch WerFault it is not looking for or finding the registered module, so crashpad_wer.dll isn't being loaded, so no crashes are there to be analyzed. Run individually the test programs do produce a crash, and Chrome continues to catch fast fails. Bug: crashpad:458 Change-Id: I52a6aa7aefb02d393c93c2c43ec67fc92b2bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637536 Commit-Queue: Alex Gough Reviewed-by: Mark Mentovai --- snapshot/win/end_to_end_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py index 136d5b9a..86da4651 100755 --- a/snapshot/win/end_to_end_test.py +++ b/snapshot/win/end_to_end_test.py @@ -542,7 +542,8 @@ def main(args): Run7zDumpTest(cdb_path, z7_dump_path) # __fastfail() & CFG crash caught by WerRuntimeExceptionHelperModule. - if (Win32_20H1()): + # TODO(crashpad:458) These are not working when launched from python. + if (False and Win32_20H1()): cfg_path = GetDumpFromFastFailProgram(args[0], pipe_name, "cf") if not cfg_path: return 1