3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 14:51:03 +08:00
Code Issues Projects Releases Wiki Activity

Remove should-be-dead code after PLOG(FATAL)

Browse Source 
This will trigger dead-code warnings in chromium once LOG(FATAL) is
understood as [[noreturn]], which needs to be fixed in crashpad first.

Bug: 1409729
Change-Id: I75cb4d93e648ca9804f1299345e52bb3e2834cd9
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5193351
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
This commit is contained in:
Peter Boström 2024-01-12 13:27:15 -08:00 committed by Crashpad LUCI CQ
parent 30b2f4ba38
commit 5183bef5f3
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/win/win_child_process.cc
View File

@ -44,7 +44,6 @@ bool GetSwitch(const char* switch_name, std::string* value) {
ScopedLocalAlloc scoped_args(args); // Take ownership. ScopedLocalAlloc scoped_args(args); // Take ownership.
if (!args) { if (!args) {
PLOG(FATAL) << "CommandLineToArgvW"; PLOG(FATAL) << "CommandLineToArgvW";
return false;
} }
std::string switch_name_with_equals(switch_name); std::string switch_name_with_equals(switch_name);