From 5183bef5f384a0cd390c66b42b273535cb27d4fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Bostr=C3=B6m?= Date: Fri, 12 Jan 2024 13:27:15 -0800 Subject: [PATCH] Remove should-be-dead code after PLOG(FATAL) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This will trigger dead-code warnings in chromium once LOG(FATAL) is understood as [[noreturn]], which needs to be fixed in crashpad first. Bug: 1409729 Change-Id: I75cb4d93e648ca9804f1299345e52bb3e2834cd9 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5193351 Reviewed-by: Mark Mentovai Commit-Queue: Peter Boström --- test/win/win_child_process.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/test/win/win_child_process.cc b/test/win/win_child_process.cc index d4d9a462..e31a977d 100644 --- a/test/win/win_child_process.cc +++ b/test/win/win_child_process.cc @@ -44,7 +44,6 @@ bool GetSwitch(const char* switch_name, std::string* value) { ScopedLocalAlloc scoped_args(args); // Take ownership. if (!args) { PLOG(FATAL) << "CommandLineToArgvW"; - return false; } std::string switch_name_with_equals(switch_name);