3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-01-14 17:30:09 +08:00
Code Issues Projects Releases Wiki Activity

list headers' includes as public dependencies

Browse Source 
if only declared as deps, not public_deps, then any header file
depending on these headers need to also list these dependencies

Change-Id: I1d5f6a70d0fb80bf9d7368884247ceee036d1b14
Tested: CQ
Reviewed-on: https://chromium-review.googlesource.com/c/1282013
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
This commit is contained in:
Francois Rousseau 2018-10-16 10:49:43 -07:00 committed by Commit Bot
parent 7682f0f6eb
commit 46b329b369
4 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/BUILD.gn
View File

@ -77,8 +77,7 @@ static_library("client") {
public_configs = [ "..:crashpad_config" ] public_configs = [ "..:crashpad_config" ]
deps = [ public_deps = [
"../compat",
"../third_party/mini_chromium:base", "../third_party/mini_chromium:base",
"../util", "../util",
] ]
@ -89,7 +88,7 @@ static_library("client") {
} }
if (crashpad_is_fuchsia) { if (crashpad_is_fuchsia) {
deps += [ "../third_party/fuchsia:zx" ] deps = [ "../third_party/fuchsia:zx" ]
if (crashpad_is_in_fuchsia) { if (crashpad_is_in_fuchsia) {
deps += [ "//zircon/public/lib/fdio" ] deps += [ "//zircon/public/lib/fdio" ]
} }

10
handler/BUILD.gn
View File

@ -67,14 +67,16 @@ static_library("handler") {
public_configs = [ "..:crashpad_config" ] public_configs = [ "..:crashpad_config" ]
deps = [ public_deps = [
"../client", "../client",
"../compat", "../third_party/mini_chromium:base",
"../util",
]
deps = [
"../minidump", "../minidump",
"../snapshot", "../snapshot",
"../third_party/mini_chromium:base",
"../tools:tool_support", "../tools:tool_support",
"../util",
] ]
if (crashpad_is_win) { if (crashpad_is_win) {

1
handler/minidump_to_upload_parameters.cc
View File

@ -17,6 +17,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "client/annotation.h" #include "client/annotation.h"
#include "snapshot/module_snapshot.h" #include "snapshot/module_snapshot.h"
#include "snapshot/process_snapshot.h"
#include "util/stdlib/map_insert.h" #include "util/stdlib/map_insert.h"
namespace crashpad { namespace crashpad {

4
handler/minidump_to_upload_parameters.h
View File

@ -18,10 +18,10 @@
#include <map> #include <map>
#include <string> #include <string>
#include "snapshot/process_snapshot.h"
namespace crashpad { namespace crashpad {
class ProcessSnapshot;
//! \brief Given a ProcessSnapshot, returns a map of key-value pairs to use as //! \brief Given a ProcessSnapshot, returns a map of key-value pairs to use as
//! HTTP form parameters for upload to a Breakpad crash report colleciton //! HTTP form parameters for upload to a Breakpad crash report colleciton
//! server. //! server.