From 46b329b3690d995d953963a24cae92b9fb9a935c Mon Sep 17 00:00:00 2001
From: Francois Rousseau <frousseau@google.com>
Date: Tue, 16 Oct 2018 10:49:43 -0700
Subject: [PATCH] list headers' includes as public dependencies

if only declared as deps, not public_deps, then any header file
depending on these headers need to also list these dependencies

Change-Id: I1d5f6a70d0fb80bf9d7368884247ceee036d1b14
Tested: CQ
Reviewed-on: https://chromium-review.googlesource.com/c/1282013
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
---
 client/BUILD.gn                          |  5 ++---
 handler/BUILD.gn                         | 10 ++++++----
 handler/minidump_to_upload_parameters.cc |  1 +
 handler/minidump_to_upload_parameters.h  |  4 ++--
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/client/BUILD.gn b/client/BUILD.gn
index a82a8dd4..f23185de 100644
--- a/client/BUILD.gn
+++ b/client/BUILD.gn
@@ -77,8 +77,7 @@ static_library("client") {
 
   public_configs = [ "..:crashpad_config" ]
 
-  deps = [
-    "../compat",
+  public_deps = [
     "../third_party/mini_chromium:base",
     "../util",
   ]
@@ -89,7 +88,7 @@ static_library("client") {
   }
 
   if (crashpad_is_fuchsia) {
-    deps += [ "../third_party/fuchsia:zx" ]
+    deps = [ "../third_party/fuchsia:zx" ]
     if (crashpad_is_in_fuchsia) {
       deps += [ "//zircon/public/lib/fdio" ]
     }
diff --git a/handler/BUILD.gn b/handler/BUILD.gn
index 93fd540a..a1fe65da 100644
--- a/handler/BUILD.gn
+++ b/handler/BUILD.gn
@@ -67,14 +67,16 @@ static_library("handler") {
 
   public_configs = [ "..:crashpad_config" ]
 
-  deps = [
+  public_deps = [
     "../client",
-    "../compat",
+    "../third_party/mini_chromium:base",
+    "../util",
+  ]
+
+  deps = [
     "../minidump",
     "../snapshot",
-    "../third_party/mini_chromium:base",
     "../tools:tool_support",
-    "../util",
   ]
 
   if (crashpad_is_win) {
diff --git a/handler/minidump_to_upload_parameters.cc b/handler/minidump_to_upload_parameters.cc
index 03c6fe14..9e26d877 100644
--- a/handler/minidump_to_upload_parameters.cc
+++ b/handler/minidump_to_upload_parameters.cc
@@ -17,6 +17,7 @@
 #include "base/logging.h"
 #include "client/annotation.h"
 #include "snapshot/module_snapshot.h"
+#include "snapshot/process_snapshot.h"
 #include "util/stdlib/map_insert.h"
 
 namespace crashpad {
diff --git a/handler/minidump_to_upload_parameters.h b/handler/minidump_to_upload_parameters.h
index 41056f70..94d396fa 100644
--- a/handler/minidump_to_upload_parameters.h
+++ b/handler/minidump_to_upload_parameters.h
@@ -18,10 +18,10 @@
 #include <map>
 #include <string>
 
-#include "snapshot/process_snapshot.h"
-
 namespace crashpad {
 
+class ProcessSnapshot;
+
 //! \brief Given a ProcessSnapshot, returns a map of key-value pairs to use as
 //!     HTTP form parameters for upload to a Breakpad crash report colleciton
 //!     server.