mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 22:16:13 +00:00
Targets iPhone 8 when running tests.
The iPhone 8 simulator should be available in both Xcode 10.2 and Xcode 11.3. BUG=None Change-Id: I26570eb2406f67b3663ac9ecb7e7440c0f9fa70d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2085353 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org>
This commit is contained in:
parent
e1b3bd11cd
commit
42da41d24a
@ -437,7 +437,7 @@ def _RunOnFuchsiaTarget(binary_dir, test, device_name, extra_command_line):
|
||||
|
||||
|
||||
def _RunOnIOSTarget(binary_dir, test, is_xcuitest=False):
|
||||
"""Runs the given iOS |test| app on iPhone X with the default OS version."""
|
||||
"""Runs the given iOS |test| app on iPhone 8 with the default OS version."""
|
||||
|
||||
def xctest(binary_dir, test):
|
||||
"""Returns a dict containing the xctestrun data needed to run an
|
||||
@ -496,7 +496,7 @@ def _RunOnIOSTarget(binary_dir, test, is_xcuitest=False):
|
||||
|
||||
subprocess.check_call(['xcodebuild', 'test-without-building',
|
||||
'-xctestrun', xctestrun_path, '-destination',
|
||||
'platform=iOS Simulator,name=iPhone X'])
|
||||
'platform=iOS Simulator,name=iPhone 8'])
|
||||
|
||||
# This script is primarily used from the waterfall so that the list of tests
|
||||
# that are run is maintained in-tree, rather than in a separate infrastructure
|
||||
|
Loading…
x
Reference in New Issue
Block a user