From 42da41d24a21acf469e7a3a1759f551733fb403c Mon Sep 17 00:00:00 2001 From: Rohit Rao Date: Tue, 3 Mar 2020 14:24:38 -0500 Subject: [PATCH] Targets iPhone 8 when running tests. The iPhone 8 simulator should be available in both Xcode 10.2 and Xcode 11.3. BUG=None Change-Id: I26570eb2406f67b3663ac9ecb7e7440c0f9fa70d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2085353 Reviewed-by: Mark Mentovai Commit-Queue: Rohit Rao --- build/run_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/run_tests.py b/build/run_tests.py index 44620fb8..38473cd0 100755 --- a/build/run_tests.py +++ b/build/run_tests.py @@ -437,7 +437,7 @@ def _RunOnFuchsiaTarget(binary_dir, test, device_name, extra_command_line): def _RunOnIOSTarget(binary_dir, test, is_xcuitest=False): - """Runs the given iOS |test| app on iPhone X with the default OS version.""" + """Runs the given iOS |test| app on iPhone 8 with the default OS version.""" def xctest(binary_dir, test): """Returns a dict containing the xctestrun data needed to run an @@ -496,7 +496,7 @@ def _RunOnIOSTarget(binary_dir, test, is_xcuitest=False): subprocess.check_call(['xcodebuild', 'test-without-building', '-xctestrun', xctestrun_path, '-destination', - 'platform=iOS Simulator,name=iPhone X']) + 'platform=iOS Simulator,name=iPhone 8']) # This script is primarily used from the waterfall so that the list of tests # that are run is maintained in-tree, rather than in a separate infrastructure