3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ThreadLogMessages’ test.

Browse Source 
The test wasn’t strictly broken, but an <= written where a < was
intended caused some threads to log more messages than intended.

BUG=crashpad:26
TEST=crashpad_util_test ThreadLogMessages.Multithreaded
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1047813002
This commit is contained in:
Mark Mentovai 2015-03-30 17:58:12 -04:00
parent e95224bbe7
commit 2e64c73330
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/thread/thread_log_messages_test.cc
View File

@ -143,7 +143,7 @@ class LoggingTestThread : public Thread {
ThreadLogMessages thread_log_messages;
std::vector<std::string> expected_messages;
for (int index = start_; index <= start_ + count_; ++index) {
for (int index = start_; index < start_ + count_; ++index) {
std::string message = base::StringPrintf("message %d", index);
expected_messages.push_back(message);
LOG(WARNING) << message;
@ -152,7 +152,7 @@ class LoggingTestThread : public Thread {
const std::vector<std::string>& log_messages =
thread_log_messages.log_messages();
ASSERT_EQ(expected_messages.size(), log_messages.size());
ASSERT_EQ(static_cast<size_t>(count_), log_messages.size());
for (size_t index = 0; index < log_messages.size(); ++index) {
EXPECT_EQ(expected_messages[index], MessageString(log_messages[index]))
<< "thread_number_ " << thread_number_ << ", index " << index;