From 2e64c73330b609f7ddc4700f0a0ed0491b9c1a0a Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Mon, 30 Mar 2015 17:58:12 -0400 Subject: [PATCH] =?UTF-8?q?Fix=20ThreadLogMessages=E2=80=99=20test.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test wasn’t strictly broken, but an <= written where a < was intended caused some threads to log more messages than intended. BUG=crashpad:26 TEST=crashpad_util_test ThreadLogMessages.Multithreaded R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1047813002 --- util/thread/thread_log_messages_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/thread/thread_log_messages_test.cc b/util/thread/thread_log_messages_test.cc index f2392870..4ffe1fc8 100644 --- a/util/thread/thread_log_messages_test.cc +++ b/util/thread/thread_log_messages_test.cc @@ -143,7 +143,7 @@ class LoggingTestThread : public Thread { ThreadLogMessages thread_log_messages; std::vector expected_messages; - for (int index = start_; index <= start_ + count_; ++index) { + for (int index = start_; index < start_ + count_; ++index) { std::string message = base::StringPrintf("message %d", index); expected_messages.push_back(message); LOG(WARNING) << message; @@ -152,7 +152,7 @@ class LoggingTestThread : public Thread { const std::vector& log_messages = thread_log_messages.log_messages(); - ASSERT_EQ(expected_messages.size(), log_messages.size()); + ASSERT_EQ(static_cast(count_), log_messages.size()); for (size_t index = 0; index < log_messages.size(); ++index) { EXPECT_EQ(expected_messages[index], MessageString(log_messages[index])) << "thread_number_ " << thread_number_ << ", index " << index;