3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:26:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

mac: Remove dead code

Browse Source 
Responsibility for creating argv_c has moved to DoubleForkAndExec().

Change-Id: Id663f0597ee1749df564cdacac1d877b5545750b
Reviewed-on: https://chromium-review.googlesource.com/898024
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Joshua Peraza 2018-02-01 10:46:27 -08:00 committed by Commit Bot
parent 574936540d
commit 0fa7d9d424
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
client/crashpad_client_mac.cc
View File

@ -331,17 +331,6 @@ class HandlerStarter final : public NotifyServer::DefaultInterface {
} }
argv.push_back(FormatArgumentInt("handshake-fd", server_write_fd.get())); argv.push_back(FormatArgumentInt("handshake-fd", server_write_fd.get()));
// argv_c contains const char* pointers and is terminated by nullptr. argv
// is required because the pointers in argv_c need to point somewhere, and
// they can’t point to temporaries such as those returned by
// FormatArgumentString().
std::vector<const char*> argv_c;
argv_c.reserve(argv.size() + 1);
for (const std::string& argument : argv) {
argv_c.push_back(argument.c_str());
}
argv_c.push_back(nullptr);
// When restarting, reset the system default crash handler first. Otherwise, // When restarting, reset the system default crash handler first. Otherwise,
// the crash exception port in the handler will have been inherited from // the crash exception port in the handler will have been inherited from
// this parent process, which was probably using the exception server now // this parent process, which was probably using the exception server now