From 0fa7d9d424da85b2b5a6cef02f6f410847f4abfb Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Thu, 1 Feb 2018 10:46:27 -0800 Subject: [PATCH] mac: Remove dead code Responsibility for creating argv_c has moved to DoubleForkAndExec(). Change-Id: Id663f0597ee1749df564cdacac1d877b5545750b Reviewed-on: https://chromium-review.googlesource.com/898024 Reviewed-by: Mark Mentovai Commit-Queue: Joshua Peraza --- client/crashpad_client_mac.cc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/client/crashpad_client_mac.cc b/client/crashpad_client_mac.cc index a16f8d28..4a408206 100644 --- a/client/crashpad_client_mac.cc +++ b/client/crashpad_client_mac.cc @@ -331,17 +331,6 @@ class HandlerStarter final : public NotifyServer::DefaultInterface { } argv.push_back(FormatArgumentInt("handshake-fd", server_write_fd.get())); - // argv_c contains const char* pointers and is terminated by nullptr. argv - // is required because the pointers in argv_c need to point somewhere, and - // they can’t point to temporaries such as those returned by - // FormatArgumentString(). - std::vector argv_c; - argv_c.reserve(argv.size() + 1); - for (const std::string& argument : argv) { - argv_c.push_back(argument.c_str()); - } - argv_c.push_back(nullptr); - // When restarting, reset the system default crash handler first. Otherwise, // the crash exception port in the handler will have been inherited from // this parent process, which was probably using the exception server now