3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a few -Wunreachable-code-aggressive warnings

Browse Source 
No behavior change.

Bug: chromium:1066980
Change-Id: Ic9485f3244516a4196965d2ebb2bfbc2c62a91d7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3054401
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Nico Weber 2021-07-27 09:56:27 -04:00 committed by Crashpad LUCI CQ
parent a62b654838
commit 058c1c2d9c
3 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
snapshot/mac/mach_o_image_annotations_reader_test.cc
View File

@ -398,7 +398,6 @@ class TestMachOImageAnnotationsReader final
case kCrashAbort: { case kCrashAbort: {
abort(); abort();
break;
} }
case kCrashModuleInitialization: { case kCrashModuleInitialization: {
@ -411,7 +410,6 @@ class TestMachOImageAnnotationsReader final
// the FAIL() will fail the test. // the FAIL() will fail the test.
ASSERT_NE(dl_handle, nullptr) << dlerror(); ASSERT_NE(dl_handle, nullptr) << dlerror();
FAIL(); FAIL();
break;
} }
case kCrashDyld: { case kCrashDyld: {

1
util/mach/child_port_handshake_test.cc
View File

@ -130,7 +130,6 @@ class ChildPortHandshakeTest : public Multiprocess {
case TestType::kServerDies: case TestType::kServerDies:
// This was special-cased as an early return above. // This was special-cased as an early return above.
FAIL(); FAIL();
break;
} }
} }

4
util/posix/signals_test.cc
View File

@ -68,7 +68,6 @@ void CauseSignal(int sig) {
switch (sig) { switch (sig) {
case SIGABRT: { case SIGABRT: {
abort(); abort();
break;
} }
case SIGALRM: { case SIGALRM: {
@ -114,7 +113,6 @@ void CauseSignal(int sig) {
*mapped_file.addr_as<char*>() = 0; *mapped_file.addr_as<char*>() = 0;
_exit(kUnexpectedExitStatus); _exit(kUnexpectedExitStatus);
break;
} }
#if !defined(ARCH_CPU_ARM64) #if !defined(ARCH_CPU_ARM64)
@ -143,7 +141,6 @@ void CauseSignal(int sig) {
case SIGILL: { case SIGILL: {
// __builtin_trap() causes SIGTRAP on arm64 on Android. // __builtin_trap() causes SIGTRAP on arm64 on Android.
__builtin_trap(); __builtin_trap();
break;
} }
#endif // defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL) #endif // defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL)
@ -208,7 +205,6 @@ void CauseSignal(int sig) {
default: { default: {
LOG(ERROR) << "unexpected signal " << sig; LOG(ERROR) << "unexpected signal " << sig;
_exit(kUnexpectedExitStatus); _exit(kUnexpectedExitStatus);
break;
} }
} }
} }