From 058c1c2d9c82993aeb0b62e614e96698163b8165 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis@chromium.org>
Date: Tue, 27 Jul 2021 09:56:27 -0400
Subject: [PATCH] Fix a few -Wunreachable-code-aggressive warnings

No behavior change.

Bug: chromium:1066980
Change-Id: Ic9485f3244516a4196965d2ebb2bfbc2c62a91d7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3054401
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
---
 snapshot/mac/mach_o_image_annotations_reader_test.cc | 2 --
 util/mach/child_port_handshake_test.cc               | 1 -
 util/posix/signals_test.cc                           | 4 ----
 3 files changed, 7 deletions(-)

diff --git a/snapshot/mac/mach_o_image_annotations_reader_test.cc b/snapshot/mac/mach_o_image_annotations_reader_test.cc
index aea885a9..cddc3994 100644
--- a/snapshot/mac/mach_o_image_annotations_reader_test.cc
+++ b/snapshot/mac/mach_o_image_annotations_reader_test.cc
@@ -398,7 +398,6 @@ class TestMachOImageAnnotationsReader final
 
       case kCrashAbort: {
         abort();
-        break;
       }
 
       case kCrashModuleInitialization: {
@@ -411,7 +410,6 @@ class TestMachOImageAnnotationsReader final
         // the FAIL() will fail the test.
         ASSERT_NE(dl_handle, nullptr) << dlerror();
         FAIL();
-        break;
       }
 
       case kCrashDyld: {
diff --git a/util/mach/child_port_handshake_test.cc b/util/mach/child_port_handshake_test.cc
index fa7ab093..44139b11 100644
--- a/util/mach/child_port_handshake_test.cc
+++ b/util/mach/child_port_handshake_test.cc
@@ -130,7 +130,6 @@ class ChildPortHandshakeTest : public Multiprocess {
       case TestType::kServerDies:
         // This was special-cased as an early return above.
         FAIL();
-        break;
     }
   }
 
diff --git a/util/posix/signals_test.cc b/util/posix/signals_test.cc
index 25295ff9..3538cf2b 100644
--- a/util/posix/signals_test.cc
+++ b/util/posix/signals_test.cc
@@ -68,7 +68,6 @@ void CauseSignal(int sig) {
   switch (sig) {
     case SIGABRT: {
       abort();
-      break;
     }
 
     case SIGALRM: {
@@ -114,7 +113,6 @@ void CauseSignal(int sig) {
       *mapped_file.addr_as<char*>() = 0;
 
       _exit(kUnexpectedExitStatus);
-      break;
     }
 
 #if !defined(ARCH_CPU_ARM64)
@@ -143,7 +141,6 @@ void CauseSignal(int sig) {
     case SIGILL: {
       // __builtin_trap() causes SIGTRAP on arm64 on Android.
       __builtin_trap();
-      break;
     }
 #endif  // defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL)
 
@@ -208,7 +205,6 @@ void CauseSignal(int sig) {
     default: {
       LOG(ERROR) << "unexpected signal " << sig;
       _exit(kUnexpectedExitStatus);
-      break;
     }
   }
 }