3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-29 08:39:44 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/util/util.gyp

461 lines
16 KiB
Plaintext
Raw Normal View History

Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
# Copyright 2014 The Crashpad Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
{
Set the chromium_code GYP variable. When building in the Chromium tree, chromium_code is necessary to apply Chromium’s build/filename_rules.gypi. Crashpad’s build depends on these rules. chromium_code also enables a high warning level, which is desirable for Crashpad. BUG=crashpad:12 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/986873002
2015-03-08 15:17:22 -04:00
'includes': [
'../build/crashpad.gypi',
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'targets': [
{
Set target_name on many targets to use a crashpad_ prefix. In Chromium, many targets are built, sharing a single output directory. Collisions are likely. When integrating Crashpad into Chromium, the ui/snapshot library and Crashpad’s snapshot library were found to conflict. This change gives most Crashpad targets a “crashpad_” prefix to avoid conflicts. All library and test targets are given a target_name with this prefix. Existing tools are not likely to conflict with anything else and are not given a prefix. BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/990553003
2015-03-08 16:25:34 -04:00
'target_name': 'crashpad_util',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'type': 'static_library',
'dependencies': [
Set target_name on many targets to use a crashpad_ prefix. In Chromium, many targets are built, sharing a single output directory. Collisions are likely. When integrating Crashpad into Chromium, the ui/snapshot library and Crashpad’s snapshot library were found to conflict. This change gives most Crashpad targets a “crashpad_” prefix to avoid conflicts. All library and test targets are given a target_name with this prefix. Existing tools are not likely to conflict with anything else and are not given a prefix. BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/990553003
2015-03-08 16:25:34 -04:00
'../compat/compat.gyp:crashpad_compat',
Allow Crashpad to build in the Chromium tree. When building in the Chromium tree, this swaps out Crashpad’s copies of mini_chromium, gtest, and gmock for the equivalents provided by Chromium. A GYP variable, crashpad_in_chromium, is used to determine the behavior. gclient doesn’t sync sub-DEPS, so when doing an in-Chromium build, Crashpad’s copies of mini_chromium, gtest, and gmock are not available. BUG=crashpad:12 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/986033002
2015-03-09 15:25:42 -04:00
'../third_party/mini_chromium/mini_chromium.gyp:base',
Use zlib to gzip-compress uploads This adds zlib to Crashpad. By default in standalone Crashpad builds, the system zlib will be used where available. A copy of Chromium’s zlib (currently a slightly patched 1.2.11) is checked out via DEPS into third_party for use on Windows, which does not have a system zlib. zlib is used to produce gzip streams for HTTP upload request bodies sent by crashpad_handler by default. The Content-Encoding: gzip header is set for these compressed request bodies. Compression can be disabled for upload to servers without corresponding decompression support by starting crashpad_handler with the --no-upload-gzip option. Most minidumps compress quite well with zlib. A size reduction of 90% is not uncommon. BUG=crashpad:157 TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.* Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513 Reviewed-on: https://chromium-review.googlesource.com/438585 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-15 19:54:19 -05:00
'../third_party/zlib/zlib.gyp:zlib',
linux: add wrappers for send/recvmsg sendmsg() and recvmsg() are complicated to use. Refactor their usage into functions with a simpler, tested interface and use those instead. This also adds CreateCredentialSocketpair() to create a pair of connected sockets with SO_PASSCRED set. This option should be set before the possibility of any calls to sendmsg() with the socket pair to avoid race conditions in properly setting credentials. Also update the handler to use Strategy::kNoPtrace (which causes the crash dump to fail without breaking the socket connection) if the credentials were invalid, which can happen if SO_PASSCRED was set after the call to sendmsg() or if the sending process does not exist in this namespace. Change-Id: Id09f87125540255687a3c35d5bed7fa01ec07cff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1584639 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-05-02 13:55:08 -07:00
'../third_party/lss/lss.gyp:lss',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
],
android: fix the gyp build Change-Id: Ic54fd61258f4ea5b3aaa83a252faa0053ca1f552 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2062773 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-02-18 11:09:00 -08:00
'defines': [ 'ZLIB_CONST' ],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'include_dirs': [
'..',
'<(INTERMEDIATE_DIR)',
],
'sources': [
Add DelimitedFileReader and use it in Linux/Android’s ProcessInfo This implements a non-stdio-based getline() equivalent. getline() is not in the Android NDK until API 21 (Android 5.0.0), while Chrome builds for 32-bit platforms with API 16 (Android 4.1.0). Although a getline() declaration could be provided in compat for use with older NDK headers, it’s desirable to move away from stdio entirely. The C++ DelimitedFileReader interface is also a bit more comfortable to use than getline(). A getdelim() equivalent is also provided, and is also used in the Linux/Android ProcessInfo implementation. Bug: crashpad:30 Test: crashpad_util_test FileLineReader.*:ProcessInfo.* Change-Id: Ic1664758a87cfe4953ab22bd3ae190761404b22c Reviewed-on: https://chromium-review.googlesource.com/455998 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-03-16 10:52:27 -04:00
'file/delimited_file_reader.cc',
'file/delimited_file_reader.h',
Add DirectoryReader to iterate over files in a directory This change also adds functions to create directories, remove files and directories, and check for the existence of files and directories. Change-Id: I62b78219ae2b277d6976d2d90ec86fcabd0ef073 Reviewed-on: https://chromium-review.googlesource.com/696132 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-16 12:31:13 -07:00
'file/directory_reader.h',
'file/directory_reader_posix.cc',
'file/directory_reader_win.cc',
win,linux: implement attachments support Implemented the AddAttachment(), InitializeAttachments(), CleanDatabase() functions on Windows. Added attachment=FILE_NAME option to the handler, and "attachments" argument for Windows and Linux to StartHandler function. On crash it will create the corresponding attachments in the database and copy content of the specified files to the database. Bug: b/157144387 Change-Id: Ia238de39028e07112a7b971b5b7d5e71a5864f53 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2248099 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2020-06-24 09:03:47 +02:00
'file/file_helper.cc',
'file/file_helper.h',
Cross platform low level file IO wrappers Rename fd_io to file_io, and ReadFD to ReadFile, etc. file_io.cc is the higher level versions that call the basic ReadFile/WriteFile and then file_io_posix.cc and file_io_win.cc are the implementations of those functions. The Windows path is as yet untested, lacking the ability to link the test binary. R=cpu@chromium.org, mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/811823003
2014-12-17 14:35:18 -08:00
'file/file_io.cc',
'file/file_io.h',
'file/file_io_posix.cc',
'file/file_io_win.cc',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/file_reader.cc',
'file/file_reader.h',
Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet(). These methods perform common error checking. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/913223008
2015-02-18 18:22:39 -05:00
'file/file_seeker.cc',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/file_seeker.h',
Add DirectoryReader to iterate over files in a directory This change also adds functions to create directories, remove files and directories, and check for the existence of files and directories. Change-Id: I62b78219ae2b277d6976d2d90ec86fcabd0ef073 Reviewed-on: https://chromium-review.googlesource.com/696132 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-16 12:31:13 -07:00
'file/filesystem.h',
'file/filesystem_posix.cc',
'file/filesystem_win.cc',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'file/file_writer.cc',
'file/file_writer.h',
android: fix the gyp build Change-Id: Ic54fd61258f4ea5b3aaa83a252faa0053ca1f552 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2062773 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-02-18 11:09:00 -08:00
'file/output_stream_file_writer.cc',
'file/output_stream_file_writer.h',
Add ScopedRemoveFile to call LoggingRemoveFile for a FilePath Change-Id: Iea3c6d54f35fb67811732af9e17c03b24b189d7b Reviewed-on: https://chromium-review.googlesource.com/721076 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-16 17:08:10 -07:00
'file/scoped_remove_file.cc',
'file/scoped_remove_file.h',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/string_file.cc',
'file/string_file.h',
linux: Add ProcessMemory which reads another process' memory Provides Read, ReadCString, and ReadCStringSizeLimited. Does not provide ReadMapped because Linux does not support mmap on /proc/pid/mem. Bug: crashpad:30 Change-Id: Ia319c0107b1f138aeb8e5d0ee480c77310df7202 Reviewed-on: https://chromium-review.googlesource.com/459700 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2017-04-03 14:09:58 -07:00
'linux/address_types.h',
linux: Add AuxiliaryVector for reading other process' aux vectors Bug: crashpad:30 Change-Id: Ief19be7d60decb17f159b3d740ac9d15a034b807 Reviewed-on: https://chromium-review.googlesource.com/526533 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-06-12 12:59:27 -07:00
'linux/auxiliary_vector.cc',
'linux/auxiliary_vector.h',
linux: Add CheckedLinuxAddressRange and make CheckedAddressRanges copyable Bug: crashpad:30 Change-Id: Ied2b8659315c09c77054c0a5a82ac37284f27334 Reviewed-on: https://chromium-review.googlesource.com/481036 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-04-19 13:45:41 -07:00
'linux/checked_address_range.h',
linux: Refactor `ptrace` usage. 1) Add PtraceConnection which serves as the base class for specific types of connections Crashpad uses to trace processes. 2) Add DirectPtraceConnection which is used when the handler process has `ptrace` capabilities for the target process. 3) Move `ptrace` logic into Ptracer. This class isolates `ptrace` call logic for use by various PtraceConnection implementations. Bug: crashpad:30 Change-Id: I98083134a9f7d9f085e4cc816d2b85ffd6d73162 Reviewed-on: https://chromium-review.googlesource.com/671659 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Leonard Mosescu <mosescu@chromium.org>
2017-09-22 09:14:52 -07:00
'linux/direct_ptrace_connection.cc',
'linux/direct_ptrace_connection.h',
linux: Add ExceptionHandlerServer and ExceptionHandlerClient Bug: crashpad:30 Change-Id: I60874a26ccb281144f870df2b4d16c6970a39f6b Reviewed-on: https://chromium-review.googlesource.com/772824 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 12:03:54 -08:00
'linux/exception_handler_client.cc',
'linux/exception_handler_client.h',
android/linux: add a client interface to control sanitization Sanitization is controlled by a SanitizationInformation struct to be read from the client's memory. The address of this struct is either passed in a ClientInformation when the client requests a crash dump, or as a flag to the handler --sanitization_information. Bug: crashpad:30 Change-Id: I2744f8fb85b4fea7362b2b88faa4bef1da74e36b Reviewed-on: https://chromium-review.googlesource.com/1083143 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-12 08:30:36 -07:00
'linux/exception_handler_protocol.cc',
linux: Add ExceptionHandlerServer and ExceptionHandlerClient Bug: crashpad:30 Change-Id: I60874a26ccb281144f870df2b4d16c6970a39f6b Reviewed-on: https://chromium-review.googlesource.com/772824 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-19 12:03:54 -08:00
'linux/exception_handler_protocol.h',
'linux/exception_information.h',
android: initialize signal dispositions Bionic installs signal handlers which request crash dumps from Android's debuggerd, but there are errors in how signals which aren't automatically re-raised are handled on Marshmallow (API 23). Before requesting a dump, Bionic acquires a lock to communicate with debuggerd and expecting imminent death, never releases it. While handling the dump request, debuggerd allows the dying process to continue before ptrace-detaching it. So, when Bionic manually re-raises a signal, it is intercepted by debuggerd and the dying process is allowed to live. Bionic restores SIG_DFL for the signal it's just handled, but if a different crash signal is later recieved, Bionic attempts to reacquire the lock to communicate with debuggerd and blocks forever. Disable Bionic's signal handlers for these signals on Marshmallow. Bug: chromium:1050178 Change-Id: Ia1fc5a24161a95931684d092ba8fee2f0dfbbdbb Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2134513 Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-04-08 09:56:20 -07:00
'linux/initial_signal_dispositions.cc',
'linux/initial_signal_dispositions.h',
linux: Add MemoryMap to collect information about mapped memory regions Bug: crashpad:30 Change-Id: Id11d549829bd1a956d31991d4b829a43ce5696aa Reviewed-on: https://chromium-review.googlesource.com/477597 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-04-25 08:12:49 -07:00
'linux/memory_map.cc',
'linux/memory_map.h',
linux: Sort alphabetically in util .gyp files Bug: crashpad:30 Change-Id: Iea992cd9eef1029c046cb354f7c1c0173b6f0675 Reviewed-on: https://chromium-review.googlesource.com/583767 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-07-24 14:45:39 -04:00
'linux/proc_stat_reader.cc',
'linux/proc_stat_reader.h',
linux: support multi client sockets in ExceptionHandlerServer Multi client socket connections allow multiple clients to request crash dumps from a handler process using a single, shared socket connection. This connection mode does not support using a broker process which requires a dedicated socket connection to ensure handler messages aren't intercepted by the wrong clients. The handler uses SIGCONT to indicate to the crasher when a crash dump is complete (or has failed) and may continue. Bug: crashpad:284 Change-Id: I2031029cd254f17497cbf7e7d8740c289581e8aa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1559306 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-29 14:28:53 -07:00
'linux/proc_task_reader.cc',
'linux/proc_task_reader.h',
linux: Add PtraceBroker and PtraceClient A PtraceBroker/Client pair implement a PtraceConnection over a socket. The broker runs in a process with `ptrace` capabilities for the target process and serves requests for the client over a socket. Bug: crashpad:30 Change-Id: Ied19bcedf84b46c8f68440fd1c284b2126470e5e Reviewed-on: https://chromium-review.googlesource.com/780397 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-12-11 10:23:17 -08:00
'linux/ptrace_broker.cc',
'linux/ptrace_broker.h',
'linux/ptrace_client.cc',
'linux/ptrace_client.h'
linux: Refactor `ptrace` usage. 1) Add PtraceConnection which serves as the base class for specific types of connections Crashpad uses to trace processes. 2) Add DirectPtraceConnection which is used when the handler process has `ptrace` capabilities for the target process. 3) Move `ptrace` logic into Ptracer. This class isolates `ptrace` call logic for use by various PtraceConnection implementations. Bug: crashpad:30 Change-Id: I98083134a9f7d9f085e4cc816d2b85ffd6d73162 Reviewed-on: https://chromium-review.googlesource.com/671659 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Leonard Mosescu <mosescu@chromium.org>
2017-09-22 09:14:52 -07:00
'linux/ptrace_connection.h',
'linux/ptracer.cc',
'linux/ptracer.h',
linux: Add ScopedPrSetDumpable Bug: 914246 Change-Id: I529467e92a5cbc2a372f4c12234cfd3af8ddfe0a Reviewed-on: https://chromium-review.googlesource.com/c/1382598 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-18 09:17:52 -08:00
'linux/scoped_pr_set_dumpable.cc',
'linux/scoped_pr_set_dumpable.h',
linux: Move ScopedPrSetPtracer to util/ CrashpadClient will need ScopedPrSetPtracer when launching a handler process in response to a crash. Bug: crashpad:30 Change-Id: I35bc784b948349ca771f9cd65ef1089e626976bb Reviewed-on: https://chromium-review.googlesource.com/927352 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-20 13:07:16 -08:00
'linux/scoped_pr_set_ptracer.cc',
'linux/scoped_pr_set_ptracer.h',
linux: Add ScopedPtraceAttach to manage ptrace attachments Bug: crashpad:30 Change-Id: Ic5fb5adaaea88e31068b65a3c0dfff65a2a94743 Reviewed-on: https://chromium-review.googlesource.com/470331 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-04-07 11:48:04 -07:00
'linux/scoped_ptrace_attach.cc',
'linux/scoped_ptrace_attach.h',
linux: add wrappers for send/recvmsg sendmsg() and recvmsg() are complicated to use. Refactor their usage into functions with a simpler, tested interface and use those instead. This also adds CreateCredentialSocketpair() to create a pair of connected sockets with SO_PASSCRED set. This option should be set before the possibility of any calls to sendmsg() with the socket pair to avoid race conditions in properly setting credentials. Also update the handler to use Strategy::kNoPtrace (which causes the crash dump to fail without breaking the socket connection) if the credentials were invalid, which can happen if SO_PASSCRED was set after the call to sendmsg() or if the sending process does not exist in this namespace. Change-Id: Id09f87125540255687a3c35d5bed7fa01ec07cff Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1584639 Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-05-02 13:55:08 -07:00
'linux/socket.cc',
'linux/socket.h',
linux: Sort alphabetically in util .gyp files Bug: crashpad:30 Change-Id: Iea992cd9eef1029c046cb354f7c1c0173b6f0675 Reviewed-on: https://chromium-review.googlesource.com/583767 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-07-24 14:45:39 -04:00
'linux/thread_info.cc',
'linux/thread_info.h',
linux: Add ExceptionSnapshotLinux Bug: crashpad:30 Change-Id: I450d53a89af2995c0fd13b31821360e781fe015a Reviewed-on: https://chromium-review.googlesource.com/589747 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-08-01 19:05:06 -07:00
'linux/traits.h',
Add CheckedMachAddressRange and its test. TEST=util_test CheckedMachAddressRange.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/513453002
2014-08-28 13:47:28 -04:00
'mac/checked_mach_address_range.h',
Revert "Drop 10.5 support: use ServiceManagement.framework directly." This reverts commit 63fd3ae47d2513ef4390c3d8c0dde3fa95152480. SMJobRemove() still performs a 1-second sleep() when its |wait| parameter is true. Radar 18398683 is filed. In the mean time, the launchd-based implementation of these functions does not have this undesirable property. The comments have been revised to not reflect operating systems before Mac OS X 10.6. Comments describing bugs in earlier 10.10 seeds that have since been fixed have been removed. TEST=util_test Launchd.*:ServiceManagement.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/579083003
2014-09-22 13:11:40 -04:00
'mac/launchd.h',
'mac/launchd.mm',
Add mac_util, including MacOSXMinorVersion(), MacOSXVersion(), and MacModelAndBoard(), along with their tests. TEST=util_test MacUtil.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/473023002
2014-08-15 22:33:14 -07:00
'mac/mac_util.cc',
'mac/mac_util.h',
Add ServiceManagement*() and their tests. TEST=util_test ServiceManagement R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467923003
2014-08-15 22:30:24 -07:00
'mac/service_management.cc',
'mac/service_management.h',
mac: Replace MacOSXMinorVersion with MacOSVersionNumber MacOSXMinorVersion reported just the “y” value for an OS version 10.y.z. This is no longer sufficient to identify OS versions accurately in macOS 11. A new MacOSVersionNumber function reports the full OS version as “xxyyzz” for an OS version x.y.z. This is the same format used by <Availability.h> __MAC_* macros since 10.10. MacOSXVersion is also renamed to MacOSVersionComponents for disambiguation and proper modern nomenclature. Bug: crashpad:347 Test: crashpad_snapshot_test SystemSnapshotMacTest.OSVersion, crashpad_util_test MacUtil.MacOSVersionNumber Change-Id: I66421954f021c0627095474cb26359970fcd9101 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2386386 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2020-09-01 17:09:37 -04:00
'mac/sysctl.cc',
'mac/sysctl.h',
Add wrappers around getxattr() and setxattr(). R=mark@chromium.org TEST=util_test --gtest_filter=Xattr.* Review URL: https://codereview.chromium.org/791493009
2014-12-30 17:39:27 -05:00
'mac/xattr.cc',
'mac/xattr.h',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'mach/child_port.defs',
Add ChildPortHandshake and its test. ChildPortHandshake is the most generic system yet to allow child processes to provide their parents with Mach rights. These are ordinarily expected to be send rights to the children’s own task ports, or send rights to servers that the children hold receive rights to. This updates DEPS to pull mini_chromium 1d3523dbda93, which includes base::mac::ScopedMachPortSet. TEST=util_test ChildPortHandshake.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/756603003
2014-11-25 14:56:05 -05:00
'mach/child_port_handshake.cc',
'mach/child_port_handshake.h',
Add ChildPortServer, a MachMessageServer::Interface implementation for the child_port subsystem. Common routines shared with the ExcServer family of classes have been moved to a new file, where they can be shared between different MachMessageServer::Interface implementations. TEST=util_test ChildPortServer.*:MachMessageUtil.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/754123002
2014-11-25 14:29:46 -05:00
'mach/child_port_server.cc',
'mach/child_port_server.h',
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
'mach/child_port_types.h',
Add CompositeMachMessageServer and its test. TEST=util_test CompositeMachMessageServer* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/781823002
2014-12-04 16:45:02 -05:00
'mach/composite_mach_message_server.cc',
'mach/composite_mach_message_server.h',
Add exc_client_variants (UniversalExceptionRaise()) and its test. This also puts kMachExceptionCodes into mach_extensions.h, because a form of MACH_EXCEPTION_CODES that’s the right type (exception_behavior_t) has now shown its use in more than one file. TEST=util_test ExcClientVariants.UniversalExceptionRaise R=rsesek@chromium.org Review URL: https://codereview.chromium.org/567283002
2014-09-16 09:48:01 -04:00
'mach/exc_client_variants.cc',
'mach/exc_client_variants.h',
Add exc_server_variants including UniversalMachExcServer and its test. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/545053003
2014-09-10 17:29:07 -04:00
'mach/exc_server_variants.cc',
'mach/exc_server_variants.h',
Add exception_behaviors and its test. This includes the functions ExceptionBehaviorHasState(), ExceptionBehaviorHasIdentity(), ExceptionBehaviorHasMachExceptionCodes(), and ExceptionBehaviorBasic(). TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565793005
2014-09-16 17:32:35 -04:00
'mach/exception_behaviors.cc',
'mach/exception_behaviors.h',
Add ExceptionPorts and its test. This is a unified interface to {thread,task,host}_{get,set}_exception_ports(). TEST=util_test ExceptionPorts.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/549023005
2014-09-16 17:36:33 -04:00
'mach/exception_ports.cc',
'mach/exception_ports.h',
Accept non-fatal resource exceptions without generating crash reports. This adds IsExceptionNonfatalResource() and its test, and uses it in crashpad_handler. When non-fatal resource exceptions are encountered, no crash report is generated. crashpad_handler swallows these exceptions. Alternatively, it could allow them to be sent to the system’s host-level resource exception handler, normally com.apple.ReportCrash.root, which would allow them to be processed in the same way as when Crashpad is not in use. I’m not sure which option is better. I chose to swallow them because there doesn’t appear to be much value in letting com.apple.ReportCrash.root and spindump look at them. This also moves ExcCrashRecoverOriginalException() to the new file as a sibling of IsExceptionNonfatalResource(). This provides better organization. BUG=crashpad:35, chromium:474163, chromium:474326 TEST=crashpad_util_test ExceptionTypes.IsExceptionNonfatalResource R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1066243002
2015-04-08 17:46:09 -04:00
'mach/exception_types.cc',
'mach/exception_types.h',
Add exc_client_variants (UniversalExceptionRaise()) and its test. This also puts kMachExceptionCodes into mach_extensions.h, because a form of MACH_EXCEPTION_CODES that’s the right type (exception_behavior_t) has now shown its use in more than one file. TEST=util_test ExcClientVariants.UniversalExceptionRaise R=rsesek@chromium.org Review URL: https://codereview.chromium.org/567283002
2014-09-16 09:48:01 -04:00
'mach/mach_extensions.cc',
Add exc_server_variants including UniversalMachExcServer and its test. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/545053003
2014-09-10 17:29:07 -04:00
'mach/mach_extensions.h',
Move mach_message_util.* to mach_message.*. A subsequent change will add MachMessageWithDeadline(), a mach_msg() wrapper. Conceptually, it makes sense to include that function in this file family. Since this file family now contains a mach_msg() wrapper, it makes sense to rename it mach_message and lose the _util suffix. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/772133004
2014-12-02 17:02:32 -05:00
'mach/mach_message.cc',
'mach/mach_message.h',
Add MachMessageServer and its test. MachMessageServer is much like mach_msg_server() and mach_msg_server_once(), but with a C++ interface and with a number of deficiencies corrected. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/544393002
2014-09-08 21:06:34 -04:00
'mach/mach_message_server.cc',
'mach/mach_message_server.h',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'mach/notify_server.cc',
'mach/notify_server.h',
Add ScopedTaskSuspend and its test. This also introduces ScopedFcntlFlags. TEST=util_test ScopedTaskSuspend.*:ScopedFcntlFlags.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/649693002
2014-10-13 18:05:21 -04:00
'mach/scoped_task_suspend.cc',
'mach/scoped_task_suspend.h',
Add SymbolicConstantsMach and its test. TEST=util_test SymbolicConstantsMach.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/563383002
2014-09-16 11:00:51 -04:00
'mach/symbolic_constants_mach.cc',
'mach/symbolic_constants_mach.h',
Add TaskForPID(). This also transitions exception_port_tool to use TaskForPID(), so that it can be safely used as a setuid executable without giving permission to operate on any process on the system. It is difficult to provide a test for this function, because it must be running setuid root in order to do anything interesting. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/728973002
2014-11-14 17:56:17 -05:00
'mach/task_for_pid.cc',
'mach/task_for_pid.h',
Use ADDRESS_SANITIZER instead of __has_feature(address_sanitizer) __has_feature() is a Clang-ism not implemented by GCC. base/compiler_specific.h provides a HAS_FEATURE() macro that always returns 0 when __has_feature() is not implemented. Use this macro for compatibility with GCC and other compilers that do not implement this Clang extension. http://clang.llvm.org/docs/LanguageExtensions.html#has-feature-and-has-extension For GCC’s Address Sanitizer implementation, test the __SANITIZE_ADDRESS__ macro that it provides as an alternative to __has_feature(address_sanitizer). Note that in Chrome builds, ADDRESS_SANITIZER is pushed in by the build system. The definition of ADDRESS_SANITIZER provides another way for that macro to be set. It’s supplementary, not exclusive. https://chromium.googlesource.com/chromium/src/+/cb33b243721b0e7dbdfa8c4301702e319360e88d/build/config/BUILD.gn#118 BUG=crashpad:30 Change-Id: I5c3145d29bbc966925369c03a37b1ecb5622a004 Reviewed-on: https://chromium-review.googlesource.com/413109 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-11-22 14:27:51 -05:00
'misc/address_sanitizer.h',
Add generic VMAddress-related types This will allow sharing code that is currently hard-coded to use (e.g.) LinuxVMAddress or mach_vm_size_t. Change-Id: I7bf20600c73d4ec7d2a029754f9043a236a38e5a Reviewed-on: https://chromium-review.googlesource.com/677142 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Dave Bort <dbort@google.com>
2017-09-12 16:39:53 -07:00
'misc/address_types.h',
Remove base's arraysize from Crashpad. BUG=837308 R=mark@chromium.org Change-Id: Ibecbfc7bc2d61ee54bc1114e4b20978adbc77db2 Reviewed-on: https://chromium-review.googlesource.com/c/1393921 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org>
2019-01-03 13:36:02 -05:00
'misc/arraysize.h',
Add DirectoryReader to iterate over files in a directory This change also adds functions to create directories, remove files and directories, and check for the existence of files and directories. Change-Id: I62b78219ae2b277d6976d2d90ec86fcabd0ef073 Reviewed-on: https://chromium-review.googlesource.com/696132 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-16 12:31:13 -07:00
'misc/as_underlying_type.h',
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
'misc/capture_context.h',
'misc/capture_context_linux.S',
'misc/capture_context_mac.S',
'misc/capture_context_win.asm',
Add, test, and use clock utilities. This includes ClockMonotonicNanoseconds() and SleepNanoseconds(). SleepNanoseconds() is like base::PlatformThread::Sleep(), but PlatformThread is not in mini_chromium and I’m not keen on adding it because I’m not sold on the interface. I’m not convinced Sleep() belongs there, and I don’t want to have to bring all of base::Time* along for the ride. TEST=util_test Clock.*:MachMessageServer.*:ServiceManagement.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/597533002
2014-09-24 14:08:48 -04:00
'misc/clock.h',
'misc/clock_mac.cc',
win: clock implementation R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/807973002
2014-12-17 10:45:43 -08:00
'misc/clock_posix.cc',
'misc/clock_win.cc',
Get CrashpadInfo address via a .note, rather than dynamic symtab Embeds the address of g_crashpad_info into a .note section (which is readable by the generic code to read notes in ElfImageReader). Unfortunately because the note section is in libclient.a, it would normally be dropped at link time. To avoid that, GetCrashpadInfo() has a reference *back* to that section, which in turn forces the linker to include it, allowing the note reader to find it at runtime. Previously, it was necessary to have the embedder of "client" figure out how to cause `g_crashpad_info` to appear in the final module's dynamic symbol table. With this new approach, there's no manual configuration necessary, as it's not necessary for the symbol to be exported. This is currently only implemented in the Linux module reader (and I believe the current set of enabled tests aren't exercising it?) but it will also be done this way for the Fuchsia implementation of ModuleSnapshot. Bug: crashpad:196 Change-Id: I599db5903bc98303130d11ad850ba9ceed3b801a Reviewed-on: https://chromium-review.googlesource.com/912284 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-02-15 10:38:36 -08:00
'misc/elf_note_types.h',
Introduce FromPointerCast<>(), with defined sign/zero-extension behavior Some of the new Linux/Android tests were failing in 32-bit code where pointers were being casted via reinterpret_cast<>() to LinuxVMAddress, an unsigned 64-bit type. The behavior of such casts is implementation-defined, and in this case, sign-extension was being used to convert the 32-bit pointers to 64 bits, resulting in very large (unsigned) LinuxVMAddress values that could not possibly refer to proper addresses in a 32-bit process’ address space. The offending reinterpret_cast<>() conversions have been replaced with the new FromPointerCast<>(), which is careful to do sign-extension when converting to a signed type, and zero-extension when converting to an unsigned type like LinuxVMAddress. Bug: crashpad:30 Test: crashpad_util_test FromPointerCast*:MemoryMap.*:ProcessMemory.* Change-Id: I6f1408dc63369a8740ecd6015d657e4407a7c271 Reviewed-on: https://chromium-review.googlesource.com/488264 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-04-27 15:08:17 -04:00
'misc/from_pointer_cast.h',
Replace implicit_cast usage with static_cast. chromium's implicit_cast is going to be removed so stop using it. BUG=529769,472900 R=mark@chromium.org Review URL: https://codereview.chromium.org/1335353002 .
2015-09-14 11:09:46 -07:00
'misc/implicit_cast.h',
Add InitializationStateDcheck, its base class, and their tests. TEST=util_test InitializationState* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/465103002
2014-08-14 09:51:26 -07:00
'misc/initialization_state.h',
'misc/initialization_state_dcheck.cc',
'misc/initialization_state_dcheck.h',
linux: Refactor reading start time from the stat file Bug: crashpad:30 Change-Id: Ie8137db2a5b6f2d4947df108d1fb5bdd9f8ab391 Reviewed-on: https://chromium-review.googlesource.com/580448 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-07-24 10:55:02 -07:00
'misc/lexing.cc',
'misc/lexing.h',
Pull metrics instrumentation out to central file Solves two problems with having the macros inline: 1. Deduplicates some of the logic (in this case, the name of the histogram, and whether it should be divided by 1024); 2. More useful check for compilation. As the macros are no-ops in Crashpad, it was easy to use the wrong name for a variable in the arguments to the macros (see .mm!) This way, we have some better chance of at least having code that compiles when built in Chromium if all the arguments are passed to Metrics::Something() in a standalone build. Also rolls mini_chromium DEPS to include: 99213eb Mark histogram arguments as unused to avoid warnings R=mark@chromium.org BUG=crashpad:100 Change-Id: I9f7fc3b85854fd61c1ebdf0084d728a7b690c2f1 Reviewed-on: https://chromium-review.googlesource.com/380445 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-02 12:10:57 -07:00
'misc/metrics.cc',
'misc/metrics.h',
“Promote” test::Paths::Executable() to Paths::Executable() This supports the “double handler” or “double handler with low probability” models from https://crashpad.chromium.org/bug/143. For crashpad_handler to be become its own client, it needs access to its own executable path to pass to CrashpadClient::StartHandler(). This was formerly available in the test-only test::Paths::Executable(). Bring that function’s implementation to the non-test Paths::Executable() in util/misc, and rename test::Paths to test::TestPaths to avoid future confusion. test::TestPaths must still be used to access TestDataRoot(), which does not make any sense to non-test code. test::TestPaths::Executable() is retained for use by tests, which most likely prefer the fatal semantics of that function. Paths::Executable() is not fatal because for the purposes of implementing the double handler, a failure to locate the executable path (which may happen on some systems in deeply-nested directory hierarchies) shouldn’t cause the initial crashpad_handler to abort, even if it does prevent a second crashpad_handler from being started. Bug: crashpad:143 Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.* Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156 Reviewed-on: https://chromium-review.googlesource.com/466346 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-04-03 13:53:11 -04:00
'misc/paths.h',
'misc/paths_mac.cc',
'misc/paths_linux.cc',
'misc/paths_win.cc',
Implement ModuleSnapshotWin::UUID Reads CodeView PDB GUID from Debug Directory of PE header. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1311003003 .
2015-09-01 09:32:09 -07:00
'misc/pdb_structures.cc',
'misc/pdb_structures.h',
Add RandomString() and its test, and use it everywhere it makes sense This unifies several things that used a 16-character random string, and a few other users of random identifiers where it also made sense to use a 16-character random string. TEST=crashpad_util_test RandomString.RandomString R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1451793002 .
2015-11-16 13:39:01 -05:00
'misc/random_string.cc',
'misc/random_string.h',
Add ProcessSnapshotSanitized A ProcessSnapshotSanitized enables filtering possibly sensitive information from a snapshot. WebView has different privacy constraints than Chrome and needs to avoid collecting data in annotations or from stack memory that may contain PII. This CL enables: 1. Filtering annotations by name using a whitelist. 2. Filtering for crashes which reference a particular module. 3. Redacting non-essential information from stack memory. This CL does not provide a client interface to enable sanitization. Bug: crashpad:30 Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254 Reviewed-on: https://chromium-review.googlesource.com/1070472 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
2018-06-11 09:38:24 -07:00
'misc/range_set.cc',
'misc/range_set.h',
Add ReinterpretBytes which does a checked, variable size bit cast This renames and improves the VariableSizeBitCast helper from util/linux/auxiliary_vector.* and moves it to misc. Change-Id: I4bf46f4cfc0e60c900ff9bde467a21ad43c684cd Reviewed-on: https://chromium-review.googlesource.com/534174 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-06-19 15:56:07 -07:00
'misc/reinterpret_bytes.cc',
'misc/reinterpret_bytes.h',
Add ScopedForbidReturn and its test. Use ScopedForbidReturn in ProcessReader::InitializeThreads(). TEST=util_test ScopedForbidReturn*.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/493203005
2014-08-26 16:50:08 -04:00
'misc/scoped_forbid_return.cc',
'misc/scoped_forbid_return.h',
Add symbolic_constants_posix and its test. This includes the functions SignalToString() and StringToSignal(). TEST=util_test SymbolicConstantsPOSIX.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565453002
2014-09-10 17:30:21 -04:00
'misc/symbolic_constants_common.h',
Move win/time to misc/time and add more conversion functions This CL pulls together similar time conversion functions and adds conversions between `FILETIME`s and `timespec`s. Bug: crashpad:206 Change-Id: I1d9b1560884ffde2364af0092114f82e1534ad1c Reviewed-on: https://chromium-review.googlesource.com/752574 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-11-06 14:01:04 -08:00
'misc/time.cc',
'misc/time.h',
linux: fix proc stat reader flakiness ProcStatReader.Threads is flaky because it relies on an internal, imprecise measurement of boot time. The flaky test asserts that a thread started after the main thread should have a start time >= the main thread. The start time is returned in a timeval, with microsecond precision, but the measurement of boot time requires two system calls and the time between those system calls can be approximately a microsecond. An unlucky event such as a change in system time could make this imprecision arbitrarily bad. This patch lets the caller of ProcStatReader.StartTime() inject the boot time, allowing ProcStatReader to guarantee that threads have correctly ordered time, given the same input boot time. Bug: 1016765 Change-Id: I6e4a944a1d58c3916090bab6a4b99573e71a89fc Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1891588 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2019-11-06 10:00:13 -08:00
'misc/time_linux.cc',
Move win/time to misc/time and add more conversion functions This CL pulls together similar time conversion functions and adds conversions between `FILETIME`s and `timespec`s. Bug: crashpad:206 Change-Id: I1d9b1560884ffde2364af0092114f82e1534ad1c Reviewed-on: https://chromium-review.googlesource.com/752574 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-11-06 14:01:04 -08:00
'misc/time_win.cc',
Allow exception forwarding to the system’s native crash reporter to be disabled. ClientInfo::set_system_crash_reporter_forwarding() can be used to disable forwarding. The first module that is found with a non-default value in this field will dictate whether forwarding is enabled or disabled. It is possible to enable or disable reporting with this call, as well as reset it to default, which will allow later modules a chance to influence the behavior. ClientInfo::set_crashpad_handler_behavior() is also provided, which can be used to disable Crashpad’s handling of the exception. Most users should not call this, but should use Settings::SetUploadsEnabled() instead. TEST=crashpad_snapshot_test \ CrashpadInfoClientOptions.*:MachOImageReader.Self_DyldImages; \ run_with_crashpad --handler crashpad_handler \ -a --database=/tmp/crashpad_db \ -a --url=https://clients2.google.com/cr/staging_report \ -a --annotation=prod=crashpad \ -a --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Review URL: https://codereview.chromium.org/997713002
2015-03-11 17:07:11 -04:00
'misc/tri_state.h',
Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/430003003
2014-08-01 14:39:55 -04:00
'misc/uuid.cc',
'misc/uuid.h',
Use zlib to gzip-compress uploads This adds zlib to Crashpad. By default in standalone Crashpad builds, the system zlib will be used where available. A copy of Chromium’s zlib (currently a slightly patched 1.2.11) is checked out via DEPS into third_party for use on Windows, which does not have a system zlib. zlib is used to produce gzip streams for HTTP upload request bodies sent by crashpad_handler by default. The Content-Encoding: gzip header is set for these compressed request bodies. Compression can be disabled for upload to servers without corresponding decompression support by starting crashpad_handler with the --no-upload-gzip option. Most minidumps compress quite well with zlib. A size reduction of 90% is not uncommon. BUG=crashpad:157 TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.* Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513 Reviewed-on: https://chromium-review.googlesource.com/438585 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-15 19:54:19 -05:00
'misc/zlib.cc',
'misc/zlib.h',
Add HTTPBodyStream interface, three concrete implementations, and their tests. BUG=415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/669153006
2014-10-24 15:04:25 -04:00
'net/http_body.cc',
'net/http_body.h',
Use zlib to gzip-compress uploads This adds zlib to Crashpad. By default in standalone Crashpad builds, the system zlib will be used where available. A copy of Chromium’s zlib (currently a slightly patched 1.2.11) is checked out via DEPS into third_party for use on Windows, which does not have a system zlib. zlib is used to produce gzip streams for HTTP upload request bodies sent by crashpad_handler by default. The Content-Encoding: gzip header is set for these compressed request bodies. Compression can be disabled for upload to servers without corresponding decompression support by starting crashpad_handler with the --no-upload-gzip option. Most minidumps compress quite well with zlib. A size reduction of 90% is not uncommon. BUG=crashpad:157 TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.* Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513 Reviewed-on: https://chromium-review.googlesource.com/438585 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-15 19:54:19 -05:00
'net/http_body_gzip.cc',
'net/http_body_gzip.h',
Add HTTPTransport, a Mac implementation, and an end-to-end test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/692963002
2014-10-31 12:17:32 -04:00
'net/http_headers.h',
Add HTTPMultipartBuilder and its test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/681303003
2014-10-29 19:13:24 -04:00
'net/http_multipart_builder.cc',
'net/http_multipart_builder.h',
Add HTTPTransport, a Mac implementation, and an end-to-end test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/692963002
2014-10-31 12:17:32 -04:00
'net/http_transport.cc',
'net/http_transport.h',
'net/http_transport_mac.mm',
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
'net/http_transport_win.cc',
net: Identify clients via URL parameters during report upload During crash report upload, the client now provides the product name, version, and client id via URL parameters to the crash reporting service. Also added percent-encoding function and a test. Change-Id: I62f3a646d4ab6029543bd80938b79de28b1f20e4 Test: crashpad_util_test URLEncode.Empty Test: crashpad_util_test URLEncode.ReservedCharacters Test: crashpad_util_test URLEncode.UnreservedCharacters Test: crashpad_util_test URLEncode.SimpleAddress Reviewed-on: https://chromium-review.googlesource.com/493917 Commit-Queue: Roman Margold <rmargold@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-09-28 09:53:39 -07:00
'net/url.cc',
'net/url.h',
win: make CrashpadInfo retrievable The main goal was to get the beginnings of module iteration and retrieval of CrashpadInfo in snapshot. The main change for that is to move crashpad_info_client_options[_test] down out of mac/. This also requires adding some of the supporting code of snapshot in ProcessReaderWin, ProcessSnapshotWin, and ModuleSnapshotWin. These are partially copied from Mac or stubbed out with lots of TODO annotations. This is a bit unfortunate, but seemed like the most productive way to make progress incrementally. That is, it's mostly placeholder at the moment, but hopefully has the right shape for things to come. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1052813002
2015-05-01 13:48:23 -07:00
'numeric/checked_address_range.cc',
'numeric/checked_address_range.h',
Add CheckedRange<> and its test. TEST=util_test CheckedRange R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467113002
2014-08-15 10:22:37 -07:00
'numeric/checked_range.h',
Add generic VMAddress-related types This will allow sharing code that is currently hard-coded to use (e.g.) LinuxVMAddress or mach_vm_size_t. Change-Id: I7bf20600c73d4ec7d2a029754f9043a236a38e5a Reviewed-on: https://chromium-review.googlesource.com/677142 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Dave Bort <dbort@google.com>
2017-09-12 16:39:53 -07:00
'numeric/checked_vm_address_range.h',
Add InRangeCast<> and its test. InRangeCast<> is similar to base::saturated_cast<>, but it allows the caller to specify the value to be returned in the event that the source value can’t be converted to the destination data type without data loss. TEST=util_test InRangeCast R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467103002
2014-08-14 16:00:44 -07:00
'numeric/in_range_cast.h',
Add uint128_struct and its test. This will be used in the upcoming Minidump context structures. This also updates mini_chromium to ba9b15f1b6a7 to pick up: ba9b15f1b6a7 Make bit_cast available in C++11 mode. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/583283003
2014-09-22 15:46:00 -04:00
'numeric/int128.h',
Add InRangeCast<> and its test. InRangeCast<> is similar to base::saturated_cast<>, but it allows the caller to specify the value to be returned in the event that the source value can’t be converted to the destination data type without data loss. TEST=util_test InRangeCast R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467103002
2014-08-14 16:00:44 -07:00
'numeric/safe_assignment.h',
CloseMultipleNowOrOnExec(): promote out of test. This function will be useful in upcoming non-test code. Because the first Crashpad client that wants a Crashpad handler will now be responsible for starting the handler process, this will prevent file descriptors from leaking to the handler process. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/819483002
2014-12-19 16:42:34 -05:00
'posix/close_multiple.cc',
'posix/close_multiple.h',
Add CloseStdinAndStdout(). There will be no reason to leave the handler process connected to its invoker’s stdin or stdout. On the other hand, I’m currently leaving it connected to the original and stderr, as these may be useful for diagnostics. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/818573002
2014-12-19 14:20:20 -05:00
'posix/close_stdio.cc',
'posix/close_stdio.h',
Add DropPrivileges(). DropPrivileges() is used in exception_port_tool, so that when it is installed as a setuid executable, it only uses elevated privileges to obtain a task port for its -p option, and then relinquishes those privileges. It is difficult to provide a test for this function, because it must be running setuid or setgid in order to do anything interesting. However, the function contains its own CHECKs to verify that it behaves properly. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/727053002
2014-11-14 18:44:19 -05:00
'posix/drop_privileges.cc',
'posix/drop_privileges.h',
mac: Tests that crash intentionally shouldn’t go to ReportCrash Crashpad has many tests that crash intentionally. Some of these are gtest death tests, and others arrange for intentional crashes to test Crashpad’s own crash-catching logic. On macOS, all of the gtest death tests and some of the other intentional crashes were being logged by ReportCrash, the system’s crash reporter. Since these reports corresponded to intentional crashes, they were never useful, and served only to clutter ~/Library/Logs/DiagnosticReports. Since Crashpad is adept at handling exceptions on its own, this introduces the “exception swallowing server”, crashpad_exception_swallower, which is a Mach exception server that implements a no-op exception handler routine for all exceptions received. The exception swallowing server is established as the task handler for EXC_CRASH and EXC_CORPSE_NOTIFY exceptions during gtest death tests invoked by {ASSERT,EXPECT}_DEATH_{CHECK,CRASH}, and for all child processes invoked by the Multiprocess test infrastructure. The exception swallowing server is not in effect at other times, so unexpected crashes in test code can still be handled by ReportCrash or another crash reporter. With this change in place, no new reports are generated in the user-level ~/Library/Logs/DiagnosticReports or the system’s /Library/Logs/DiagnosticReports during a run of Crashpad’s full test suite on macOS. Bug: crashpad:33 Change-Id: I13891853a7e25accc30da21fa7ea8bd7d1f3bd2f Reviewed-on: https://chromium-review.googlesource.com/777859 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-20 13:32:26 -05:00
'posix/double_fork_and_exec.cc',
'posix/double_fork_and_exec.h',
Move some parts of ProcessReader (in snapshot) to ProcessInfo (in util). Also, move ProcessArgumentsForPID() into ProcessInfo. This change prepares for a TaskForPID() implementation that’s capable of operating correctly in a setuid root executable. TaskForPID() belongs in util/mach, but for its permission checks, it must access some process properties that were previously fetched by ProcessReader in snapshot. util can’t depend on snapshot. The generic util-safe process information bits (Is64Bit(), ProcessID(), ParentProcessID(), and StartTime()) are moved from ProcessReader to ProcessInfo (in util), where the current ProcessReader can use it (as it’s OK for snapshot to depend on util), and the future TaskForPID() in util can also use it. ProcessInfo also contains other methods that TaskForPID() will use, providing access to the credentials that the target process holds. ProcessArgumentsForPID() is related, and is also now a part of ProcessInfo. TEST=snapshot_test, util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/727973002
2014-11-14 17:54:42 -05:00
'posix/process_info.h',
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
'posix/process_info_linux.cc',
Move some parts of ProcessReader (in snapshot) to ProcessInfo (in util). Also, move ProcessArgumentsForPID() into ProcessInfo. This change prepares for a TaskForPID() implementation that’s capable of operating correctly in a setuid root executable. TaskForPID() belongs in util/mach, but for its permission checks, it must access some process properties that were previously fetched by ProcessReader in snapshot. util can’t depend on snapshot. The generic util-safe process information bits (Is64Bit(), ProcessID(), ParentProcessID(), and StartTime()) are moved from ProcessReader to ProcessInfo (in util), where the current ProcessReader can use it (as it’s OK for snapshot to depend on util), and the future TaskForPID() in util can also use it. ProcessInfo also contains other methods that TaskForPID() will use, providing access to the credentials that the target process holds. ProcessArgumentsForPID() is related, and is also now a part of ProcessInfo. TEST=snapshot_test, util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/727973002
2014-11-14 17:54:42 -05:00
'posix/process_info_mac.cc',
posix: Add ScopedDIR for managing open directories Change-Id: I9f1453db5e33e714c12ebeaaab25813a2b099de8 Reviewed-on: https://chromium-review.googlesource.com/468271 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-04-05 09:42:54 -07:00
'posix/scoped_dir.cc',
'posix/scoped_dir.h',
posix: Add ScopedMmap for managing memory-mapped regions This wraps mmap(), munmap(), and mprotect(). Bug: crashpad:30 Test: crashpad_util_test ScopedMmap.* Change-Id: If14363dfd00e314482cc91e53c7f4e3df737b0d3 Reviewed-on: https://chromium-review.googlesource.com/461361 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-03-28 12:21:43 -04:00
'posix/scoped_mmap.cc',
'posix/scoped_mmap.h',
Add Signals, utilities for signal handling Use these utilities for signal handling in crashpad_handler BUG=crashpad:30 TEST=crashpad_util_test Signals.* Change-Id: I6c9a1de35c4a81b58d77768c4753bdba5ebea4df Reviewed-on: https://chromium-review.googlesource.com/446917 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-01 10:00:59 -05:00
'posix/signals.cc',
'posix/signals.h',
Add symbolic_constants_posix and its test. This includes the functions SignalToString() and StringToSignal(). TEST=util_test SymbolicConstantsPOSIX.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565453002
2014-09-10 17:30:21 -04:00
'posix/symbolic_constants_posix.cc',
'posix/symbolic_constants_posix.h',
Remove pid_t in platform-independent code. Change-Id: Ia58e07bf85a09cd7e63784220800431ad1366584 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1565273 Commit-Queue: Eric Astor <epastor@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-04-24 11:22:35 -04:00
'process/process_id.h',
Add process_memory.cc when using gyp Change-Id: I835b03f1553c04ebc03e3eb1f11455f049342cc5 Reviewed-on: https://chromium-review.googlesource.com/872252 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-01-17 16:59:59 -08:00
'process/process_memory.cc',
Move linux/process files to util/process A step towards making these files usable by non-Linux systems. Bug: crashpad:196 Change-Id: I71323b29e46208b3992055722e4622d79409c44c Reviewed-on: https://chromium-review.googlesource.com/685406 Commit-Queue: Dave Bort <dbort@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-09-26 12:52:41 -07:00
'process/process_memory.h',
Make ProcessMemory an abstract interface Only a Linux implementation for now, but similar code for other OSes can move behind it in the future. Bug: crashpad:196 Change-Id: I05966db1599a9cac3146d2a3d964e7ad8629d616 Reviewed-on: https://chromium-review.googlesource.com/685408 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Dave Bort <dbort@google.com>
2017-10-11 20:01:56 -07:00
'process/process_memory_linux.cc',
'process/process_memory_linux.h',
Move and rename TaskMemory to ProcessMemoryMac Bug: crashpad:263 Change-Id: I5efa4fe26f09c8b8a8db6dbcedc416724404b894 Reviewed-on: https://chromium-review.googlesource.com/c/1387884 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-12-20 13:12:55 -08:00
'process/process_memory_mac.cc',
'process/process_memory_mac.h',
fuchsia: Port ElfImageReader and (some of) its tests (Still need to avoid fork()-dependence for the non-self tests.) Bug: crashpad:196 Change-Id: Ib34fe33c7ec295881c1f555995072d9ff742647f Reviewed-on: https://chromium-review.googlesource.com/876650 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-01-19 14:03:34 -08:00
'process/process_memory_native.h',
Move linux/process files to util/process A step towards making these files usable by non-Linux systems. Bug: crashpad:196 Change-Id: I71323b29e46208b3992055722e4622d79409c44c Reviewed-on: https://chromium-review.googlesource.com/685406 Commit-Queue: Dave Bort <dbort@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-09-26 12:52:41 -07:00
'process/process_memory_range.cc',
'process/process_memory_range.h',
Add AlignedVector and use it for vector<MEMORY_BASIC_INFORMATION64> MEMORY_BASIC_INFORMATION64 specifies an alignment of 16, but the standard allocator used by containers doesn't honor this. Although 16 is the default alignment size used on Windows for x86_64, it's not for 32-bit x86. clang assumed that the alignment of the structure was as declared, and used an SSE load sequence that required this alignment. AlignedAllocator is a replacement for std::allocator that allows the alignment to be specified. AlignedVector is an std::vector<> that uses AlignedAllocator instead of std::allocator. BUG=chromium:564691 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1498133002 .
2015-12-08 15:38:17 -05:00
'stdlib/aligned_allocator.cc',
'stdlib/aligned_allocator.h',
Improve map insertion operations. Add MapInsertOrReplace<>() to insert a key-value pair into a map if the key is not already present, or replace the existing value for key if the key is present. The original value can optionally be returned to the caller in this case. Map insertions now use either MapInsertOrReplace<>() or std::map<>::insert() directly. Use MapInsertOrReplace<>() when the map should be updated to contain a mapping from a key to a value regardless of whether the key is already present. Use std::map<>::insert() to insert a mapping from a key to a value without replacing any existing mapping from a key, if present. If it is important to know whether an existing mapping from a key was present, use the returned std::pair<>.second. If it is important to know the existing value, use the returned std::pair<>.first->second. This change has a slight positive impact on performance. TEST=crashpad_util_test MapInsert.MapInsertOrReplace and others BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1044273002
2015-03-31 14:29:32 -04:00
'stdlib/map_insert.h',
Add CFPropertyToLaunchData() and its test. TEST=util_test Launchd R=rsesek@chromium.org Review URL: https://codereview.chromium.org/438673003
2014-08-03 18:53:10 -04:00
'stdlib/objc.h',
Add string_number_conversion and its test. This includes the StringToNumber() function, both int and unsigned int variants. Similar functionality is available in base, but it is unsuitable for applications where a number’s base may be determined based on an "0x" or "0X" prefix (hexadecimal) or an "0" prefix (octal). TEST=util_test StringNumberConversion.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/557033002
2014-09-10 15:30:11 -04:00
'stdlib/string_number_conversion.cc',
'stdlib/string_number_conversion.h',
Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/430003003
2014-08-01 14:39:55 -04:00
'stdlib/strlcpy.cc',
'stdlib/strlcpy.h',
Add strnlen() wrapper and its test. TEST=util_test strnlen.strnlen R=rsesek@chromium.org Review URL: https://codereview.chromium.org/514253002
2014-08-28 14:38:27 -04:00
'stdlib/strnlen.cc',
'stdlib/strnlen.h',
Don’t attempt to do periodic tasks in a secondary crashpad_handler 76a67a37b1d0 adds crashpad_handler’s --monitor-self argument, which results in a second crashpad_handler instance running out of the same database as the initial crashpad_handler instance that it monitors. The two handlers start at nearly the same time, and will initially be on precisely the same schedule for periodic tasks such as scanning for new reports to upload and pruning the database. This is an unnecessary duplication of effort. This adds a new --no-periodic-tasks argument to crashpad_handler. When the first instance of crashpad_handler starts a second to monitor it, it will use this argument, which prevents the second instance from performing these tasks. When --no-periodic-tasks is in effect, crashpad_handler will still be able to upload crash reports that it knows about by virtue of having written them itself, but it will not scan the database for other pending reports to upload. Bug: crashpad:143 Test: crashpad_util_test ThreadSafeVector.ThreadSafeVector Change-Id: I7b249dd7b6d5782448d8071855818f986b98ab5a Reviewed-on: https://chromium-review.googlesource.com/473827 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-04-14 14:50:11 -04:00
'stdlib/thread_safe_vector.h',
android: fix the gyp build Change-Id: Ic54fd61258f4ea5b3aaa83a252faa0053ca1f552 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2062773 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-02-18 11:09:00 -08:00
'stream/base94_output_stream.cc',
'stream/base94_output_stream.h',
'stream/file_encoder.cc',
'stream/file_encoder.h',
'stream/file_output_stream.cc',
'stream/file_output_stream.h',
'stream/log_output_stream.cc',
'stream/log_output_stream.h',
'stream/output_stream_interface.h',
'stream/zlib_output_stream.cc',
'stream/zlib_output_stream.h',
CrashpadClient::StartHandler(): accept database, url, and annotations arguments. This makes it easier for clients to start the Crashpad handler, instead of requiring them to know how to construct arguments for the handler themselves. Note in the TEST that -a is no longer required. TEST=run_with_crashpad --handler crashpad_handler \ --database=/tmp/crashpad_db \ --url=https://clients2.google.com/cr/staging_report \ --annotation=prod=crashpad \ --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1001993002
2015-03-12 14:28:19 -04:00
'string/split_string.cc',
'string/split_string.h',
Add Semaphore::TimedWait(). This also splits the per-OS Semaphore methods into their own files. TEST=util_test Semaphore.* R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/909263002
2015-02-10 17:01:58 -05:00
'synchronization/semaphore_mac.cc',
'synchronization/semaphore_posix.cc',
'synchronization/semaphore_win.cc',
Add Semaphore and its test, and use it where semaphores are needed. TEST=util_test Semaphore.*:ProcessReader.*:ExceptionPorts.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/589243003
2014-09-24 13:32:31 -04:00
'synchronization/semaphore.h',
Don't spawn an upload thread if url is empty Also automatically stop upload and prune threads on destruction. Bug: crashpad:30 Change-Id: I45a30944eb3052182da296e00a6d6041691ab772 Reviewed-on: https://chromium-review.googlesource.com/924456 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2018-02-20 10:55:17 -08:00
'thread/stoppable.h',
Move thread from test/ to util/thread/. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1134943003
2015-05-13 14:05:57 -04:00
'thread/thread.cc',
'thread/thread.h',
Add ThreadLogMessages and its test. This updates mini_chromium to 91ea4908ffd74d9c886bd2f8ccbfae6d31c499af. The last five commits listed here are required to support this change. The mini_chromium update includes: c1745a924c5c Fix paths to atomicops files in base.gyp from 2f02dcc73536 108e9247189c Add #include of <unistd.h> to close_nocancel.cc 6e4f98a9edf8 Add logging::SetLogMessageHandler() 4063fcb8f460 Add base::ThreadLocalStorage 4870f18a33a6 Add base::LazyInstance 0d31b1f3a289 Fix base/memory/aligned_memory.h for MSVC 91ea4908ffd7 base/logging.h: DCHECK() should always reference its condition BUG=crashpad:26 TEST=crashpad_util_test ThreadLogMessages.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1041643003
2015-03-30 14:51:34 -04:00
'thread/thread_log_messages.cc',
'thread/thread_log_messages.h',
Move thread from test/ to util/thread/. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1134943003
2015-05-13 14:05:57 -04:00
'thread/thread_posix.cc',
'thread/thread_win.cc',
Create WorkerThread, an abstraction to perform some work on an interval. This was extracted from CrashReportUploadThread and will be re-used for the database pruning thread. BUG=crashpad:22 R=mark@chromium.org Review URL: https://codereview.chromium.org/1526563003 .
2016-01-04 17:10:58 -05:00
'thread/worker_thread.cc',
'thread/worker_thread.h',
win: make CrashpadInfo retrievable The main goal was to get the beginnings of module iteration and retrieval of CrashpadInfo in snapshot. The main change for that is to move crashpad_info_client_options[_test] down out of mac/. This also requires adding some of the supporting code of snapshot in ProcessReaderWin, ProcessSnapshotWin, and ModuleSnapshotWin. These are partially copied from Mac or stubbed out with lots of TODO annotations. This is a bit unfortunate, but seemed like the most productive way to make progress incrementally. That is, it's mostly placeholder at the moment, but hopefully has the right shape for things to come. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1052813002
2015-05-01 13:48:23 -07:00
'win/address_types.h',
'win/checked_win_address_range.h',
win: Implement CrashpadClient::StartHandler() BUG=crashpad:69 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1428803006 .
2015-11-02 13:59:36 -05:00
'win/command_line.cc',
'win/command_line.h',
Add Windows ARM64 support to Chromium crashpad Bug: chromium:893460 Change-Id: Ifbeb6f937a6b96c77b02dcf8afe492c5bc617435 Reviewed-on: https://chromium-review.googlesource.com/c/1347773 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2018-12-12 12:58:24 -08:00
'win/context_wrappers.h',
Fix CRITICAL_SECTION test I thought I had confirmed that this still allocated and ignored the flag on older OSs, but I must have not had the PLOG active yet? I'm not sure what I did. (I might try to blame VMware as it has an annoying habit of caching old binaries when you use it's "Shared Folders" feature to point at the dev machine's build dir.) I confirmed that it does work on Win8 and Win10 but doesn't on Win XP and Win 7. R=mark@chromium.org BUG=crashpad:52 Review URL: https://codereview.chromium.org/1405243002 .
2015-10-16 14:55:14 -07:00
'win/critical_section_with_debug_info.cc',
'win/critical_section_with_debug_info.h',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'win/exception_handler_server.cc',
'win/exception_handler_server.h',
win: Add and use GET_FUNCTION() and GET_FUNCTION_REQUIRED() These wrap the GetProcAddress(LoadLibrary(), …) idiom into macros that are much less wordy. TEST=crashpad_util_test GetFunction.GetFunction and all others R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1405323003 .
2015-10-19 14:32:07 -04:00
'win/get_function.cc',
'win/get_function.h',
Adding an API to read module annotations in snapshot.gyp Kasko needs a way to read crash keys from out of process. This API reuses the functionality of PEImageAnnotationsReader. Change-Id: I2f3bbc358212e6f50235183e9dbb4e5a2cf989cf This is a reupload of https://codereview.chromium.org/1586433003/ but for gerrit. Change-Id: I2f3bbc358212e6f50235183e9dbb4e5a2cf989cf Reviewed-on: https://chromium-review.googlesource.com/322550 Reviewed-by: Scott Graham <scottmg@chromium.org> Tested-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Scott Graham <scottmg@google.com>
2016-01-18 15:05:20 -05:00
'win/get_module_information.cc',
'win/get_module_information.h',
win: Add HandleToInt() and IntToHandle() This consolidates all of the twisted casts and comments that discuss how HANDLEs are really only 32 bits wide even in 64-bit processes on 64-bit operating systems into a single location. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1422503015 .
2015-11-05 14:00:26 -05:00
'win/handle.cc',
'win/handle.h',
win: Start crashpad_handler by inheriting connection data to it Previously, StartHandler() launched the handler process, then connected over a pipe to register for crash handling. Instead, the initial client can create and inherit handles to the handler and pass those handle values and other data (addresses, etc.) on the command line. This should improve startup time as there's no need to synchronize with the process at startup, and allows avoiding a call to CreateProcess() directly in StartHandler(), which is important for registration for crash reporting from DllMain(). Incidentally adds new utility functions for string/number conversion and string splitting. Note: API change; UseHandler() is removed for all platforms. BUG=chromium:567850,chromium:656800 Change-Id: I1602724183cb107f805f109674c53e95841b24fd Reviewed-on: https://chromium-review.googlesource.com/400015 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-10-21 13:08:18 -07:00
'win/initial_client_data.cc',
'win/initial_client_data.h',
win: Retrieve module version/type information Refactor version retrieval from system snapshot to use when retrieving the module version information. Follows https://codereview.chromium.org/1133203002/. R=cpu@chromium.org, rsesek@chromium.org TBR=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1126273003
2015-05-14 17:43:49 -07:00
'win/module_version.cc',
'win/module_version.h',
win: Implement exception snapshot Refactor some of the NT internals helpers and cpu_context to share between the thread and exception snapshot code. Add test that runs crashing child and validates the exception in the snapshot. R=mark@chromium.org, cpu@chromium.org, rsesek@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1126413008 .
2015-08-18 12:25:19 -07:00
'win/nt_internals.cc',
'win/nt_internals.h',
win: Add (currently unused) NTSTATUS_LOG Split out of https://codereview.chromium.org/1336823002/, I'll go and adapt various places to use it as I need to touch them. R=mark@chromium.org BUG=crashpad:1, crashpad:50 Review URL: https://codereview.chromium.org/1343873003 .
2015-09-15 09:22:29 -07:00
'win/ntstatus_logging.cc',
'win/ntstatus_logging.h',
win: Add implementation of ProcessInfo This is as a precursor to ProcessReader. Some basic functionality is included for now, with more to be added later as necessary. The PEB code is pretty icky -- walking the doubly-linked list in the target's address space is cumbersome. The alternative is to use EnumProcessModules. That would work but: 1) needs different APIs for XP and Vista 64+ 2) retrieves modules in memory-location order, rather than initialization order. I felt retrieving them in initialization order might be useful when detecting third party DLL injections. In the end, we may want to make both orders available. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/977003003
2015-03-05 22:07:38 -08:00
'win/process_info.cc',
'win/process_info.h',
win: Support reading process info cross-bitness This only works 64->64, 32->32, and 64->32. We shouldn't have a need for 32->64. It will also currently not work if the crash service is running on Wow64 itself (that is, 32->32, but on an x64 OS). We should also be able to avoid needing that. Primarily, this change templatizes the winternl.h process structure types on word size, so the PEB can be read in a foreign bitsize process. This also happens to resolve using void* as pointer values into foreign processes, as they're now all either DWORD or DWORD64 depending on which traits class is used. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/981393003
2015-03-09 16:37:43 -07:00
'win/process_structs.h',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'win/registration_protocol_win.cc',
'win/registration_protocol_win.h',
win: Go back to using ml.exe for SafeTerminateProcess() This reverts 55133d332b6c and adds a broken dummy SafeTerminateProcess() for cross builds instead. It’s similar to 2f4516f93838, which was for CaptureContext(). This upstreams https://chromium.googlesource.com/chromium/src/+/af5f31ed615bdbf0ad246cff643a2802a1e0d702 (slightly modified). The dummy implementation in the “broken” file affords no protection against third-party code patching TerminateProcess() badly. The “broken” file is not used by Crashpad anywhere at all, and is only used by Crashpad in Chromium during a cross build targeting Windows without the benefit of Microsoft’s ml.exe assembler. Strictly speaking, this file does not need to be checked in to the Crashpad repository, but since Chromium needs it to unblock its not-production-ready cross build for Windows, it’s being landed here to avoid Chromium’s copy of Crashpad appearing as modified or “dirty” relative to this upstream copy. Bug: chromium:762167, chromium:777924 Change-Id: Iba68c0cab142fbe9541ea254a9a856b8263e4c70 Reviewed-on: https://chromium-review.googlesource.com/735078 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-24 14:22:22 -04:00
'win/safe_terminate_process.asm',
win: Wrap TerminateProcess() to accept cdecl patches on x86 TerminateProcess(), like most of the Windows API, is declared WINAPI, which is __stdcall on 32-bit x86. That means that the callee, TerminateProcess() itself, is responsible for cleaning up parameters on the stack on return. In https://crashpad.chromium.org/bug/179, crashes in ExceptionHandlerServer::OnNonCrashDumpEvent() were observed in ways that make it evident that TerminateProcess() has been patched with a __cdecl routine. The crucial difference between __stdcall and __cdecl is that the caller is responsible for stack parameter cleanup in __cdecl. The mismatch means that nobody cleans parameters from the stack, and the stack pointer has an unexpected value, which in the case of the Crashpad handler crash, results in TerminateProcess()’s second argument erroneously being used as the lock address in the call to ReleaseSRWLockExclusive() or LeaveCriticalSection(). As a workaround, on 32-bit x86, call through SafeTerminateProcess(), a custom assembly routine that’s compatible with either __stdcall or __cdecl implementations of TerminateProcess() by not trusting the value of the stack pointer on return from that function. Instead, the stack pointer is restored directly from the frame pointer. Bug: crashpad:179 Test: crashpad_util_test SafeTerminateProcess.*, others Change-Id: If9508f4eb7631020ea69ddbbe4a22eb335cdb325 Reviewed-on: https://chromium-review.googlesource.com/481180 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-19 13:22:08 -04:00
'win/safe_terminate_process.h',
win: Add Scoped...Handle Intended for future use to implement util/file/file_writer. There's a similar class in base: https://code.google.com/p/chromium/codesearch#chromium/src/base/win/scoped_handle.h&l=28 However (perhaps for historical reasons) it does not distinguish between the possible types of HANDLEs which have different invalid values, resulting in a need to copy a bunch of code rather than simply using ScopedGeneric. Instead, distinguish between the types so the caller can use the correct one. Refs: http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx http://msdn.microsoft.com/en-us/magazine/cc302328.aspx (Figure 2) R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/813873004
2014-12-18 09:51:20 -08:00
'win/scoped_handle.cc',
'win/scoped_handle.h',
win: Lower integrity level of connection pipe This is necessary to be able to connect to crashpad_handler from a Chrome renderer. R=jschuh@chromium.org, mark@chromium.org BUG=chromium:546288 Review URL: https://codereview.chromium.org/1405093013 .
2015-11-06 10:43:39 -08:00
'win/scoped_local_alloc.cc',
'win/scoped_local_alloc.h',
win: Implement and use ScopedProcessSuspend R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1303173011 .
2015-09-08 10:09:26 -07:00
'win/scoped_process_suspend.cc',
'win/scoped_process_suspend.h',
win: Tests shouldn’t freak out when CodeView PDB links are absent crashpad_snapshot_test PEImageReader.DebugDirectory was hanging when crashpad_snapshot_test_image_reader.exe did not have a CodeView PDB link. This occurred when linked by Lexan ld-link.exe without /DEBUG. Bug: chromium:782781 Change-Id: I8fbc4d8decf6ac5e19f7ffeb230fd15d7c40fd51 Reviewed-on: https://chromium-review.googlesource.com/761320 Reviewed-by: Leonard Mosescu <mosescu@chromium.org>
2017-11-09 14:33:15 -05:00
'win/scoped_set_event.cc',
'win/scoped_set_event.h',
metrics: Record handler lifetime milestone events It could be useful to put our existing Crashpad.HandlerCrashed metrics into context by getting a sense of handler starts, clean exits, and other types of exits. BUG=crashpad:100 Change-Id: I8982075158ea6d210eb2ddad678302e339a42192 Reviewed-on: https://chromium-review.googlesource.com/444124 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-22 13:39:46 -05:00
'win/session_end_watcher.cc',
'win/session_end_watcher.h',
win: Make DumpAndCrash() always terminate, and tidy up special codes Upstreaming with tidying up of https://codereview.chromium.org/2377693002/. R=mark@chromium.org BUG=chromium:634418 Change-Id: Ie8b3b673c8d2a06c5cc918a034688aa9396cfbf4 Reviewed-on: https://chromium-review.googlesource.com/390436 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-09-28 20:18:39 -07:00
'win/termination_codes.h',
win: Fix OpenProcess(PROCESS_ALL_ACCESS, ...) on XP PROCESS_ALL_ACCESS was changed in later SDKs and the newer value fails when run on XP with ERROR_ACCESS_DENIED. Use the old value to maintain compatibility with XP. R=mark@chromium.org BUG=crashpad:50 Review URL: https://codereview.chromium.org/1337133002 .
2015-09-11 13:16:06 -07:00
'win/xp_compat.h',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
],
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'conditions': [
['OS=="mac"', {
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'conditions': [
['GENERATOR=="ninja"', {
# ninja’s rules can’t deal with sources that have paths relative
# to environment variables like SDKROOT. Copy the .defs files out
# of SDKROOT and into a place they can be referenced without any
# environment variables.
'copies': [
{
'destination': '<(INTERMEDIATE_DIR)/util/mach',
'files': [
'$(SDKROOT)/usr/include/mach/exc.defs',
'$(SDKROOT)/usr/include/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'$(SDKROOT)/usr/include/mach/notify.defs',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
],
},
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'sources': [
'<(INTERMEDIATE_DIR)/util/mach/exc.defs',
'<(INTERMEDIATE_DIR)/util/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'<(INTERMEDIATE_DIR)/util/mach/notify.defs',
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
}, { # else: GENERATOR!="ninja"
# The Xcode generator does copies after rules, so the above trick
# won’t work, but its rules tolerate sources with SDKROOT-relative
# paths.
'sources': [
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'$(SDKROOT)/usr/include/mach/exc.defs',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'$(SDKROOT)/usr/include/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'$(SDKROOT)/usr/include/mach/notify.defs',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
}],
],
'rules': [
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
{
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'rule_name': 'mig',
'extension': 'defs',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'inputs': [
'mach/mig.py',
],
'outputs': [
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)User.c',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)Server.c',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT).h',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)Server.h',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
'action': [
mac: Provide a larger thread state buffer for AVX-512 on 10.13 Crashpad doesn’t use AVX-512, but when receiving replies to exceptions forwarded to ReportCrash, may see buffers large enough to contain AVX-512 thread state. This can result in messages like “UniversalExceptionRaise: (ipc/rcv) msg too large (0x10004004)”. I386_THREAD_STATE_MAX has increased from 224 to 614 in the 10.13 SDK, meaning that the maximum supported size for old_state and new_state in [mach_]exception_raise_state[_identity]() has increased from 896 to 2,456 bytes. This constant defines the size of the buffer that these MIG-generated routines will work with. By providing this definition in compat, the buffer size is increased when building with older SDKs. Note that on the “send” side, the size of the message given to mach_msg() will be trimmed to include only the valid part of the state area based on the stateCnt field, so increasing the value to 614 here won’t result Crashpad sending messages this large. That would be a potential interoperability concern with older OS versions. Bug: crashpad:185, crashpad:190 Change-Id: Ia46091ae46fd6227a17f59eb4bc00914be471aa7 Reviewed-on: https://chromium-review.googlesource.com/541515 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-06-20 09:50:37 -04:00
'python',
'<@(_inputs)',
'<(RULE_INPUT_PATH)',
'<@(_outputs)',
'--include=../compat/mac'
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
'process_outputs_as_sources': 1,
},
Run mig to generate the exc and mach_exc interfaces. mach_exc is necessary because libSystem doesn’t contain this at all. exc is necessary too, however: the copy in libSystem relies on the server callbacks being externally defined symbols, which is cheesey. Additionally, some Crashpad code wants to call internal validation (“check”) routines that are not normally accessible to outside callers via the copy of exc in libSystem, but they are made accessible here by processing mig’s output in this Python script. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/541213002
2014-09-05 13:27:06 -04:00
],
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
'$(SDKROOT)/System/Library/Frameworks/IOKit.framework',
handler/mac: Log a warning when an exception message has a suspicious origin. This adds AuditPIDFromMachMessageTrailer() to get the process ID of a Mach message’s sender. Exception messages are considered suspicious when not sent by the kernel or the exception process. TEST=crashpad_util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1001943002
2015-03-12 14:00:38 -04:00
'$(SDKROOT)/usr/lib/libbsm.dylib',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
},
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
}, { # else: OS!=mac
'sources!': [ 'misc/capture_context_mac.S' ],
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
}],
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
['OS=="win"', {
'link_settings': {
'libraries': [
metrics: Record handler lifetime milestone events It could be useful to put our existing Crashpad.HandlerCrashed metrics into context by getting a sense of handler starts, clean exits, and other types of exits. BUG=crashpad:100 Change-Id: I8982075158ea6d210eb2ddad678302e339a42192 Reviewed-on: https://chromium-review.googlesource.com/444124 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-22 13:39:46 -05:00
'-luser32.lib',
win: Fix build after 60be5a66a050 crashpad_util should already have been the target to depend on version.lib, but this wasn’t caught until something that depends on crashpad_util but not crashpad_snapshot used that code, as crashpad_util_test now does. Change-Id: I1b7ced72c657946b297a328c0f89f51190d7d708 Reviewed-on: https://chromium-review.googlesource.com/448203 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-03-01 12:56:41 -05:00
'-lversion.lib',
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
'-lwinhttp.lib',
],
},
win: Disable C4201 in util.gyp for building without crashpad common.gypi R=mark@chromium.org BUG=crashpad:1, crashpad:526488 Review URL: https://codereview.chromium.org/1421173002 .
2015-10-23 14:07:59 -07:00
'msvs_disabled_warnings': [
4201, # nonstandard extension used : nameless struct/union.
Fix some VS 2015 warnings Fix some warnings when compiling crashpad with VC++ 2015 Update 1. Warning 4302 occurs if you convert from a pointer to a <sizeof(void*) integer in one cast, because this often indicates an accidental pointer truncation which can be a bug in 64-bit builds. Warning 4577 warns that noexcept will not be enforced, but we don't want it to be enforced anyway, so I disabled it. The full warning is: warning C4577: 'noexcept' used with no exception handling mode specified termination on exception is not guaranteed. Specify /EHsc BUG=440500 R=mark@chromium.org Review URL: https://codereview.chromium.org/1527803002 . Patch from Bruce Dawson <brucedawson@chromium.org>.
2015-12-14 20:01:05 -05:00
4577, # 'noexcept' used with no exception handling mode specified
win: Disable C4201 in util.gyp for building without crashpad common.gypi R=mark@chromium.org BUG=crashpad:1, crashpad:526488 Review URL: https://codereview.chromium.org/1421173002 .
2015-10-23 14:07:59 -07:00
],
Make VS2015 build work [66->31/130 ~33] CXX obj\util\stdlib\crashpad_util_test.aligned_allocator_test.obj FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\util\stdlib\crashpad_util_test.aligned_allocator_test.obj.rsp /c ..\..\util\stdlib\aligned_allocator_test.cc /Foobj\util\stdlib\crashpad_util_test.aligned_allocator_test.obj /Fdobj\util\crashpad_util_test.cc.pdb d:\src\crashpad\crashpad\util\stdlib\aligned_allocator.h(74): error C2220: warning treated as error - no 'object' file generated d:\src\crashpad\crashpad\util\stdlib\aligned_allocator.h(74): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc Change-Id: I22dbfe0186992759272c668110862a7c6d98ca1d Reviewed-on: https://chromium-review.googlesource.com/334734 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-04-20 15:30:20 -07:00
'direct_dependent_settings': {
'msvs_disabled_warnings': [
4577, # 'noexcept' used with no exception handling mode specified
],
},
win: Add and use a custom CaptureContext() implementation RtlCaptureContext() is buggy and limited. BUG=crashpad:53 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1377963002 .
2015-09-30 14:10:08 -04:00
'conditions': [
['target_arch=="ia32"', {
'msvs_settings': {
'MASM': {
'UseSafeExceptionHandlers': 'true',
},
},
}],
],
Omit platform-specific assembler source from builds as needed The default filename rules do not match .S or .asm, so the platform-specific assembler implementations of CaptureContext() were not being affirmatively excluded from other platforms’ builds. This previously worked without causing problems because the Mac build environment didn’t know what to do with .asm files, and the Windows build environment didn’t know what to do with .S files. Now that another platform that may understand .S files is being added, the rules for when to build these files must be tailored a bit more tightly. BUG=crashpad:30 Change-Id: Ib62e619c007320d45279c104b3e229d92698aa72 Reviewed-on: https://chromium-review.googlesource.com/406348 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-11-01 16:47:10 -04:00
}, { # else: OS!="win"
'sources!': [
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
'misc/capture_context_win.asm',
win: Go back to using ml.exe for SafeTerminateProcess() This reverts 55133d332b6c and adds a broken dummy SafeTerminateProcess() for cross builds instead. It’s similar to 2f4516f93838, which was for CaptureContext(). This upstreams https://chromium.googlesource.com/chromium/src/+/af5f31ed615bdbf0ad246cff643a2802a1e0d702 (slightly modified). The dummy implementation in the “broken” file affords no protection against third-party code patching TerminateProcess() badly. The “broken” file is not used by Crashpad anywhere at all, and is only used by Crashpad in Chromium during a cross build targeting Windows without the benefit of Microsoft’s ml.exe assembler. Strictly speaking, this file does not need to be checked in to the Crashpad repository, but since Chromium needs it to unblock its not-production-ready cross build for Windows, it’s being landed here to avoid Chromium’s copy of Crashpad appearing as modified or “dirty” relative to this upstream copy. Bug: chromium:762167, chromium:777924 Change-Id: Iba68c0cab142fbe9541ea254a9a856b8263e4c70 Reviewed-on: https://chromium-review.googlesource.com/735078 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-24 14:22:22 -04:00
'win/safe_terminate_process.asm',
Omit platform-specific assembler source from builds as needed The default filename rules do not match .S or .asm, so the platform-specific assembler implementations of CaptureContext() were not being affirmatively excluded from other platforms’ builds. This previously worked without causing problems because the Mac build environment didn’t know what to do with .asm files, and the Windows build environment didn’t know what to do with .S files. Now that another platform that may understand .S files is being added, the rules for when to build these files must be tailored a bit more tightly. BUG=crashpad:30 Change-Id: Ib62e619c007320d45279c104b3e229d92698aa72 Reviewed-on: https://chromium-review.googlesource.com/406348 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2016-11-01 16:47:10 -04:00
],
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
}],
android: fix the gyp build Change-Id: Ic54fd61258f4ea5b3aaa83a252faa0053ca1f552 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2062773 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-02-18 11:09:00 -08:00
['OS=="android"', {
'link_settings': {
'libraries': [
'-llog',
],
},
}],
android: enable upload This patch also updates WorkerThread to execute DoWork() when DoWorkNow() has been called, which is relevant when DoWorkNow() and Stop() have both been called. This occurs regularly on Android where the handler's current normal mode is to dump a single process and exit. This change ensures the upload thread has a chance to upload the report before the handler exits. This change should not affect upload on Chrome/WebView/Chromecast which don't pass Crashpad a --url option and are still responsible for their own uploads. Change-Id: Ie5553eafc13714f0438b4b133a92516f7abec153 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1643710 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-06-18 09:48:52 -07:00
['OS=="linux" or OS=="android"', {
Implementation of HTTPTransport via raw socket Partial implementation: Currently only handles http (i.e. no TLS), only POST, and only certain response types (only when Content-Length is specified, and not chunked). Used for Linux and Fuchsia lacking anything better (that's shippable). Removes libcurl HTTPTransport, since it isn't available in the Chromium sysroot anyway. This is an intermediate step until BoringSSL is available in the Fuchsia SDK. Once that's available, it should be "relatively straightfoward" to make http_transport_socket.cc secure its socket using BoringSSL or OpenSSL depending on the platform. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: If33a0d3f11b9000cbc3f52f96cd024ef274a922f Reviewed-on: https://chromium-review.googlesource.com/1022717 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-04-26 17:21:45 -07:00
'sources': [
'net/http_transport_socket.cc',
update gyp_crashpad_android.py This patch updates gyp_crashpad_android.py to function with NDK r20, removes the requirement to generate a standalone toolchain, and updates documentation on building for Android. Also some gyp build fixes. Change-Id: Ide338417ab2a21eca7a4bf42c1fb834e5639c186 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1798746 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2019-09-11 11:30:22 -07:00
'process/process_memory_sanitized.cc',
'process/process_memory_sanitized.h',
Implementation of HTTPTransport via raw socket Partial implementation: Currently only handles http (i.e. no TLS), only POST, and only certain response types (only when Content-Length is specified, and not chunked). Used for Linux and Fuchsia lacking anything better (that's shippable). Removes libcurl HTTPTransport, since it isn't available in the Chromium sysroot anyway. This is an intermediate step until BoringSSL is available in the Fuchsia SDK. Once that's available, it should be "relatively straightfoward" to make http_transport_socket.cc secure its socket using BoringSSL or OpenSSL depending on the platform. Bug: crashpad:196, crashpad:227, crashpad:30 Change-Id: If33a0d3f11b9000cbc3f52f96cd024ef274a922f Reviewed-on: https://chromium-review.googlesource.com/1022717 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-04-26 17:21:45 -07:00
],
linux: Add HTTPTransportLibcurl for Linux (but not Android) BUG=crashpad:30 TEST=crashpad_util_test HTTPTransport.* Change-Id: Ifef812830fe2d778f400467d93771dc166cef390
2017-03-03 14:47:03 -05:00
}, { # else: OS!="linux"
'sources!': [
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
'misc/capture_context_linux.S',
linux: Add HTTPTransportLibcurl for Linux (but not Android) BUG=crashpad:30 TEST=crashpad_util_test HTTPTransport.* Change-Id: Ifef812830fe2d778f400467d93771dc166cef390
2017-03-03 14:47:03 -05:00
],
}],
Move linux/process files to util/process A step towards making these files usable by non-Linux systems. Bug: crashpad:196 Change-Id: I71323b29e46208b3992055722e4622d79409c44c Reviewed-on: https://chromium-review.googlesource.com/685406 Commit-Queue: Dave Bort <dbort@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-09-26 12:52:41 -07:00
['OS!="linux" and OS!="android"', {
'sources/': [
['exclude', '^process/'],
],
}],
Run mig to generate the exc and mach_exc interfaces. mach_exc is necessary because libSystem doesn’t contain this at all. exc is necessary too, however: the copy in libSystem relies on the server callbacks being externally defined symbols, which is cheesey. Additionally, some Crashpad code wants to call internal validation (“check”) routines that are not normally accessible to outside callers via the copy of exc in libSystem, but they are made accessible here by processing mig’s output in this Python script. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/541213002
2014-09-05 13:27:06 -04:00
],
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
'target_conditions': [
['OS=="android"', {
'sources/': [
linux: Add ProcessMemory which reads another process' memory Provides Read, ReadCString, and ReadCStringSizeLimited. Does not provide ReadMapped because Linux does not support mmap on /proc/pid/mem. Bug: crashpad:30 Change-Id: Ia319c0107b1f138aeb8e5d0ee480c77310df7202 Reviewed-on: https://chromium-review.googlesource.com/459700 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2017-04-03 14:09:58 -07:00
['include', '^linux/'],
Relocate CaptureContext to misc and implement on Linux Previously, the mac version was under client/ and win under util/win/. This cl brings them all together under util/misc/ and combines common test code. Bug: crashpad:30 Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c Reviewed-on: https://chromium-review.googlesource.com/907755 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2018-02-08 16:25:22 -08:00
['include', '^misc/capture_context_linux\\.S$'],
“Promote” test::Paths::Executable() to Paths::Executable() This supports the “double handler” or “double handler with low probability” models from https://crashpad.chromium.org/bug/143. For crashpad_handler to be become its own client, it needs access to its own executable path to pass to CrashpadClient::StartHandler(). This was formerly available in the test-only test::Paths::Executable(). Bring that function’s implementation to the non-test Paths::Executable() in util/misc, and rename test::Paths to test::TestPaths to avoid future confusion. test::TestPaths must still be used to access TestDataRoot(), which does not make any sense to non-test code. test::TestPaths::Executable() is retained for use by tests, which most likely prefer the fatal semantics of that function. Paths::Executable() is not fatal because for the purposes of implementing the double handler, a failure to locate the executable path (which may happen on some systems in deeply-nested directory hierarchies) shouldn’t cause the initial crashpad_handler to abort, even if it does prevent a second crashpad_handler from being started. Bug: crashpad:143 Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.* Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156 Reviewed-on: https://chromium-review.googlesource.com/466346 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-04-03 13:53:11 -04:00
['include', '^misc/paths_linux\\.cc$'],
android, gyp: fix the build Change-Id: If852448b5719310b73774cac635ef9c52a3efc22 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1914349 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
2019-11-13 12:44:29 -08:00
['include', '^misc/time_linux\\.cc$'],
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
['include', '^posix/process_info_linux\\.cc$'],
Make ProcessMemory an abstract interface Only a Linux implementation for now, but similar code for other OSes can move behind it in the future. Bug: crashpad:196 Change-Id: I05966db1599a9cac3146d2a3d964e7ad8629d616 Reviewed-on: https://chromium-review.googlesource.com/685408 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Dave Bort <dbort@google.com>
2017-10-11 20:01:56 -07:00
['include', '^process/process_memory_linux\\.cc$'],
['include', '^process/process_memory_linux\\.h$'],
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
],
android: fix the gyp build Change-Id: Ic54fd61258f4ea5b3aaa83a252faa0053ca1f552 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2062773 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-02-18 11:09:00 -08:00
}, { # else: OS!="android"
'sources!': [
'stream/log_output_stream.cc',
'stream/log_output_stream.h',
]
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
}],
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
},
win: Add implementation of ProcessInfo This is as a precursor to ProcessReader. Some basic functionality is included for now, with more to be added later as necessary. The PEB code is pretty icky -- walking the doubly-linked list in the target's address space is cumbersome. The alternative is to use EnumProcessModules. That would work but: 1) needs different APIs for XP and Vista 64+ 2) retrieves modules in memory-location order, rather than initialization order. I felt retrieving them in initialization order might be useful when detecting third party DLL injections. In the end, we may want to make both orders available. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/977003003
2015-03-05 22:07:38 -08:00
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
}
Reference in New Issue Copy Permalink