3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-31 01:43:03 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/util/util.gyp

242 lines
8.2 KiB
Plaintext
Raw Normal View History

Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
# Copyright 2014 The Crashpad Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
{
Set the chromium_code GYP variable. When building in the Chromium tree, chromium_code is necessary to apply Chromium’s build/filename_rules.gypi. Crashpad’s build depends on these rules. chromium_code also enables a high warning level, which is desirable for Crashpad. BUG=crashpad:12 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/986873002
2015-03-08 15:17:22 -04:00
'includes': [
'../build/crashpad.gypi',
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'targets': [
{
Set target_name on many targets to use a crashpad_ prefix. In Chromium, many targets are built, sharing a single output directory. Collisions are likely. When integrating Crashpad into Chromium, the ui/snapshot library and Crashpad’s snapshot library were found to conflict. This change gives most Crashpad targets a “crashpad_” prefix to avoid conflicts. All library and test targets are given a target_name with this prefix. Existing tools are not likely to conflict with anything else and are not given a prefix. BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/990553003
2015-03-08 16:25:34 -04:00
'target_name': 'crashpad_util',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'type': 'static_library',
'dependencies': [
Set target_name on many targets to use a crashpad_ prefix. In Chromium, many targets are built, sharing a single output directory. Collisions are likely. When integrating Crashpad into Chromium, the ui/snapshot library and Crashpad’s snapshot library were found to conflict. This change gives most Crashpad targets a “crashpad_” prefix to avoid conflicts. All library and test targets are given a target_name with this prefix. Existing tools are not likely to conflict with anything else and are not given a prefix. BUG=crashpad:12 R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/990553003
2015-03-08 16:25:34 -04:00
'../compat/compat.gyp:crashpad_compat',
Allow Crashpad to build in the Chromium tree. When building in the Chromium tree, this swaps out Crashpad’s copies of mini_chromium, gtest, and gmock for the equivalents provided by Chromium. A GYP variable, crashpad_in_chromium, is used to determine the behavior. gclient doesn’t sync sub-DEPS, so when doing an in-Chromium build, Crashpad’s copies of mini_chromium, gtest, and gmock are not available. BUG=crashpad:12 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/986033002
2015-03-09 15:25:42 -04:00
'../third_party/mini_chromium/mini_chromium.gyp:base',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
],
'include_dirs': [
'..',
'<(INTERMEDIATE_DIR)',
],
'sources': [
Cross platform low level file IO wrappers Rename fd_io to file_io, and ReadFD to ReadFile, etc. file_io.cc is the higher level versions that call the basic ReadFile/WriteFile and then file_io_posix.cc and file_io_win.cc are the implementations of those functions. The Windows path is as yet untested, lacking the ability to link the test binary. R=cpu@chromium.org, mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/811823003
2014-12-17 14:35:18 -08:00
'file/file_io.cc',
'file/file_io.h',
'file/file_io_posix.cc',
'file/file_io_win.cc',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/file_reader.cc',
'file/file_reader.h',
Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet(). These methods perform common error checking. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/913223008
2015-02-18 18:22:39 -05:00
'file/file_seeker.cc',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/file_seeker.h',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
'file/file_writer.cc',
'file/file_writer.h',
Add FileReaderInterface. Move StringFileWriter to StringFile and implement the new interface. The upcoming minidump reader will get minidump data from a FileReaderInterface. For ease of testing, a string-based implementation is provided. There wasn’t a good reason to have a separate StringFileReader and StringFileWriter, so I combined them into a single StringFile. TEST=util_test StringFile.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/936153002
2015-02-18 14:15:38 -05:00
'file/string_file.cc',
'file/string_file.h',
Add CheckedMachAddressRange and its test. TEST=util_test CheckedMachAddressRange.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/513453002
2014-08-28 13:47:28 -04:00
'mac/checked_mach_address_range.h',
Revert "Drop 10.5 support: use ServiceManagement.framework directly." This reverts commit 63fd3ae47d2513ef4390c3d8c0dde3fa95152480. SMJobRemove() still performs a 1-second sleep() when its |wait| parameter is true. Radar 18398683 is filed. In the mean time, the launchd-based implementation of these functions does not have this undesirable property. The comments have been revised to not reflect operating systems before Mac OS X 10.6. Comments describing bugs in earlier 10.10 seeds that have since been fixed have been removed. TEST=util_test Launchd.*:ServiceManagement.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/579083003
2014-09-22 13:11:40 -04:00
'mac/launchd.h',
'mac/launchd.mm',
Add mac_util, including MacOSXMinorVersion(), MacOSXVersion(), and MacModelAndBoard(), along with their tests. TEST=util_test MacUtil.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/473023002
2014-08-15 22:33:14 -07:00
'mac/mac_util.cc',
'mac/mac_util.h',
Add ServiceManagement*() and their tests. TEST=util_test ServiceManagement R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467923003
2014-08-15 22:30:24 -07:00
'mac/service_management.cc',
'mac/service_management.h',
Add wrappers around getxattr() and setxattr(). R=mark@chromium.org TEST=util_test --gtest_filter=Xattr.* Review URL: https://codereview.chromium.org/791493009
2014-12-30 17:39:27 -05:00
'mac/xattr.cc',
'mac/xattr.h',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'mach/child_port.defs',
Add ChildPortHandshake and its test. ChildPortHandshake is the most generic system yet to allow child processes to provide their parents with Mach rights. These are ordinarily expected to be send rights to the children’s own task ports, or send rights to servers that the children hold receive rights to. This updates DEPS to pull mini_chromium 1d3523dbda93, which includes base::mac::ScopedMachPortSet. TEST=util_test ChildPortHandshake.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/756603003
2014-11-25 14:56:05 -05:00
'mach/child_port_handshake.cc',
'mach/child_port_handshake.h',
Add ChildPortServer, a MachMessageServer::Interface implementation for the child_port subsystem. Common routines shared with the ExcServer family of classes have been moved to a new file, where they can be shared between different MachMessageServer::Interface implementations. TEST=util_test ChildPortServer.*:MachMessageUtil.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/754123002
2014-11-25 14:29:46 -05:00
'mach/child_port_server.cc',
'mach/child_port_server.h',
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
'mach/child_port_types.h',
Add CompositeMachMessageServer and its test. TEST=util_test CompositeMachMessageServer* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/781823002
2014-12-04 16:45:02 -05:00
'mach/composite_mach_message_server.cc',
'mach/composite_mach_message_server.h',
Add exc_client_variants (UniversalExceptionRaise()) and its test. This also puts kMachExceptionCodes into mach_extensions.h, because a form of MACH_EXCEPTION_CODES that’s the right type (exception_behavior_t) has now shown its use in more than one file. TEST=util_test ExcClientVariants.UniversalExceptionRaise R=rsesek@chromium.org Review URL: https://codereview.chromium.org/567283002
2014-09-16 09:48:01 -04:00
'mach/exc_client_variants.cc',
'mach/exc_client_variants.h',
Add exc_server_variants including UniversalMachExcServer and its test. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/545053003
2014-09-10 17:29:07 -04:00
'mach/exc_server_variants.cc',
'mach/exc_server_variants.h',
Add exception_behaviors and its test. This includes the functions ExceptionBehaviorHasState(), ExceptionBehaviorHasIdentity(), ExceptionBehaviorHasMachExceptionCodes(), and ExceptionBehaviorBasic(). TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565793005
2014-09-16 17:32:35 -04:00
'mach/exception_behaviors.cc',
'mach/exception_behaviors.h',
Add ExceptionPorts and its test. This is a unified interface to {thread,task,host}_{get,set}_exception_ports(). TEST=util_test ExceptionPorts.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/549023005
2014-09-16 17:36:33 -04:00
'mach/exception_ports.cc',
'mach/exception_ports.h',
Accept non-fatal resource exceptions without generating crash reports. This adds IsExceptionNonfatalResource() and its test, and uses it in crashpad_handler. When non-fatal resource exceptions are encountered, no crash report is generated. crashpad_handler swallows these exceptions. Alternatively, it could allow them to be sent to the system’s host-level resource exception handler, normally com.apple.ReportCrash.root, which would allow them to be processed in the same way as when Crashpad is not in use. I’m not sure which option is better. I chose to swallow them because there doesn’t appear to be much value in letting com.apple.ReportCrash.root and spindump look at them. This also moves ExcCrashRecoverOriginalException() to the new file as a sibling of IsExceptionNonfatalResource(). This provides better organization. BUG=crashpad:35, chromium:474163, chromium:474326 TEST=crashpad_util_test ExceptionTypes.IsExceptionNonfatalResource R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1066243002
2015-04-08 17:46:09 -04:00
'mach/exception_types.cc',
'mach/exception_types.h',
Add exc_client_variants (UniversalExceptionRaise()) and its test. This also puts kMachExceptionCodes into mach_extensions.h, because a form of MACH_EXCEPTION_CODES that’s the right type (exception_behavior_t) has now shown its use in more than one file. TEST=util_test ExcClientVariants.UniversalExceptionRaise R=rsesek@chromium.org Review URL: https://codereview.chromium.org/567283002
2014-09-16 09:48:01 -04:00
'mach/mach_extensions.cc',
Add exc_server_variants including UniversalMachExcServer and its test. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/545053003
2014-09-10 17:29:07 -04:00
'mach/mach_extensions.h',
Move mach_message_util.* to mach_message.*. A subsequent change will add MachMessageWithDeadline(), a mach_msg() wrapper. Conceptually, it makes sense to include that function in this file family. Since this file family now contains a mach_msg() wrapper, it makes sense to rename it mach_message and lose the _util suffix. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/772133004
2014-12-02 17:02:32 -05:00
'mach/mach_message.cc',
'mach/mach_message.h',
Add MachMessageServer and its test. MachMessageServer is much like mach_msg_server() and mach_msg_server_once(), but with a C++ interface and with a number of deficiencies corrected. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/544393002
2014-09-08 21:06:34 -04:00
'mach/mach_message_server.cc',
'mach/mach_message_server.h',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'mach/notify_server.cc',
'mach/notify_server.h',
Add ScopedTaskSuspend and its test. This also introduces ScopedFcntlFlags. TEST=util_test ScopedTaskSuspend.*:ScopedFcntlFlags.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/649693002
2014-10-13 18:05:21 -04:00
'mach/scoped_task_suspend.cc',
'mach/scoped_task_suspend.h',
Add SymbolicConstantsMach and its test. TEST=util_test SymbolicConstantsMach.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/563383002
2014-09-16 11:00:51 -04:00
'mach/symbolic_constants_mach.cc',
'mach/symbolic_constants_mach.h',
Add TaskForPID(). This also transitions exception_port_tool to use TaskForPID(), so that it can be safely used as a setuid executable without giving permission to operate on any process on the system. It is difficult to provide a test for this function, because it must be running setuid root in order to do anything interesting. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/728973002
2014-11-14 17:56:17 -05:00
'mach/task_for_pid.cc',
'mach/task_for_pid.h',
Add TaskMemory, which can read another Mach task’s memory, and its test. This also adds MachErrorMessage(), a test-only function that’s a dependency of TaskMemory’s test, and related test-only error message functions. TEST=util_test TaskMemory.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/438993002
2014-08-03 18:48:40 -04:00
'mach/task_memory.cc',
'mach/task_memory.h',
Add, test, and use clock utilities. This includes ClockMonotonicNanoseconds() and SleepNanoseconds(). SleepNanoseconds() is like base::PlatformThread::Sleep(), but PlatformThread is not in mini_chromium and I’m not keen on adding it because I’m not sold on the interface. I’m not convinced Sleep() belongs there, and I don’t want to have to bring all of base::Time* along for the ride. TEST=util_test Clock.*:MachMessageServer.*:ServiceManagement.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/597533002
2014-09-24 14:08:48 -04:00
'misc/clock.h',
'misc/clock_mac.cc',
win: clock implementation R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/807973002
2014-12-17 10:45:43 -08:00
'misc/clock_posix.cc',
'misc/clock_win.cc',
Add InitializationStateDcheck, its base class, and their tests. TEST=util_test InitializationState* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/465103002
2014-08-14 09:51:26 -07:00
'misc/initialization_state.h',
'misc/initialization_state_dcheck.cc',
'misc/initialization_state_dcheck.h',
Implement ModuleSnapshotWin::UUID Reads CodeView PDB GUID from Debug Directory of PE header. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1311003003 .
2015-09-01 09:32:09 -07:00
'misc/pdb_structures.cc',
'misc/pdb_structures.h',
Add ScopedForbidReturn and its test. Use ScopedForbidReturn in ProcessReader::InitializeThreads(). TEST=util_test ScopedForbidReturn*.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/493203005
2014-08-26 16:50:08 -04:00
'misc/scoped_forbid_return.cc',
'misc/scoped_forbid_return.h',
Add symbolic_constants_posix and its test. This includes the functions SignalToString() and StringToSignal(). TEST=util_test SymbolicConstantsPOSIX.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565453002
2014-09-10 17:30:21 -04:00
'misc/symbolic_constants_common.h',
Allow exception forwarding to the system’s native crash reporter to be disabled. ClientInfo::set_system_crash_reporter_forwarding() can be used to disable forwarding. The first module that is found with a non-default value in this field will dictate whether forwarding is enabled or disabled. It is possible to enable or disable reporting with this call, as well as reset it to default, which will allow later modules a chance to influence the behavior. ClientInfo::set_crashpad_handler_behavior() is also provided, which can be used to disable Crashpad’s handling of the exception. Most users should not call this, but should use Settings::SetUploadsEnabled() instead. TEST=crashpad_snapshot_test \ CrashpadInfoClientOptions.*:MachOImageReader.Self_DyldImages; \ run_with_crashpad --handler crashpad_handler \ -a --database=/tmp/crashpad_db \ -a --url=https://clients2.google.com/cr/staging_report \ -a --annotation=prod=crashpad \ -a --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Review URL: https://codereview.chromium.org/997713002
2015-03-11 17:07:11 -04:00
'misc/tri_state.h',
Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/430003003
2014-08-01 14:39:55 -04:00
'misc/uuid.cc',
'misc/uuid.h',
Add HTTPBodyStream interface, three concrete implementations, and their tests. BUG=415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/669153006
2014-10-24 15:04:25 -04:00
'net/http_body.cc',
'net/http_body.h',
Add HTTPTransport, a Mac implementation, and an end-to-end test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/692963002
2014-10-31 12:17:32 -04:00
'net/http_headers.cc',
'net/http_headers.h',
Add HTTPMultipartBuilder and its test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/681303003
2014-10-29 19:13:24 -04:00
'net/http_multipart_builder.cc',
'net/http_multipart_builder.h',
Add HTTPTransport, a Mac implementation, and an end-to-end test. BUG=https://crbug.com/415544 R=mark@chromium.org Review URL: https://codereview.chromium.org/692963002
2014-10-31 12:17:32 -04:00
'net/http_transport.cc',
'net/http_transport.h',
'net/http_transport_mac.mm',
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
'net/http_transport_win.cc',
win: make CrashpadInfo retrievable The main goal was to get the beginnings of module iteration and retrieval of CrashpadInfo in snapshot. The main change for that is to move crashpad_info_client_options[_test] down out of mac/. This also requires adding some of the supporting code of snapshot in ProcessReaderWin, ProcessSnapshotWin, and ModuleSnapshotWin. These are partially copied from Mac or stubbed out with lots of TODO annotations. This is a bit unfortunate, but seemed like the most productive way to make progress incrementally. That is, it's mostly placeholder at the moment, but hopefully has the right shape for things to come. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1052813002
2015-05-01 13:48:23 -07:00
'numeric/checked_address_range.cc',
'numeric/checked_address_range.h',
Add CheckedRange<> and its test. TEST=util_test CheckedRange R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467113002
2014-08-15 10:22:37 -07:00
'numeric/checked_range.h',
Add InRangeCast<> and its test. InRangeCast<> is similar to base::saturated_cast<>, but it allows the caller to specify the value to be returned in the event that the source value can’t be converted to the destination data type without data loss. TEST=util_test InRangeCast R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467103002
2014-08-14 16:00:44 -07:00
'numeric/in_range_cast.h',
Add uint128_struct and its test. This will be used in the upcoming Minidump context structures. This also updates mini_chromium to ba9b15f1b6a7 to pick up: ba9b15f1b6a7 Make bit_cast available in C++11 mode. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/583283003
2014-09-22 15:46:00 -04:00
'numeric/int128.h',
Add InRangeCast<> and its test. InRangeCast<> is similar to base::saturated_cast<>, but it allows the caller to specify the value to be returned in the event that the source value can’t be converted to the destination data type without data loss. TEST=util_test InRangeCast R=rsesek@chromium.org Review URL: https://codereview.chromium.org/467103002
2014-08-14 16:00:44 -07:00
'numeric/safe_assignment.h',
CloseMultipleNowOrOnExec(): promote out of test. This function will be useful in upcoming non-test code. Because the first Crashpad client that wants a Crashpad handler will now be responsible for starting the handler process, this will prevent file descriptors from leaking to the handler process. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/819483002
2014-12-19 16:42:34 -05:00
'posix/close_multiple.cc',
'posix/close_multiple.h',
Add CloseStdinAndStdout(). There will be no reason to leave the handler process connected to its invoker’s stdin or stdout. On the other hand, I’m currently leaving it connected to the original and stderr, as these may be useful for diagnostics. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/818573002
2014-12-19 14:20:20 -05:00
'posix/close_stdio.cc',
'posix/close_stdio.h',
Add DropPrivileges(). DropPrivileges() is used in exception_port_tool, so that when it is installed as a setuid executable, it only uses elevated privileges to obtain a task port for its -p option, and then relinquishes those privileges. It is difficult to provide a test for this function, because it must be running setuid or setgid in order to do anything interesting. However, the function contains its own CHECKs to verify that it behaves properly. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/727053002
2014-11-14 18:44:19 -05:00
'posix/drop_privileges.cc',
'posix/drop_privileges.h',
Move some parts of ProcessReader (in snapshot) to ProcessInfo (in util). Also, move ProcessArgumentsForPID() into ProcessInfo. This change prepares for a TaskForPID() implementation that’s capable of operating correctly in a setuid root executable. TaskForPID() belongs in util/mach, but for its permission checks, it must access some process properties that were previously fetched by ProcessReader in snapshot. util can’t depend on snapshot. The generic util-safe process information bits (Is64Bit(), ProcessID(), ParentProcessID(), and StartTime()) are moved from ProcessReader to ProcessInfo (in util), where the current ProcessReader can use it (as it’s OK for snapshot to depend on util), and the future TaskForPID() in util can also use it. ProcessInfo also contains other methods that TaskForPID() will use, providing access to the credentials that the target process holds. ProcessArgumentsForPID() is related, and is also now a part of ProcessInfo. TEST=snapshot_test, util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/727973002
2014-11-14 17:54:42 -05:00
'posix/process_info.h',
'posix/process_info_mac.cc',
Add symbolic_constants_posix and its test. This includes the functions SignalToString() and StringToSignal(). TEST=util_test SymbolicConstantsPOSIX.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/565453002
2014-09-10 17:30:21 -04:00
'posix/symbolic_constants_posix.cc',
'posix/symbolic_constants_posix.h',
Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/430003003
2014-08-01 14:39:55 -04:00
'stdlib/cxx.h',
Improve map insertion operations. Add MapInsertOrReplace<>() to insert a key-value pair into a map if the key is not already present, or replace the existing value for key if the key is present. The original value can optionally be returned to the caller in this case. Map insertions now use either MapInsertOrReplace<>() or std::map<>::insert() directly. Use MapInsertOrReplace<>() when the map should be updated to contain a mapping from a key to a value regardless of whether the key is already present. Use std::map<>::insert() to insert a mapping from a key to a value without replacing any existing mapping from a key, if present. If it is important to know whether an existing mapping from a key was present, use the returned std::pair<>.second. If it is important to know the existing value, use the returned std::pair<>.first->second. This change has a slight positive impact on performance. TEST=crashpad_util_test MapInsert.MapInsertOrReplace and others BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1044273002
2015-03-31 14:29:32 -04:00
'stdlib/map_insert.h',
Add CFPropertyToLaunchData() and its test. TEST=util_test Launchd R=rsesek@chromium.org Review URL: https://codereview.chromium.org/438673003
2014-08-03 18:53:10 -04:00
'stdlib/objc.h',
Add most of ProcessReader and its test. TEST=util_test ProcessReader.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/491963002
2014-08-25 17:51:09 -04:00
'stdlib/pointer_container.h',
Add string_number_conversion and its test. This includes the StringToNumber() function, both int and unsigned int variants. Similar functionality is available in base, but it is unsuitable for applications where a number’s base may be determined based on an "0x" or "0X" prefix (hexadecimal) or an "0" prefix (octal). TEST=util_test StringNumberConversion.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/557033002
2014-09-10 15:30:11 -04:00
'stdlib/string_number_conversion.cc',
'stdlib/string_number_conversion.h',
Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/430003003
2014-08-01 14:39:55 -04:00
'stdlib/strlcpy.cc',
'stdlib/strlcpy.h',
Add strnlen() wrapper and its test. TEST=util_test strnlen.strnlen R=rsesek@chromium.org Review URL: https://codereview.chromium.org/514253002
2014-08-28 14:38:27 -04:00
'stdlib/strnlen.cc',
'stdlib/strnlen.h',
CrashpadClient::StartHandler(): accept database, url, and annotations arguments. This makes it easier for clients to start the Crashpad handler, instead of requiring them to know how to construct arguments for the handler themselves. Note in the TEST that -a is no longer required. TEST=run_with_crashpad --handler crashpad_handler \ --database=/tmp/crashpad_db \ --url=https://clients2.google.com/cr/staging_report \ --annotation=prod=crashpad \ --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1001993002
2015-03-12 14:28:19 -04:00
'string/split_string.cc',
'string/split_string.h',
Add Semaphore::TimedWait(). This also splits the per-OS Semaphore methods into their own files. TEST=util_test Semaphore.* R=rsesek@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/909263002
2015-02-10 17:01:58 -05:00
'synchronization/semaphore_mac.cc',
'synchronization/semaphore_posix.cc',
'synchronization/semaphore_win.cc',
Add Semaphore and its test, and use it where semaphores are needed. TEST=util_test Semaphore.*:ProcessReader.*:ExceptionPorts.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/589243003
2014-09-24 13:32:31 -04:00
'synchronization/semaphore.h',
Move thread from test/ to util/thread/. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1134943003
2015-05-13 14:05:57 -04:00
'thread/thread.cc',
'thread/thread.h',
Add ThreadLogMessages and its test. This updates mini_chromium to 91ea4908ffd74d9c886bd2f8ccbfae6d31c499af. The last five commits listed here are required to support this change. The mini_chromium update includes: c1745a924c5c Fix paths to atomicops files in base.gyp from 2f02dcc73536 108e9247189c Add #include of <unistd.h> to close_nocancel.cc 6e4f98a9edf8 Add logging::SetLogMessageHandler() 4063fcb8f460 Add base::ThreadLocalStorage 4870f18a33a6 Add base::LazyInstance 0d31b1f3a289 Fix base/memory/aligned_memory.h for MSVC 91ea4908ffd7 base/logging.h: DCHECK() should always reference its condition BUG=crashpad:26 TEST=crashpad_util_test ThreadLogMessages.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1041643003
2015-03-30 14:51:34 -04:00
'thread/thread_log_messages.cc',
'thread/thread_log_messages.h',
Move thread from test/ to util/thread/. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1134943003
2015-05-13 14:05:57 -04:00
'thread/thread_posix.cc',
'thread/thread_win.cc',
win: make CrashpadInfo retrievable The main goal was to get the beginnings of module iteration and retrieval of CrashpadInfo in snapshot. The main change for that is to move crashpad_info_client_options[_test] down out of mac/. This also requires adding some of the supporting code of snapshot in ProcessReaderWin, ProcessSnapshotWin, and ModuleSnapshotWin. These are partially copied from Mac or stubbed out with lots of TODO annotations. This is a bit unfortunate, but seemed like the most productive way to make progress incrementally. That is, it's mostly placeholder at the moment, but hopefully has the right shape for things to come. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1052813002
2015-05-01 13:48:23 -07:00
'win/address_types.h',
'win/checked_win_address_range.h',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'win/exception_handler_server.cc',
'win/exception_handler_server.h',
win: Retrieve module version/type information Refactor version retrieval from system snapshot to use when retrieving the module version information. Follows https://codereview.chromium.org/1133203002/. R=cpu@chromium.org, rsesek@chromium.org TBR=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1126273003
2015-05-14 17:43:49 -07:00
'win/module_version.cc',
'win/module_version.h',
win: Implement exception snapshot Refactor some of the NT internals helpers and cpu_context to share between the thread and exception snapshot code. Add test that runs crashing child and validates the exception in the snapshot. R=mark@chromium.org, cpu@chromium.org, rsesek@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1126413008 .
2015-08-18 12:25:19 -07:00
'win/nt_internals.cc',
'win/nt_internals.h',
win: Add implementation of ProcessInfo This is as a precursor to ProcessReader. Some basic functionality is included for now, with more to be added later as necessary. The PEB code is pretty icky -- walking the doubly-linked list in the target's address space is cumbersome. The alternative is to use EnumProcessModules. That would work but: 1) needs different APIs for XP and Vista 64+ 2) retrieves modules in memory-location order, rather than initialization order. I felt retrieving them in initialization order might be useful when detecting third party DLL injections. In the end, we may want to make both orders available. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/977003003
2015-03-05 22:07:38 -08:00
'win/process_info.cc',
'win/process_info.h',
win: Support reading process info cross-bitness This only works 64->64, 32->32, and 64->32. We shouldn't have a need for 32->64. It will also currently not work if the crash service is running on Wow64 itself (that is, 32->32, but on an x64 OS). We should also be able to avoid needing that. Primarily, this change templatizes the winternl.h process structure types on word size, so the PEB can be read in a foreign bitsize process. This also happens to resolve using void* as pointer values into foreign processes, as they're now all either DWORD or DWORD64 depending on which traits class is used. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/981393003
2015-03-09 16:37:43 -07:00
'win/process_structs.h',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'win/registration_protocol_win.cc',
'win/registration_protocol_win.h',
win: Add Scoped...Handle Intended for future use to implement util/file/file_writer. There's a similar class in base: https://code.google.com/p/chromium/codesearch#chromium/src/base/win/scoped_handle.h&l=28 However (perhaps for historical reasons) it does not distinguish between the possible types of HANDLEs which have different invalid values, resulting in a need to copy a bunch of code rather than simply using ScopedGeneric. Instead, distinguish between the types so the caller can use the correct one. Refs: http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx http://msdn.microsoft.com/en-us/magazine/cc302328.aspx (Figure 2) R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/813873004
2014-12-18 09:51:20 -08:00
'win/scoped_handle.cc',
'win/scoped_handle.h',
win: add equivalent of gettimeofday R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/940793002
2015-02-20 11:35:04 -08:00
'win/time.cc',
'win/time.h',
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
],
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'conditions': [
['OS=="mac"', {
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'conditions': [
['GENERATOR=="ninja"', {
# ninja’s rules can’t deal with sources that have paths relative
# to environment variables like SDKROOT. Copy the .defs files out
# of SDKROOT and into a place they can be referenced without any
# environment variables.
'copies': [
{
'destination': '<(INTERMEDIATE_DIR)/util/mach',
'files': [
'$(SDKROOT)/usr/include/mach/exc.defs',
'$(SDKROOT)/usr/include/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'$(SDKROOT)/usr/include/mach/notify.defs',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
],
},
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'sources': [
'<(INTERMEDIATE_DIR)/util/mach/exc.defs',
'<(INTERMEDIATE_DIR)/util/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'<(INTERMEDIATE_DIR)/util/mach/notify.defs',
Add the child_port Mach subsystem. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/752243002
2014-11-24 15:48:10 -05:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
}, { # else: GENERATOR!="ninja"
# The Xcode generator does copies after rules, so the above trick
# won’t work, but its rules tolerate sources with SDKROOT-relative
# paths.
'sources': [
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'$(SDKROOT)/usr/include/mach/exc.defs',
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'$(SDKROOT)/usr/include/mach/mach_exc.defs',
Add NotifyServer and its test. TEST=util_test NotifyServerTest.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/804633002
2014-12-16 14:10:16 -05:00
'$(SDKROOT)/usr/include/mach/notify.defs',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
}],
],
'rules': [
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
{
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'rule_name': 'mig',
'extension': 'defs',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'inputs': [
'mach/mig.py',
],
'outputs': [
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)User.c',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)Server.c',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT).h',
'<(INTERMEDIATE_DIR)/util/mach/<(RULE_INPUT_ROOT)Server.h',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
'action': [
Use GYP rules instead of actions to run mig. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/793323003
2014-12-11 11:27:18 -05:00
'python', '<@(_inputs)', '<(RULE_INPUT_PATH)', '<@(_outputs)'
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
'process_outputs_as_sources': 1,
},
Run mig to generate the exc and mach_exc interfaces. mach_exc is necessary because libSystem doesn’t contain this at all. exc is necessary too, however: the copy in libSystem relies on the server callbacks being externally defined symbols, which is cheesey. Additionally, some Crashpad code wants to call internal validation (“check”) routines that are not normally accessible to outside callers via the copy of exc in libSystem, but they are made accessible here by processing mig’s output in this Python script. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/541213002
2014-09-05 13:27:06 -04:00
],
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
'$(SDKROOT)/System/Library/Frameworks/IOKit.framework',
handler/mac: Log a warning when an exception message has a suspicious origin. This adds AuditPIDFromMachMessageTrailer() to get the process ID of a Mach message’s sender. Exception messages are considered suspicious when not sent by the kernel or the exception process. TEST=crashpad_util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1001943002
2015-03-12 14:00:38 -04:00
'$(SDKROOT)/usr/lib/libbsm.dylib',
Superficial gyp changes to not immediately error out on Windows Just guarding the usage of $SDKROOT so that ninja doesn't error out on invalid $ escape on parsing. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/620553004
2014-09-30 13:11:04 -07:00
],
},
}],
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
['OS=="win"', {
'link_settings': {
'libraries': [
win: Add UUID::InitializeFromSystemUUID(). The new call is also used in CrashReportDatabaseWin::PrepareNewCrashReport(). Previously, that method used the UUID::InitializeFromBytes() constructor. That actually caused various fields of the UUID to be byte-swapped so that the ::UUID and crashpad::UUID would be different UUIDs. Although a UUID is mostly random, the version field in data_3 is used as a namespace and should be 4 for random UUIDs, and this was not the case under swapping. TEST=crashpad_util_test UUID.FromSystem BUG=crashpad:1 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1004913004
2015-03-13 13:53:38 -04:00
'-lrpcrt4.lib',
win: Add implementation of HTTPTransport based on WinHTTP (There's also https://codereview.chromium.org/854363006/ based on WinInet, I'm still a little uncertain which is preferable here.) R=cpu@chromium.org, mark@chromium.org, rsesek@chromium.org, ananta@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/852213004
2015-01-26 13:31:35 -08:00
'-lwinhttp.lib',
],
},
}],
Run mig to generate the exc and mach_exc interfaces. mach_exc is necessary because libSystem doesn’t contain this at all. exc is necessary too, however: the copy in libSystem relies on the server callbacks being externally defined symbols, which is cheesey. Additionally, some Crashpad code wants to call internal validation (“check”) routines that are not normally accessible to outside callers via the copy of exc in libSystem, but they are made accessible here by processing mig’s output in this Python script. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/541213002
2014-09-05 13:27:06 -04:00
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
},
win: Add implementation of ProcessInfo This is as a precursor to ProcessReader. Some basic functionality is included for now, with more to be added later as necessary. The PEB code is pretty icky -- walking the doubly-linked list in the target's address space is cumbersome. The alternative is to use EnumProcessModules. That would work but: 1) needs different APIs for XP and Vista 64+ 2) retrieves modules in memory-location order, rather than initialization order. I felt retrieving them in initialization order might be useful when detecting third party DLL injections. In the end, we may want to make both orders available. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/977003003
2015-03-05 22:07:38 -08:00
],
Introduce MinidumpWritable, its dependencies, and their tests. MinidumpWritable is the base class for all minidump-writing operations. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/432003005
2014-08-01 12:48:28 -04:00
}
Reference in New Issue Copy Permalink