2015-03-31 17:06:28 -04:00
|
|
|
# Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
|
|
|
#
|
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
|
#
|
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
#
|
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
'includes': [
|
|
|
|
|
'../build/crashpad.gypi',
|
|
|
|
|
],
|
|
|
|
|
'targets': [
|
|
|
|
|
{
|
|
|
|
|
'target_name': 'crashpad_util_test',
|
|
|
|
|
'type': 'executable',
|
|
|
|
|
'dependencies': [
|
|
|
|
|
'util.gyp:crashpad_util',
|
win: Crash handler server
This replaces the registration server, and adds dispatch to a delegate
on crash requests.
(As you are already aware) we went around in circles on trying to come
up with a slightly-too-fancy threading design. All of them seemed to
have problems when it comes to out of order events, and orderly
shutdown, so I've gone back to something not-too-fancy.
Two named pipe instances (that clients connect to) are created. These
are used only for registration (which should take <1ms), so 2 should be
sufficient to avoid any waits. When a client registers, we duplicate
an event to it, which is used to signal when it wants a dump taken.
The server registers threadpool waits on that event, and also on the
process handle (which will be signalled when the client process exits).
These requests (in particular the taking of the dump) are serviced
on the threadpool, which avoids us needing to manage those threads,
but still allows parallelism in taking dumps. On process termination,
we use an IO Completion Port to post a message back to the main thread
to request cleanup. This complexity is necessary so that we can
unregister the threadpool waits without being on the threadpool, which
we need to do synchronously so that we can be sure that no further
callbacks will execute (and expect to have the client data around
still).
In a followup, I will readd support for DumpWithoutCrashing -- I don't
think it will be too difficult now that we have an orderly way to
clean up client records in the server.
R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org
BUG=crashpad:1,crashpad:45
Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
|
|
|
'../client/client.gyp:crashpad_client',
|
2015-03-31 17:06:28 -04:00
|
|
|
'../compat/compat.gyp:crashpad_compat',
|
2020-05-06 20:39:19 -04:00
|
|
|
'../test/test.gyp:crashpad_googlemock_main',
|
test: Move util/test to its own top-level directory, test.
After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib
to “hide” in util/util_test.gyp. All of util/test is moved to its own
top-level directory, test, which all other test code is allowed to
depend on. test, too, is allowed to depend on all other non-test code.
In a future change, when crashpad_util_test_lib gains a dependency on
crashpad_client, it won’t look so weird for something in util (even
though it’s in util/test) to depend on something in client, because the
thing that needs to depend on client will live in test, not util.
BUG=crashpad:33
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
|
|
|
'../test/test.gyp:crashpad_test',
|
2020-05-06 20:39:19 -04:00
|
|
|
'../third_party/googletest/googlemock.gyp:googlemock',
|
|
|
|
|
'../third_party/googletest/googletest.gyp:googletest',
|
2019-04-29 14:28:53 -07:00
|
|
|
'../third_party/lss/lss.gyp:lss',
|
2015-03-31 17:06:28 -04:00
|
|
|
'../third_party/mini_chromium/mini_chromium.gyp:base',
|
2017-02-15 19:54:19 -05:00
|
|
|
'../third_party/zlib/zlib.gyp:zlib',
|
2015-03-31 17:06:28 -04:00
|
|
|
],
|
|
|
|
|
'include_dirs': [
|
|
|
|
|
'..',
|
|
|
|
|
],
|
|
|
|
|
'sources': [
|
2017-03-16 10:52:27 -04:00
|
|
|
'file/delimited_file_reader_test.cc',
|
2017-10-16 12:31:13 -07:00
|
|
|
'file/directory_reader_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'file/file_io_test.cc',
|
util/file: Handle oversized reads and writes gracefully
file_io and the FileReader family had a few loose ends regarding big
reads and writes. It’s not likely that we’ve experienced these
conditions yet, but they’d be likely to appear in a potential future
involving full memory dumps. This specifies the behavior with large
reads and writes, consolidates some logic, and improves some interfaces.
ReadFile() should always return without retrying after a short read, and
in fact does return after short reads since 00b64427523b. It is
straightforward to limit the maximum read size based on a parameter
limitation of the underlying operation, or a limitation of the type used
for FileOperationResult.
In contrast, WriteFile() should always retry after a short write,
including a write shortened because of a parameter limitation of the
underlying operation, or a limitation of the type used for
FileOperationResult. This allows its return value to be simplified to a
“bool”.
The platform-specific WriteFile() code has been moved to
internal::NativeWriteFile(), and the platform-independent loop that
retries following a short write has been refactored into
internal::WriteAllInternal so that it can be used by a new test.
The platform-agnostic ReadFileExactlyInternal() implementation has been
refactored into internal::ReadExactlyInternal so that it can be used by
a new test and by FileReaderInterface::ReadExactly(), which had a nearly
identical implementation.
Test: crashpad_util_test FileIO.ReadExactly_*:FileIO.WriteAll_*:FileReader.ReadExactly_*
Change-Id: I487450322ab049c6f2acd4061ea814037cc9a864
Reviewed-on: https://chromium-review.googlesource.com/456824
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-03-21 15:08:05 -04:00
|
|
|
'file/file_reader_test.cc',
|
2017-10-16 12:31:13 -07:00
|
|
|
'file/filesystem_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'file/string_file_test.cc',
|
2017-06-12 12:59:27 -07:00
|
|
|
'linux/auxiliary_vector_test.cc',
|
2017-04-25 08:12:49 -07:00
|
|
|
'linux/memory_map_test.cc',
|
2017-07-24 14:45:39 -04:00
|
|
|
'linux/proc_stat_reader_test.cc',
|
2019-04-29 14:28:53 -07:00
|
|
|
'linux/proc_task_reader_test.cc',
|
2017-12-11 10:23:17 -08:00
|
|
|
'linux/ptrace_broker_test.cc',
|
2017-09-22 09:14:52 -07:00
|
|
|
'linux/ptracer_test.cc',
|
2017-04-07 11:48:04 -07:00
|
|
|
'linux/scoped_ptrace_attach_test.cc',
|
2019-05-02 13:55:08 -07:00
|
|
|
'linux/socket_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'mac/launchd_test.mm',
|
|
|
|
|
'mac/mac_util_test.mm',
|
|
|
|
|
'mac/service_management_test.mm',
|
|
|
|
|
'mac/xattr_test.cc',
|
|
|
|
|
'mach/child_port_handshake_test.cc',
|
|
|
|
|
'mach/child_port_server_test.cc',
|
|
|
|
|
'mach/composite_mach_message_server_test.cc',
|
|
|
|
|
'mach/exc_client_variants_test.cc',
|
|
|
|
|
'mach/exc_server_variants_test.cc',
|
|
|
|
|
'mach/exception_behaviors_test.cc',
|
|
|
|
|
'mach/exception_ports_test.cc',
|
2015-04-08 17:46:09 -04:00
|
|
|
'mach/exception_types_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'mach/mach_extensions_test.cc',
|
|
|
|
|
'mach/mach_message_server_test.cc',
|
|
|
|
|
'mach/mach_message_test.cc',
|
|
|
|
|
'mach/notify_server_test.cc',
|
|
|
|
|
'mach/scoped_task_suspend_test.cc',
|
|
|
|
|
'mach/symbolic_constants_mach_test.cc',
|
2019-01-03 13:36:02 -05:00
|
|
|
'misc/arraysize_test.cc',
|
2018-02-08 16:25:22 -08:00
|
|
|
'misc/capture_context_test.cc',
|
|
|
|
|
'misc/capture_context_test_util.h',
|
|
|
|
|
'misc/capture_context_test_util_linux.cc',
|
|
|
|
|
'misc/capture_context_test_util_mac.cc',
|
|
|
|
|
'misc/capture_context_test_util_win.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'misc/clock_test.cc',
|
2017-04-27 15:08:17 -04:00
|
|
|
'misc/from_pointer_cast_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'misc/initialization_state_dcheck_test.cc',
|
|
|
|
|
'misc/initialization_state_test.cc',
|
2017-04-03 13:53:11 -04:00
|
|
|
'misc/paths_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'misc/scoped_forbid_return_test.cc',
|
2015-11-16 13:39:01 -05:00
|
|
|
'misc/random_string_test.cc',
|
2018-06-11 09:38:24 -07:00
|
|
|
'misc/range_set_test.cc',
|
2017-06-19 15:56:07 -07:00
|
|
|
'misc/reinterpret_bytes_test.cc',
|
2017-11-06 14:01:04 -08:00
|
|
|
'misc/time_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'misc/uuid_test.cc',
|
2017-02-15 19:54:19 -05:00
|
|
|
'net/http_body_gzip_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'net/http_body_test.cc',
|
|
|
|
|
'net/http_body_test_util.cc',
|
|
|
|
|
'net/http_body_test_util.h',
|
|
|
|
|
'net/http_multipart_builder_test.cc',
|
|
|
|
|
'net/http_transport_test.cc',
|
2017-09-28 09:53:39 -07:00
|
|
|
'net/url_test.cc',
|
2015-05-01 13:48:23 -07:00
|
|
|
'numeric/checked_address_range_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'numeric/checked_range_test.cc',
|
|
|
|
|
'numeric/in_range_cast_test.cc',
|
|
|
|
|
'numeric/int128_test.cc',
|
|
|
|
|
'posix/process_info_test.cc',
|
2017-03-28 12:21:43 -04:00
|
|
|
'posix/scoped_mmap_test.cc',
|
2017-03-01 10:00:59 -05:00
|
|
|
'posix/signals_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'posix/symbolic_constants_posix_test.cc',
|
2018-12-20 13:12:55 -08:00
|
|
|
'process/process_memory_mac_test.cc',
|
2017-09-26 12:52:41 -07:00
|
|
|
'process/process_memory_range_test.cc',
|
|
|
|
|
'process/process_memory_test.cc',
|
2015-12-08 15:38:17 -05:00
|
|
|
'stdlib/aligned_allocator_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'stdlib/map_insert_test.cc',
|
|
|
|
|
'stdlib/string_number_conversion_test.cc',
|
|
|
|
|
'stdlib/strlcpy_test.cc',
|
|
|
|
|
'stdlib/strnlen_test.cc',
|
2017-04-14 14:50:11 -04:00
|
|
|
'stdlib/thread_safe_vector_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'string/split_string_test.cc',
|
|
|
|
|
'synchronization/semaphore_test.cc',
|
|
|
|
|
'thread/thread_log_messages_test.cc',
|
2015-05-13 14:05:57 -04:00
|
|
|
'thread/thread_test.cc',
|
2016-01-04 17:10:58 -05:00
|
|
|
'thread/worker_thread_test.cc',
|
2015-11-02 13:59:36 -05:00
|
|
|
'win/command_line_test.cc',
|
2015-10-16 14:55:14 -07:00
|
|
|
'win/critical_section_with_debug_info_test.cc',
|
win: Crash handler server
This replaces the registration server, and adds dispatch to a delegate
on crash requests.
(As you are already aware) we went around in circles on trying to come
up with a slightly-too-fancy threading design. All of them seemed to
have problems when it comes to out of order events, and orderly
shutdown, so I've gone back to something not-too-fancy.
Two named pipe instances (that clients connect to) are created. These
are used only for registration (which should take <1ms), so 2 should be
sufficient to avoid any waits. When a client registers, we duplicate
an event to it, which is used to signal when it wants a dump taken.
The server registers threadpool waits on that event, and also on the
process handle (which will be signalled when the client process exits).
These requests (in particular the taking of the dump) are serviced
on the threadpool, which avoids us needing to manage those threads,
but still allows parallelism in taking dumps. On process termination,
we use an IO Completion Port to post a message back to the main thread
to request cleanup. This complexity is necessary so that we can
unregister the threadpool waits without being on the threadpool, which
we need to do synchronously so that we can be sure that no further
callbacks will execute (and expect to have the client data around
still).
In a followup, I will readd support for DumpWithoutCrashing -- I don't
think it will be too difficult now that we have an orderly way to
clean up client records in the server.
R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org
BUG=crashpad:1,crashpad:45
Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
|
|
|
'win/exception_handler_server_test.cc',
|
2015-10-19 14:32:07 -04:00
|
|
|
'win/get_function_test.cc',
|
2015-11-05 14:00:26 -05:00
|
|
|
'win/handle_test.cc',
|
2016-10-21 13:08:18 -07:00
|
|
|
'win/initial_client_data_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
'win/process_info_test.cc',
|
2016-12-07 11:35:07 -08:00
|
|
|
'win/registration_protocol_win_test.cc',
|
win: Wrap TerminateProcess() to accept cdecl patches on x86
TerminateProcess(), like most of the Windows API, is declared WINAPI,
which is __stdcall on 32-bit x86. That means that the callee,
TerminateProcess() itself, is responsible for cleaning up parameters on
the stack on return. In https://crashpad.chromium.org/bug/179, crashes
in ExceptionHandlerServer::OnNonCrashDumpEvent() were observed in ways
that make it evident that TerminateProcess() has been patched with a
__cdecl routine. The crucial difference between __stdcall and __cdecl is
that the caller is responsible for stack parameter cleanup in __cdecl.
The mismatch means that nobody cleans parameters from the stack, and the
stack pointer has an unexpected value, which in the case of the Crashpad
handler crash, results in TerminateProcess()’s second argument
erroneously being used as the lock address in the call to
ReleaseSRWLockExclusive() or LeaveCriticalSection().
As a workaround, on 32-bit x86, call through SafeTerminateProcess(), a
custom assembly routine that’s compatible with either __stdcall or
__cdecl implementations of TerminateProcess() by not trusting the value
of the stack pointer on return from that function. Instead, the stack
pointer is restored directly from the frame pointer.
Bug: crashpad:179
Test: crashpad_util_test SafeTerminateProcess.*, others
Change-Id: If9508f4eb7631020ea69ddbbe4a22eb335cdb325
Reviewed-on: https://chromium-review.googlesource.com/481180
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-19 13:22:08 -04:00
|
|
|
'win/safe_terminate_process_test.cc',
|
2015-09-08 10:09:26 -07:00
|
|
|
'win/scoped_process_suspend_test.cc',
|
2017-02-22 13:39:46 -05:00
|
|
|
'win/session_end_watcher_test.cc',
|
2015-03-31 17:06:28 -04:00
|
|
|
],
|
|
|
|
|
'conditions': [
|
|
|
|
|
['OS=="mac"', {
|
|
|
|
|
'link_settings': {
|
|
|
|
|
'libraries': [
|
|
|
|
|
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
}],
|
|
|
|
|
['OS=="win"', {
|
test: Move util/test to its own top-level directory, test.
After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib
to “hide” in util/util_test.gyp. All of util/test is moved to its own
top-level directory, test, which all other test code is allowed to
depend on. test, too, is allowed to depend on all other non-test code.
In a future change, when crashpad_util_test_lib gains a dependency on
crashpad_client, it won’t look so weird for something in util (even
though it’s in util/test) to depend on something in client, because the
thing that needs to depend on client will live in test, not util.
BUG=crashpad:33
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
|
|
|
'dependencies': [
|
2015-09-18 16:06:05 -07:00
|
|
|
'crashpad_util_test_process_info_test_child',
|
win: Wrap TerminateProcess() to accept cdecl patches on x86
TerminateProcess(), like most of the Windows API, is declared WINAPI,
which is __stdcall on 32-bit x86. That means that the callee,
TerminateProcess() itself, is responsible for cleaning up parameters on
the stack on return. In https://crashpad.chromium.org/bug/179, crashes
in ExceptionHandlerServer::OnNonCrashDumpEvent() were observed in ways
that make it evident that TerminateProcess() has been patched with a
__cdecl routine. The crucial difference between __stdcall and __cdecl is
that the caller is responsible for stack parameter cleanup in __cdecl.
The mismatch means that nobody cleans parameters from the stack, and the
stack pointer has an unexpected value, which in the case of the Crashpad
handler crash, results in TerminateProcess()’s second argument
erroneously being used as the lock address in the call to
ReleaseSRWLockExclusive() or LeaveCriticalSection().
As a workaround, on 32-bit x86, call through SafeTerminateProcess(), a
custom assembly routine that’s compatible with either __stdcall or
__cdecl implementations of TerminateProcess() by not trusting the value
of the stack pointer on return from that function. Instead, the stack
pointer is restored directly from the frame pointer.
Bug: crashpad:179
Test: crashpad_util_test SafeTerminateProcess.*, others
Change-Id: If9508f4eb7631020ea69ddbbe4a22eb335cdb325
Reviewed-on: https://chromium-review.googlesource.com/481180
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-19 13:22:08 -04:00
|
|
|
'crashpad_util_test_safe_terminate_process_test_child',
|
test: Move util/test to its own top-level directory, test.
After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib
to “hide” in util/util_test.gyp. All of util/test is moved to its own
top-level directory, test, which all other test code is allowed to
depend on. test, too, is allowed to depend on all other non-test code.
In a future change, when crashpad_util_test_lib gains a dependency on
crashpad_client, it won’t look so weird for something in util (even
though it’s in util/test) to depend on something in client, because the
thing that needs to depend on client will live in test, not util.
BUG=crashpad:33
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
|
|
|
],
|
2015-03-31 17:06:28 -04:00
|
|
|
'link_settings': {
|
|
|
|
|
'libraries': [
|
2016-12-07 11:35:07 -08:00
|
|
|
'-ladvapi32.lib',
|
2015-05-14 18:45:28 -07:00
|
|
|
'-limagehlp.lib',
|
2015-03-31 17:06:28 -04:00
|
|
|
'-lrpcrt4.lib',
|
2017-02-22 13:39:46 -05:00
|
|
|
'-luser32.lib',
|
2015-03-31 17:06:28 -04:00
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
}],
|
2017-03-14 13:05:40 -07:00
|
|
|
['OS=="android"', {
|
|
|
|
|
# Things not yet ported to Android
|
|
|
|
|
'sources/' : [
|
|
|
|
|
['exclude', '^net/http_transport_test\\.cc$'],
|
|
|
|
|
]
|
|
|
|
|
}],
|
2019-08-14 16:13:35 -07:00
|
|
|
['OS=="linux" or OS=="android"', {
|
|
|
|
|
'sources': [
|
2019-09-11 11:30:22 -07:00
|
|
|
'process/process_memory_sanitized_test.cc',
|
2019-08-14 16:13:35 -07:00
|
|
|
],
|
|
|
|
|
}],
|
2017-09-26 12:52:41 -07:00
|
|
|
['OS!="linux" and OS!="android"', {
|
|
|
|
|
'sources/': [
|
|
|
|
|
['exclude', '^process/'],
|
|
|
|
|
],
|
|
|
|
|
}],
|
2015-03-31 17:06:28 -04:00
|
|
|
],
|
2017-04-03 14:09:58 -07:00
|
|
|
'target_conditions': [
|
|
|
|
|
['OS=="android"', {
|
|
|
|
|
'sources/': [
|
|
|
|
|
['include', '^linux/'],
|
2018-02-08 16:25:22 -08:00
|
|
|
['include', '^misc/capture_context_test_util_linux\\.cc$'],
|
2017-04-03 14:09:58 -07:00
|
|
|
],
|
|
|
|
|
}],
|
|
|
|
|
],
|
2015-03-31 17:06:28 -04:00
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
'conditions': [
|
2018-05-10 22:58:14 -07:00
|
|
|
['OS!="android"', {
|
|
|
|
|
'targets': [
|
|
|
|
|
{
|
|
|
|
|
'target_name': 'http_transport_test_server',
|
|
|
|
|
'type': 'executable',
|
|
|
|
|
'dependencies': [
|
|
|
|
|
'../third_party/mini_chromium/mini_chromium.gyp:base',
|
|
|
|
|
'../third_party/zlib/zlib.gyp:zlib',
|
|
|
|
|
'../tools/tools.gyp:crashpad_tool_support',
|
|
|
|
|
'../util/util.gyp:crashpad_util',
|
|
|
|
|
],
|
|
|
|
|
'sources': [
|
|
|
|
|
'net/http_transport_test_server.cc',
|
|
|
|
|
],
|
|
|
|
|
'include_dirs': [
|
|
|
|
|
'..',
|
|
|
|
|
],
|
|
|
|
|
'xcode_settings': {
|
|
|
|
|
'WARNING_CFLAGS!': [
|
|
|
|
|
'-Wexit-time-destructors',
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
'cflags!': [
|
|
|
|
|
'-Wexit-time-destructors',
|
|
|
|
|
],
|
2018-08-08 10:46:21 -04:00
|
|
|
'conditions': [
|
|
|
|
|
['OS=="win"', {
|
|
|
|
|
'link_settings': {
|
|
|
|
|
'libraries': [
|
|
|
|
|
'-lws2_32.lib',
|
|
|
|
|
],
|
|
|
|
|
},
|
|
|
|
|
}],
|
|
|
|
|
],
|
2018-05-10 22:58:14 -07:00
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}],
|
2015-03-31 17:06:28 -04:00
|
|
|
['OS=="win"', {
|
|
|
|
|
'targets': [
|
|
|
|
|
{
|
2015-09-18 16:06:05 -07:00
|
|
|
'target_name': 'crashpad_util_test_process_info_test_child',
|
2015-03-31 17:06:28 -04:00
|
|
|
'type': 'executable',
|
|
|
|
|
'sources': [
|
|
|
|
|
'win/process_info_test_child.cc',
|
|
|
|
|
],
|
|
|
|
|
},
|
win: Wrap TerminateProcess() to accept cdecl patches on x86
TerminateProcess(), like most of the Windows API, is declared WINAPI,
which is __stdcall on 32-bit x86. That means that the callee,
TerminateProcess() itself, is responsible for cleaning up parameters on
the stack on return. In https://crashpad.chromium.org/bug/179, crashes
in ExceptionHandlerServer::OnNonCrashDumpEvent() were observed in ways
that make it evident that TerminateProcess() has been patched with a
__cdecl routine. The crucial difference between __stdcall and __cdecl is
that the caller is responsible for stack parameter cleanup in __cdecl.
The mismatch means that nobody cleans parameters from the stack, and the
stack pointer has an unexpected value, which in the case of the Crashpad
handler crash, results in TerminateProcess()’s second argument
erroneously being used as the lock address in the call to
ReleaseSRWLockExclusive() or LeaveCriticalSection().
As a workaround, on 32-bit x86, call through SafeTerminateProcess(), a
custom assembly routine that’s compatible with either __stdcall or
__cdecl implementations of TerminateProcess() by not trusting the value
of the stack pointer on return from that function. Instead, the stack
pointer is restored directly from the frame pointer.
Bug: crashpad:179
Test: crashpad_util_test SafeTerminateProcess.*, others
Change-Id: If9508f4eb7631020ea69ddbbe4a22eb335cdb325
Reviewed-on: https://chromium-review.googlesource.com/481180
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-19 13:22:08 -04:00
|
|
|
{
|
|
|
|
|
'target_name': 'crashpad_util_test_safe_terminate_process_test_child',
|
|
|
|
|
'type': 'executable',
|
|
|
|
|
'sources': [
|
|
|
|
|
'win/safe_terminate_process_test_child.cc',
|
|
|
|
|
],
|
|
|
|
|
},
|
2015-03-31 17:06:28 -04:00
|
|
|
]
|
|
|
|
|
}],
|
|
|
|
|
],
|
|
|
|
|
}
|
