3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-31 01:43:03 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/util/util_test.gyp

168 lines
5.6 KiB
Plaintext
Raw Normal View History

Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
# Copyright 2014 The Crashpad Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
{
'includes': [
'../build/crashpad.gypi',
],
'targets': [
{
'target_name': 'crashpad_util_test',
'type': 'executable',
'dependencies': [
'util.gyp:crashpad_util',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'../client/client.gyp:crashpad_client',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'../compat/compat.gyp:crashpad_compat',
test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX Previously on macOS, the test used an OS-specific library function to recover the original argc and argv. On Linux/Android, it essentially reimplemented the very code it was testing, which didn’t make for a very good test. The new approach is to save argc and argv in main() and base the comparison on that. Bug: crashpad:30 Test: crashpad_util_test ProcessInfo.*, crashpad_test_test MainArguments.* Change-Id: I578abed3b04ae10a22f79a193bbb8b6589276c97 Reviewed-on: https://chromium-review.googlesource.com/456798 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-03-18 00:18:20 -04:00
'../test/test.gyp:crashpad_gmock_main',
test: Move util/test to its own top-level directory, test. After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib to “hide” in util/util_test.gyp. All of util/test is moved to its own top-level directory, test, which all other test code is allowed to depend on. test, too, is allowed to depend on all other non-test code. In a future change, when crashpad_util_test_lib gains a dependency on crashpad_client, it won’t look so weird for something in util (even though it’s in util/test) to depend on something in client, because the thing that needs to depend on client will live in test, not util. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
'../test/test.gyp:crashpad_test',
Switch googletest and googlemock to pull from the GitHub git repository R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1404033002 .
2015-11-11 11:13:37 -05:00
'../third_party/gtest/gmock.gyp:gmock',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'../third_party/gtest/gtest.gyp:gtest',
'../third_party/mini_chromium/mini_chromium.gyp:base',
Use zlib to gzip-compress uploads This adds zlib to Crashpad. By default in standalone Crashpad builds, the system zlib will be used where available. A copy of Chromium’s zlib (currently a slightly patched 1.2.11) is checked out via DEPS into third_party for use on Windows, which does not have a system zlib. zlib is used to produce gzip streams for HTTP upload request bodies sent by crashpad_handler by default. The Content-Encoding: gzip header is set for these compressed request bodies. Compression can be disabled for upload to servers without corresponding decompression support by starting crashpad_handler with the --no-upload-gzip option. Most minidumps compress quite well with zlib. A size reduction of 90% is not uncommon. BUG=crashpad:157 TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.* Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513 Reviewed-on: https://chromium-review.googlesource.com/438585 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-15 19:54:19 -05:00
'../third_party/zlib/zlib.gyp:zlib',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
],
'include_dirs': [
'..',
],
'sources': [
Add DelimitedFileReader and use it in Linux/Android’s ProcessInfo This implements a non-stdio-based getline() equivalent. getline() is not in the Android NDK until API 21 (Android 5.0.0), while Chrome builds for 32-bit platforms with API 16 (Android 4.1.0). Although a getline() declaration could be provided in compat for use with older NDK headers, it’s desirable to move away from stdio entirely. The C++ DelimitedFileReader interface is also a bit more comfortable to use than getline(). A getdelim() equivalent is also provided, and is also used in the Linux/Android ProcessInfo implementation. Bug: crashpad:30 Test: crashpad_util_test FileLineReader.*:ProcessInfo.* Change-Id: Ic1664758a87cfe4953ab22bd3ae190761404b22c Reviewed-on: https://chromium-review.googlesource.com/455998 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-03-16 10:52:27 -04:00
'file/delimited_file_reader_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'file/file_io_test.cc',
util/file: Handle oversized reads and writes gracefully file_io and the FileReader family had a few loose ends regarding big reads and writes. It’s not likely that we’ve experienced these conditions yet, but they’d be likely to appear in a potential future involving full memory dumps. This specifies the behavior with large reads and writes, consolidates some logic, and improves some interfaces. ReadFile() should always return without retrying after a short read, and in fact does return after short reads since 00b64427523b. It is straightforward to limit the maximum read size based on a parameter limitation of the underlying operation, or a limitation of the type used for FileOperationResult. In contrast, WriteFile() should always retry after a short write, including a write shortened because of a parameter limitation of the underlying operation, or a limitation of the type used for FileOperationResult. This allows its return value to be simplified to a “bool”. The platform-specific WriteFile() code has been moved to internal::NativeWriteFile(), and the platform-independent loop that retries following a short write has been refactored into internal::WriteAllInternal so that it can be used by a new test. The platform-agnostic ReadFileExactlyInternal() implementation has been refactored into internal::ReadExactlyInternal so that it can be used by a new test and by FileReaderInterface::ReadExactly(), which had a nearly identical implementation. Test: crashpad_util_test FileIO.ReadExactly_*:FileIO.WriteAll_*:FileReader.ReadExactly_* Change-Id: I487450322ab049c6f2acd4061ea814037cc9a864 Reviewed-on: https://chromium-review.googlesource.com/456824 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-03-21 15:08:05 -04:00
'file/file_reader_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'file/string_file_test.cc',
'mac/launchd_test.mm',
'mac/mac_util_test.mm',
'mac/service_management_test.mm',
'mac/xattr_test.cc',
'mach/child_port_handshake_test.cc',
'mach/child_port_server_test.cc',
'mach/composite_mach_message_server_test.cc',
'mach/exc_client_variants_test.cc',
'mach/exc_server_variants_test.cc',
'mach/exception_behaviors_test.cc',
'mach/exception_ports_test.cc',
Accept non-fatal resource exceptions without generating crash reports. This adds IsExceptionNonfatalResource() and its test, and uses it in crashpad_handler. When non-fatal resource exceptions are encountered, no crash report is generated. crashpad_handler swallows these exceptions. Alternatively, it could allow them to be sent to the system’s host-level resource exception handler, normally com.apple.ReportCrash.root, which would allow them to be processed in the same way as when Crashpad is not in use. I’m not sure which option is better. I chose to swallow them because there doesn’t appear to be much value in letting com.apple.ReportCrash.root and spindump look at them. This also moves ExcCrashRecoverOriginalException() to the new file as a sibling of IsExceptionNonfatalResource(). This provides better organization. BUG=crashpad:35, chromium:474163, chromium:474326 TEST=crashpad_util_test ExceptionTypes.IsExceptionNonfatalResource R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1066243002
2015-04-08 17:46:09 -04:00
'mach/exception_types_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'mach/mach_extensions_test.cc',
'mach/mach_message_server_test.cc',
'mach/mach_message_test.cc',
'mach/notify_server_test.cc',
'mach/scoped_task_suspend_test.cc',
'mach/symbolic_constants_mach_test.cc',
'mach/task_memory_test.cc',
GCC fix: Don’t use arraysize() on packed structs While compiling, for example, minidump_exception_writer.cc: In file included from ../../minidump/minidump_exception_writer.h:26:0, from ../../minidump/minidump_exception_writer.cc:15: ../../minidump/minidump_exception_writer.cc: In member function ‘void crashpad::MinidumpExceptionWriter::SetExceptionInformation(const std::vector<long unsigned int>&)’: ../../minidump/minidump_exception_writer.cc:67:44: error: cannot bind packed field ‘((crashpad::MinidumpExceptionWriter*)this)->crashpad::MinidumpExceptionWriter::exception_.MINIDUMP_EXCEPTION_STREAM::ExceptionRecord.MINIDUMP_EXCEPTION::ExceptionInformation’ to ‘long unsigned int (&)[15]’ arraysize(exception_.ExceptionRecord.ExceptionInformation); ~~~~~~~~~~~~~~~~~~~~~~~~~~~^ ../../third_party/mini_chromium/mini_chromium/base/macros.h:41:50: note: in definition of macro ‘arraysize’ #define arraysize(array) (sizeof(ArraySizeHelper(array))) Tested with: - GCC 4.9 from NDK r13 targeting arm with SDK 16 - GCC 4.9 from NDK r13 targeting arm64 with SDK 21 - GCC 6.2 targeting x86_64 BUG=crashpad:30 Change-Id: I63963b277a309b4715148215f51902c33ba13b5a Reviewed-on: https://chromium-review.googlesource.com/409694 Reviewed-by: Scott Graham <scottmg@chromium.org>
2016-11-10 14:39:51 -05:00
'misc/arraysize_unsafe_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'misc/clock_test.cc',
'misc/initialization_state_dcheck_test.cc',
'misc/initialization_state_test.cc',
“Promote” test::Paths::Executable() to Paths::Executable() This supports the “double handler” or “double handler with low probability” models from https://crashpad.chromium.org/bug/143. For crashpad_handler to be become its own client, it needs access to its own executable path to pass to CrashpadClient::StartHandler(). This was formerly available in the test-only test::Paths::Executable(). Bring that function’s implementation to the non-test Paths::Executable() in util/misc, and rename test::Paths to test::TestPaths to avoid future confusion. test::TestPaths must still be used to access TestDataRoot(), which does not make any sense to non-test code. test::TestPaths::Executable() is retained for use by tests, which most likely prefer the fatal semantics of that function. Paths::Executable() is not fatal because for the purposes of implementing the double handler, a failure to locate the executable path (which may happen on some systems in deeply-nested directory hierarchies) shouldn’t cause the initial crashpad_handler to abort, even if it does prevent a second crashpad_handler from being started. Bug: crashpad:143 Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.* Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156 Reviewed-on: https://chromium-review.googlesource.com/466346 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-04-03 13:53:11 -04:00
'misc/paths_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'misc/scoped_forbid_return_test.cc',
Add RandomString() and its test, and use it everywhere it makes sense This unifies several things that used a 16-character random string, and a few other users of random identifiers where it also made sense to use a 16-character random string. TEST=crashpad_util_test RandomString.RandomString R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1451793002 .
2015-11-16 13:39:01 -05:00
'misc/random_string_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'misc/uuid_test.cc',
Use zlib to gzip-compress uploads This adds zlib to Crashpad. By default in standalone Crashpad builds, the system zlib will be used where available. A copy of Chromium’s zlib (currently a slightly patched 1.2.11) is checked out via DEPS into third_party for use on Windows, which does not have a system zlib. zlib is used to produce gzip streams for HTTP upload request bodies sent by crashpad_handler by default. The Content-Encoding: gzip header is set for these compressed request bodies. Compression can be disabled for upload to servers without corresponding decompression support by starting crashpad_handler with the --no-upload-gzip option. Most minidumps compress quite well with zlib. A size reduction of 90% is not uncommon. BUG=crashpad:157 TEST=crashpad_util_test GzipHTTPBodyStream.*:HTTPTransport.* Change-Id: I99b86db3952c3685cd78f5dc858a60b54399c513 Reviewed-on: https://chromium-review.googlesource.com/438585 Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-02-15 19:54:19 -05:00
'net/http_body_gzip_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'net/http_body_test.cc',
'net/http_body_test_util.cc',
'net/http_body_test_util.h',
'net/http_multipart_builder_test.cc',
'net/http_transport_test.cc',
win: make CrashpadInfo retrievable The main goal was to get the beginnings of module iteration and retrieval of CrashpadInfo in snapshot. The main change for that is to move crashpad_info_client_options[_test] down out of mac/. This also requires adding some of the supporting code of snapshot in ProcessReaderWin, ProcessSnapshotWin, and ModuleSnapshotWin. These are partially copied from Mac or stubbed out with lots of TODO annotations. This is a bit unfortunate, but seemed like the most productive way to make progress incrementally. That is, it's mostly placeholder at the moment, but hopefully has the right shape for things to come. R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1052813002
2015-05-01 13:48:23 -07:00
'numeric/checked_address_range_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'numeric/checked_range_test.cc',
'numeric/in_range_cast_test.cc',
'numeric/int128_test.cc',
'posix/process_info_test.cc',
posix: Add ScopedMmap for managing memory-mapped regions This wraps mmap(), munmap(), and mprotect(). Bug: crashpad:30 Test: crashpad_util_test ScopedMmap.* Change-Id: If14363dfd00e314482cc91e53c7f4e3df737b0d3 Reviewed-on: https://chromium-review.googlesource.com/461361 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2017-03-28 12:21:43 -04:00
'posix/scoped_mmap_test.cc',
Add Signals, utilities for signal handling Use these utilities for signal handling in crashpad_handler BUG=crashpad:30 TEST=crashpad_util_test Signals.* Change-Id: I6c9a1de35c4a81b58d77768c4753bdba5ebea4df Reviewed-on: https://chromium-review.googlesource.com/446917 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-01 10:00:59 -05:00
'posix/signals_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'posix/symbolic_constants_posix_test.cc',
Add AlignedVector and use it for vector<MEMORY_BASIC_INFORMATION64> MEMORY_BASIC_INFORMATION64 specifies an alignment of 16, but the standard allocator used by containers doesn't honor this. Although 16 is the default alignment size used on Windows for x86_64, it's not for 32-bit x86. clang assumed that the alignment of the structure was as declared, and used an SSE load sequence that required this alignment. AlignedAllocator is a replacement for std::allocator that allows the alignment to be specified. AlignedVector is an std::vector<> that uses AlignedAllocator instead of std::allocator. BUG=chromium:564691 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1498133002 .
2015-12-08 15:38:17 -05:00
'stdlib/aligned_allocator_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'stdlib/map_insert_test.cc',
'stdlib/string_number_conversion_test.cc',
'stdlib/strlcpy_test.cc',
'stdlib/strnlen_test.cc',
'string/split_string_test.cc',
'synchronization/semaphore_test.cc',
'thread/thread_log_messages_test.cc',
Move thread from test/ to util/thread/. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1134943003
2015-05-13 14:05:57 -04:00
'thread/thread_test.cc',
Create WorkerThread, an abstraction to perform some work on an interval. This was extracted from CrashReportUploadThread and will be re-used for the database pruning thread. BUG=crashpad:22 R=mark@chromium.org Review URL: https://codereview.chromium.org/1526563003 .
2016-01-04 17:10:58 -05:00
'thread/worker_thread_test.cc',
win: Add and use a custom CaptureContext() implementation RtlCaptureContext() is buggy and limited. BUG=crashpad:53 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1377963002 .
2015-09-30 14:10:08 -04:00
'win/capture_context_test.cc',
win: Implement CrashpadClient::StartHandler() BUG=crashpad:69 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1428803006 .
2015-11-02 13:59:36 -05:00
'win/command_line_test.cc',
Fix CRITICAL_SECTION test I thought I had confirmed that this still allocated and ignored the flag on older OSs, but I must have not had the PLOG active yet? I'm not sure what I did. (I might try to blame VMware as it has an annoying habit of caching old binaries when you use it's "Shared Folders" feature to point at the dev machine's build dir.) I confirmed that it does work on Win8 and Win10 but doesn't on Win XP and Win 7. R=mark@chromium.org BUG=crashpad:52 Review URL: https://codereview.chromium.org/1405243002 .
2015-10-16 14:55:14 -07:00
'win/critical_section_with_debug_info_test.cc',
win: Crash handler server This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
2015-09-03 11:06:17 -07:00
'win/exception_handler_server_test.cc',
win: Add and use GET_FUNCTION() and GET_FUNCTION_REQUIRED() These wrap the GetProcAddress(LoadLibrary(), …) idiom into macros that are much less wordy. TEST=crashpad_util_test GetFunction.GetFunction and all others R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1405323003 .
2015-10-19 14:32:07 -04:00
'win/get_function_test.cc',
win: Add HandleToInt() and IntToHandle() This consolidates all of the twisted casts and comments that discuss how HANDLEs are really only 32 bits wide even in 64-bit processes on 64-bit operating systems into a single location. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1422503015 .
2015-11-05 14:00:26 -05:00
'win/handle_test.cc',
win: Start crashpad_handler by inheriting connection data to it Previously, StartHandler() launched the handler process, then connected over a pipe to register for crash handling. Instead, the initial client can create and inherit handles to the handler and pass those handle values and other data (addresses, etc.) on the command line. This should improve startup time as there's no need to synchronize with the process at startup, and allows avoiding a call to CreateProcess() directly in StartHandler(), which is important for registration for crash reporting from DllMain(). Incidentally adds new utility functions for string/number conversion and string splitting. Note: API change; UseHandler() is removed for all platforms. BUG=chromium:567850,chromium:656800 Change-Id: I1602724183cb107f805f109674c53e95841b24fd Reviewed-on: https://chromium-review.googlesource.com/400015 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-10-21 13:08:18 -07:00
'win/initial_client_data_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'win/process_info_test.cc',
win: Remove use of rpcrt4 and advapi32 from some util code ConvertStringSecurityDescriptorToSecurityDescriptor() is used when creating the initial connection pipe. Because this is done from inside DllMain(), we cannot use advapi32 (where this function is). Instead, save the binary representation of the self-relative SECURITY_DESCRIPTOR. It is conceivable that this could change, but unlikely as this is the same blob that would be stored on a file in NTFS. Another potential approach would be to not make the pipe available to all integrity levels here, and instead modify the Chromium sandbox code to allow a specific pipe name prefix that would have to correspond with the pipe name that Crashpad creates. Similarly, UuidCreate() (used when initializing the database) is in a DLL that can't be loaded early, so use the Linux/Android implementation on Windows too. R=mark@chromium.org BUG=chromium:655788,chromium:656800 Change-Id: I434f8e96fc275fc30d0a31208b025bfc08595ff9 Reviewed-on: https://chromium-review.googlesource.com/417223 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-12-07 11:35:07 -08:00
'win/registration_protocol_win_test.cc',
win: Implement and use ScopedProcessSuspend R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/1303173011 .
2015-09-08 10:09:26 -07:00
'win/scoped_process_suspend_test.cc',
metrics: Record handler lifetime milestone events It could be useful to put our existing Crashpad.HandlerCrashed metrics into context by getting a sense of handler starts, clean exits, and other types of exits. BUG=crashpad:100 Change-Id: I8982075158ea6d210eb2ddad678302e339a42192 Reviewed-on: https://chromium-review.googlesource.com/444124 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-22 13:39:46 -05:00
'win/session_end_watcher_test.cc',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'win/time_test.cc',
],
'conditions': [
['OS=="mac"', {
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
],
},
}],
['OS=="win"', {
test: Move util/test to its own top-level directory, test. After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib to “hide” in util/util_test.gyp. All of util/test is moved to its own top-level directory, test, which all other test code is allowed to depend on. test, too, is allowed to depend on all other non-test code. In a future change, when crashpad_util_test_lib gains a dependency on crashpad_client, it won’t look so weird for something in util (even though it’s in util/test) to depend on something in client, because the thing that needs to depend on client will live in test, not util. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
'dependencies': [
win: support x64 reading x86 (wow64) Removes the bitness-specific targets in favour of pulling binaries from the other build directory. This is to avoid the added complexity of duplicating all the targets for the x86 in x64 build. Overall, mostly templatizing more functions to support the wow64-flavoured structures. The only additional functionality required is reading the x86 TEB that's chained from the x64 TEB when running as WOW64. The crashing child test was switched to a manual CreateProcess because it needs to launch a binary other than itself. R=mark@chromium.org BUG=crashpad:50 Review URL: https://codereview.chromium.org/1349313003 .
2015-09-18 16:06:05 -07:00
'crashpad_util_test_process_info_test_child',
test: Move util/test to its own top-level directory, test. After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib to “hide” in util/util_test.gyp. All of util/test is moved to its own top-level directory, test, which all other test code is allowed to depend on. test, too, is allowed to depend on all other non-test code. In a future change, when crashpad_util_test_lib gains a dependency on crashpad_client, it won’t look so weird for something in util (even though it’s in util/test) to depend on something in client, because the thing that needs to depend on client will live in test, not util. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
],
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'link_settings': {
'libraries': [
win: Remove use of rpcrt4 and advapi32 from some util code ConvertStringSecurityDescriptorToSecurityDescriptor() is used when creating the initial connection pipe. Because this is done from inside DllMain(), we cannot use advapi32 (where this function is). Instead, save the binary representation of the self-relative SECURITY_DESCRIPTOR. It is conceivable that this could change, but unlikely as this is the same blob that would be stored on a file in NTFS. Another potential approach would be to not make the pipe available to all integrity levels here, and instead modify the Chromium sandbox code to allow a specific pipe name prefix that would have to correspond with the pipe name that Crashpad creates. Similarly, UuidCreate() (used when initializing the database) is in a DLL that can't be loaded early, so use the Linux/Android implementation on Windows too. R=mark@chromium.org BUG=chromium:655788,chromium:656800 Change-Id: I434f8e96fc275fc30d0a31208b025bfc08595ff9 Reviewed-on: https://chromium-review.googlesource.com/417223 Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-12-07 11:35:07 -08:00
'-ladvapi32.lib',
win: Fix module timestamp test This test was added in https://codereview.chromium.org/1052813002. It was previously checking the timestamp from in-memory module traversal vs. the disk mtime. This is flaky (of course) because it depends on the linker writing the header and closing the file during the same time quantum. So the bots occasionally failed with: [ RUN ] ProcessInfo.Self e:\b\build\slave\chromium_win_dbg\build\crashpad\util\win\process_info_test.cc(86): error: Value of: GetTimestampForModule(GetModuleHandleW(nullptr)) Actual: 1431650338 Expected: modules[0].timestamp Which is: 1431650337 Instead, use imagehlp to pull the timestamp out of the header so that it matches the header value that will be the in-memory timestamp. R=cpu@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1139103003
2015-05-14 18:45:28 -07:00
'-limagehlp.lib',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'-lrpcrt4.lib',
metrics: Record handler lifetime milestone events It could be useful to put our existing Crashpad.HandlerCrashed metrics into context by getting a sense of handler starts, clean exits, and other types of exits. BUG=crashpad:100 Change-Id: I8982075158ea6d210eb2ddad678302e339a42192 Reviewed-on: https://chromium-review.googlesource.com/444124 Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-02-22 13:39:46 -05:00
'-luser32.lib',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
],
},
}],
Implement ProcessInfo for Linux/Android Bug: crashpad:30 Change-Id: I45853a96cdbe94a2dbf3fa265b015170badb1bbb Reviewed-on: https://chromium-review.googlesource.com/446903 Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-03-14 13:05:40 -07:00
['OS=="android"', {
# Things not yet ported to Android
'sources/' : [
['exclude', '^net/http_transport_test\\.cc$'],
]
}],
['OS=="android" or OS=="linux"' , {
# Things not yet ported to Android or Linux
'sources/' : [
['exclude', '^numeric/checked_address_range_test\\.cc$'],
]
}],
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
],
},
],
'conditions': [
['OS=="win"', {
'targets': [
{
win: support x64 reading x86 (wow64) Removes the bitness-specific targets in favour of pulling binaries from the other build directory. This is to avoid the added complexity of duplicating all the targets for the x86 in x64 build. Overall, mostly templatizing more functions to support the wow64-flavoured structures. The only additional functionality required is reading the x86 TEB that's chained from the x64 TEB when running as WOW64. The crashing child test was switched to a manual CreateProcess because it needs to launch a binary other than itself. R=mark@chromium.org BUG=crashpad:50 Review URL: https://codereview.chromium.org/1349313003 .
2015-09-18 16:06:05 -07:00
'target_name': 'crashpad_util_test_process_info_test_child',
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
'type': 'executable',
'sources': [
'win/process_info_test_child.cc',
],
# Set an unusually high load address to make sure that the main
# executable still appears as the first element in
# ProcessInfo::Modules().
'msvs_settings': {
'VCLinkerTool': {
'AdditionalOptions': [
'/BASE:0x78000000',
],
win: Disable ASLR on test binary that uses fixed base This causes a link error on msvs builds which we don't care about, but in general if build/common.gypi forced RandomizedBaseAddress (e.g. in Chrome), it makes sense to be explicit about disabling it for this binary. R=mark@chromium.org BUG=https://groups.google.com/a/chromium.org/d/msg/crashpad-dev/jMtnDldRnJI/kNx7ZDxMAwAJ Review URL: https://codereview.chromium.org/1376913004 .
2015-10-01 11:13:50 -07:00
'RandomizedBaseAddress': '1', # /DYNAMICBASE:NO.
'FixedBaseAddress': '2', # /FIXED.
Split *_test.gyp from *.gyp. In a future change, crashpad_util_test_lib will gain a dependency on crashpad_client. This would violate GYP’s prohibition on circular dependencies between .gyp files, although there would be no circular relationship between the targets themselves. To overcome this problem, all test-related targets are moved into their own first-class .gyp files. BUG=crashpad:33 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1045173004
2015-03-31 17:06:28 -04:00
},
},
},
]
}],
],
}
Reference in New Issue Copy Permalink