mirror of https://github.com/chromium/crashpad.git synced 2025-01-14 01:08:01 +08:00

Go to file

Mark Mentovai 4688351623 “Promote” test::Paths::Executable() to Paths::Executable()

This supports the “double handler” or “double handler with low
probability” models from https://crashpad.chromium.org/bug/143.

For crashpad_handler to be become its own client, it needs access to its
own executable path to pass to CrashpadClient::StartHandler(). This was
formerly available in the test-only test::Paths::Executable(). Bring
that function’s implementation to the non-test Paths::Executable() in
util/misc, and rename test::Paths to test::TestPaths to avoid future
confusion.

test::TestPaths must still be used to access TestDataRoot(), which does
not make any sense to non-test code.

test::TestPaths::Executable() is retained for use by tests, which most
likely prefer the fatal semantics of that function. Paths::Executable()
is not fatal because for the purposes of implementing the double
handler, a failure to locate the executable path (which may happen on
some systems in deeply-nested directory hierarchies) shouldn’t cause the
initial crashpad_handler to abort, even if it does prevent a second
crashpad_handler from being started.

Bug: crashpad:143
Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.*
Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156
Reviewed-on: https://chromium-review.googlesource.com/466346
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

2017-04-03 18:58:01 +00:00

build

android: Support “unified headers” with GCC build

2017-03-23 19:20:35 +00:00

client

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

compat

android: Support builds with NDK API versions older than 21 (compat)

2017-03-15 17:48:12 +00:00

doc

“Promote” test::Paths::Executable() to Paths::Executable()