From 9b67ea265b21be5fade31ab64bdc7e1a983fa682 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sigbj=C3=B8rn=20Skj=C3=A6ret?= Date: Tue, 8 Jul 2025 18:11:19 +0200 Subject: [PATCH] use std::string --- common/common.cpp | 8 ++++++-- common/common.h | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/common/common.cpp b/common/common.cpp index 9567f99b8..420ee6cd1 100644 --- a/common/common.cpp +++ b/common/common.cpp @@ -981,6 +981,8 @@ struct common_init_result common_init_from_params(common_params & params) { } } + char buf[1024]; + // load and optionally apply lora adapters for (auto & la : params.lora_adapters) { llama_adapter_lora_ptr lora; @@ -993,8 +995,10 @@ struct common_init_result common_init_from_params(common_params & params) { } la.ptr = lora.get(); - llama_adapter_meta_val_str(la.ptr, "adapter.lora.task_name", la.task_name, sizeof(la.task_name)); - llama_adapter_meta_val_str(la.ptr, "adapter.lora.prompt_prefix", la.prompt_prefix, sizeof(la.prompt_prefix)); + llama_adapter_meta_val_str(la.ptr, "adapter.lora.task_name", buf, sizeof(buf)); + la.task_name = buf; + llama_adapter_meta_val_str(la.ptr, "adapter.lora.prompt_prefix", buf, sizeof(buf)); + la.prompt_prefix = buf; iparams.lora.emplace_back(std::move(lora)); // copy to list of loaded adapters } diff --git a/common/common.h b/common/common.h index 42e1c29e3..705295a80 100644 --- a/common/common.h +++ b/common/common.h @@ -31,8 +31,8 @@ struct common_adapter_lora_info { std::string path; float scale; - char task_name[64]; - char prompt_prefix[256]; + std::string task_name; + std::string prompt_prefix; struct llama_adapter_lora * ptr; };