From 6d507bbeb00fe9ffed2d37cbafbf0ceb149d9564 Mon Sep 17 00:00:00 2001 From: Aaron Teo Date: Sat, 21 Jun 2025 16:23:23 +0800 Subject: [PATCH] ggml-cpu: switch to vec_xst for 4 element loops also Signed-off-by: Aaron Teo --- ggml/src/ggml-cpu/ggml-cpu.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/ggml/src/ggml-cpu/ggml-cpu.c b/ggml/src/ggml-cpu/ggml-cpu.c index 0e7d55627..095bddab6 100644 --- a/ggml/src/ggml-cpu/ggml-cpu.c +++ b/ggml/src/ggml-cpu/ggml-cpu.c @@ -3175,26 +3175,21 @@ void ggml_cpu_fp16_to_fp32(const ggml_fp16_t * x, float * y, int64_t n) { uint16x8_t v_xd = vec_convert_from_fp16(v_x, 0); float32x4_t v_xdh = vec_extend_to_fp32_hi(v_xd, 0); float32x4_t v_xdl = vec_extend_to_fp32_lo(v_xd, 0); - vec_xst(v_xdh, 0, (float *)(y + i)); + vec_xst(v_xdh, 0, (float *)(y + i + 0)); vec_xst(v_xdl, 0, (float *)(y + i + 4)); - // y[i + 0] = v_xdh[0]; - // y[i + 1] = v_xdh[1]; - // y[i + 2] = v_xdh[2]; - // y[i + 3] = v_xdh[3]; - // y[i + 4] = v_xdl[0]; - // y[i + 5] = v_xdl[1]; - // y[i + 6] = v_xdl[2]; - // y[i + 7] = v_xdl[3]; + (void); } for (; i + 3 < n; i += 4) { uint16x8_t v_x = vec_xl(0, (const ggml_fp16_t *)(x + i)); uint16x8_t nnpa_dfl16 = vec_convert_from_fp16(v_x, 0); float32x4_t result = vec_extend_to_fp32_hi(nnpa_dfl16, 0); - y[i + 0] = result[0]; - y[i + 1] = result[1]; - y[i + 2] = result[2]; - y[i + 3] = result[3]; + vec_xst(result, 0, (float *)(y + i)); + (void); + // y[i + 0] = result[0]; + // y[i + 1] = result[1]; + // y[i + 2] = result[2]; + // y[i + 3] = result[3]; } #endif